Issue with upgrade and setting the blocktype_installed_viewtypes values correctly

[Robert Lyon]

When we add a new view type we update the blocktype_installed_viewtype table to know what blocks can be used on this new view type.

But if we have an upgrade path where we add two new view types in one upgrade session then the information is not correct from Blocktype::get_viewtypes() because it is set to be static.

We need it to ignore this static-ness on upgrade.

To test:

Install a 20.04_STABLE site
Upgrade to main
Run the following command in database:
select * from blocktype_installed_viewtype where viewtype = 'activity' order by blocktype;

Should see:
29 (or 30) rows including 'placeholder' and 'image' blocktypes

Actually see:

21 (or 22) rows and 'placeholder' and 'image' blocktypes are missing

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13740
Committed: https://git.mahara.org/mahara/mahara/commit/eb7abacbcbfa906e9662fd5cb7cfbc881c005973
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit eb7abacbcbfa906e9662fd5cb7cfbc881c005973
Author: Robert Lyon <email address hidden>
Date: Thu Feb 9 11:14:32 2023 +1300

Bug 2006637: Problem with populating blocktype_installed_viewtype table

For Blocktype::get_viewtypes() the list it returns is static
so if there are more than one call to it during an upgrade it doesn't
pick up any new viewtypes added after the first call.

In upgrade we need it to not be static

Change-Id: I023b0488929138a597a5a1ad058c2c344e23649f
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "22.10_DEV" branch: https://reviews.mahara.org/c/mahara/+/13760

[Mahara Bot (dev-mahara)]

Patch for "22.04_DEV" branch: https://reviews.mahara.org/c/mahara/+/13761

[Mahara Bot (dev-mahara)]

Patch for "21.10_DEV" branch: https://reviews.mahara.org/c/mahara/+/13762

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13761
Committed: https://git.mahara.org/mahara/mahara/commit/c12a1f302490e2993937abe7dbb408f9ddb34407
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.04_DEV

commit c12a1f302490e2993937abe7dbb408f9ddb34407
Author: Robert Lyon <email address hidden>
Date: Thu Feb 9 11:14:32 2023 +1300

Bug 2006637: Problem with populating blocktype_installed_viewtype table

For Blocktype::get_viewtypes() the list it returns is static
so if there are more than one call to it during an upgrade it doesn't
pick up any new viewtypes added after the first call.

In upgrade we need it to not be static

Change-Id: I023b0488929138a597a5a1ad058c2c344e23649f
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit eb7abacbcbfa906e9662fd5cb7cfbc881c005973)

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13762
Committed: https://git.mahara.org/mahara/mahara/commit/464e7303a7e77dbe482a6012a7c4106ddd6a4b15
Submitter: "Robert Lyon <email address hidden>"
Branch: 21.10_DEV

commit 464e7303a7e77dbe482a6012a7c4106ddd6a4b15
Author: Robert Lyon <email address hidden>
Date: Thu Feb 9 11:14:32 2023 +1300

Bug 2006637: Problem with populating blocktype_installed_viewtype table

For Blocktype::get_viewtypes() the list it returns is static
so if there are more than one call to it during an upgrade it doesn't
pick up any new viewtypes added after the first call.

In upgrade we need it to not be static

Change-Id: I023b0488929138a597a5a1ad058c2c344e23649f
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit eb7abacbcbfa906e9662fd5cb7cfbc881c005973)

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13760
Committed: https://git.mahara.org/mahara/mahara/commit/103f1efd5c0aa713b42f0471960facf68378276f
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.10_DEV

commit 103f1efd5c0aa713b42f0471960facf68378276f
Author: Robert Lyon <email address hidden>
Date: Thu Feb 9 11:14:32 2023 +1300

Bug 2006637: Problem with populating blocktype_installed_viewtype table

For Blocktype::get_viewtypes() the list it returns is static
so if there are more than one call to it during an upgrade it doesn't
pick up any new viewtypes added after the first call.

In upgrade we need it to not be static

Change-Id: I023b0488929138a597a5a1ad058c2c344e23649f
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit eb7abacbcbfa906e9662fd5cb7cfbc881c005973)