preinst conffile prompt avoidance restores wrong conffile for later versions
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-advantage-tools (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Xenial |
Fix Released
|
Undecided
|
Unassigned | ||
Bionic |
Fix Released
|
Undecided
|
Unassigned | ||
Focal |
Fix Released
|
Undecided
|
Unassigned | ||
Jammy |
Fix Released
|
Undecided
|
Unassigned | ||
Kinetic |
Fix Released
|
Undecided
|
Unassigned | ||
Lunar |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Impact]
Users who upgrade from 27.13.X to the next version (27.13.3) could experience one of two things:
If they had run `pro config set apt_news=false` then our preinst code to handle that conffile change will not do anything because the md5sum in `preinst` is incomplete. This is okay because we haven't changed the default conffile in 27.13.3, but we should still fix it as it could affect future versions.
If they had run `pro config set apt_news=true` then our preinst code would restore a non-default conffile, so the user would still have an edited conffile even after the preinst code runs. This is also okay for now because we haven't changed the default conffile in 27.13.3, but we should still fix it as it could affect future versions.
[Test Case]
Ensure the following upgrade paths do not cause conffile prompts:
27.11.3 -> 27.13.3 and debsums -e ubuntu-
27.11.3 with pro config set apt_news=false -> 27.13.3
27.11.3 with pro config set apt_news=true -> 27.13.3 and debsums -e ubuntu-
27.12 -> 27.13.3 and debsums -e ubuntu-
27.12 with pro config set apt_news=false -> 27.13.3
27.12 with pro config set apt_news=true -> 27.13.3 and debsums -e ubuntu-
27.13.1 -> 27.13.3 and debsums -e ubuntu-
27.13.1 with pro config set apt_news=false -> 27.13.3
27.13.1 with pro config set apt_news=true -> 27.13.3 and debsums -e ubuntu-
27.13.2 -> 27.13.3 and debsums -e ubuntu-
27.13.2 with pro config set apt_news=false -> 27.13.3
27.13.2 with pro config set apt_news=true -> 27.13.3 and debsums -e ubuntu-
[Regression Potential]
We haven't done the proper fix for #2003977 yet, so if we didn't properly update the preinst hack to avoid prompts, that bug may reoccur. As part of this release we are ensuring the checksums in preinst are accurate and will still properly gaurd against this bug for upgrades from all applicable versions: 27.11.3, 27.12, 27.13.1, 27.13.2. Testing these upgrade paths is a part of the verification for this SRU.
[Discussion]
This is an extension of the temporary fix for #2003977 - it is not a permanent solution. We will introduce a permanent solution in our next release: 27.13.4. The permanent solution is being tracked in #2004280
Related branches
- Andreas Hasenack: Approve
- Robie Basak: Approve
- Canonical Server Reporter: Pending requested
-
Diff: 203 lines (+112/-7)6 files modifieddebian/changelog (+14/-0)
debian/ubuntu-advantage-tools.preinst (+31/-5)
features/steps/network.py (+23/-0)
features/unattached_commands.feature (+36/-0)
uaclient/apt.py (+7/-1)
uaclient/version.py (+1/-1)
description: | updated |
Hello Grant, or anyone else affected,
Accepted ubuntu- advantage- tools into kinetic-proposed. The package will build now and be available at https:/ /launchpad. net/ubuntu/ +source/ ubuntu- advantage- tools/27. 13.3~22. 10.1 in a few hours, and then in the -proposed repository.
Please help us by testing this new package. See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification- needed- kinetic to verification- done-kinetic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed- kinetic. In either case, without details of your testing we will not be able to proceed.
Further information regarding the verification process can be found at https:/ /wiki.ubuntu. com/QATeam/ PerformingSRUVe rification . Thank you in advance for helping!
N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.