backport-iwlwifi-dkms fails to build in jammy with the latest 5.19 kernel

[Andrea Righi]

[Impact]

/var/lib/dkms/backport-iwlwifi/9858/build/net/wireless/util.c:2287:9: error: implicit declaration of function ‘netif_rx_ni’; did you mean ‘netif_rx’? [-Werror=implicit-function-declaration]
 2287 | netif_rx_ni(skb);
      | ^~~~~~~~~~~
      | netif_rx

[Test case]

1) Install Linux 5.19

2) Install the backport-iwlwifi-dkms package:

 $ sudo apt install backport-iwlwifi-dkms

[Fix]

In recent kernels (>= 5.19) netif_rx() has been refactored so that it can be used in any context, deprecating netif_rx_ni(), so kernels >= 5.19 should use this function instead.

[Regression potential]

We may experience regressions in kernels >= 5.19 that are using backport-iwlwifi-dkms (unlikely because upstream drivers have done the same change), with older kernels the code remains exactly the same.

[Andrea Righi (arighi)]

debdiff in attach allows to support linux 5.19

[Łukasz Zemczak (sil2100)]

Hello Andrea, or anyone else affected,

Accepted backport-iwlwifi-dkms into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/backport-iwlwifi-dkms/9858-0ubuntu3.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Alberto Milone (albertomilone)]

I have tested this against Linux 5.19, and this update solves the DKMS build failure:

$ dkms status
backport-iwlwifi/9858, 5.19.0-30-generic, x86_64: installed

[Launchpad Janitor (janitor)]

This bug was fixed in the package backport-iwlwifi-dkms - 9858-0ubuntu3.2

---------------
backport-iwlwifi-dkms (9858-0ubuntu3.2) jammy; urgency=medium

  * Support kernels >= 5.19 (LP: #2002616):
    - debian/patches/0010-linux-support-5.19.patch

 -- Andrea Righi <email address hidden> Thu, 12 Jan 2023 07:46:57 +0000

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for backport-iwlwifi-dkms has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.