py3.11: unit test failure

[Thomas Goirand]

Hi,

Under Python 3.11, we have the below unit test failure (this is oslo.i18n 5.1.0 in Debian Unstable).

FAIL: oslo_i18n.tests.test_message.MessageTestCase.test_translate_message_bad_translation
oslo_i18n.tests.test_message.MessageTestCase.test_translate_message_bad_translation
----------------------------------------------------------------------
testtools.testresult.real._StringException: Traceback (most recent call last):
  File "/usr/lib/python3.11/unittest/mock.py", line 1369, in patched
    return func(*newargs, **newkeywargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/<<PKGBUILDDIR>>/oslo_i18n/tests/test_message.py", line 389, in test_translate_message_bad_translation
    self.assertEqual(1, len(w))
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 393, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 480, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: 1 != 2

[Jelle van der Waa (jelle-vdwaa)]

Same issue here, the extra deprecationwarning is because of a 3.11 deprecation.

{message : DeprecationWarning('Use setlocale(), getencoding() and getlocale() instead'), category : 'DeprecationWarning', filename : '/tmp/python-oslo-i18n/trunk/src/oslo.i18n/oslo_i18n/_messa
ge.py', lineno : 101, line : None}
{message : UserWarning("Failed to insert replacement values into translated message A message in Spanish: %s %s (Original: 'A message: %s'): not enough arguments for format string"), category
: 'UserWarning', filename : '/tmp/python-oslo-i18n/trunk/src/oslo.i18n/oslo_i18n/_message.py', lineno : 173, line : None}

[Jelle van der Waa (jelle-vdwaa)]

Patch I'd propose http://sprunge.us/LPwTnb

[Takashi Kajinami (kajinamit)]

This was fixed by https://review.opendev.org/c/openstack/oslo.i18n/+/873842 which replaced the deprecated API, though I agree the proposed change makes sense.

Please feel free to submit the change to gerrit (https://docs.openstack.org/contributors/code-and-documentation/index.html) or let me know if you want me to do it.