Dodgy looking patch applied to our build.

Bug #1999698 reported by Bram Stolk
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
accountsservice (Ubuntu)
Fix Released
Undecided
Gunnar Hjalmarsson

Bug Description

When building accountsservice we apply patches, among of which is `0010-set-language.patch` which raises concerns.

It will not compile without warnings: At the very least contains misleading indentation.

```
[92/99] Compiling C object src/accounts-daemon.p/user.c.o
../src/user.c: In function ‘user_HOME_available’:
../src/user.c:1753:27: warning: this ‘else’ clause does not guard... [-Wmisleading-indentation]
 1753 | } else
      | ^~~~
../src/user.c:1755:33: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘else’
 1755 | break;
      | ^~~~~
```

The code:

```
                        } else
                                g_free (path_to_entry);
                                break;

```

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :
Changed in accountsservice (Ubuntu):
assignee: nobody → Gunnar Hjalmarsson (gunnarhj)
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package accountsservice - 22.08.8-1ubuntu4

---------------
accountsservice (22.08.8-1ubuntu4) lunar; urgency=medium

  * debian/patches/0010-set-language.patch:
    - Fix code ambiguity causing compiler warning (LP: #1999698).

 -- Gunnar Hjalmarsson <email address hidden> Wed, 14 Dec 2022 23:36:32 +0100

Changed in accountsservice (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.