Message "send message" page has broken layout due to nested <A> tags

[Robert Lyon]

Currently under certain conditions the previous message display looks broken in the collapsible area part.

This is due to a <a> tag being nested within another <a> tag.

Coding standards say "Nested links are illegal - The a element can be wrapped around entire
paragraphs, lists, tables, and so forth, even entire sections, so long
as there is no interactive content within (e.g., buttons or other links)."

We need to fix this up so that it follows html guidelines and also keeps the info we want

[Robert Lyon (robertl-9)]

To test:

Spin up a php 8.1 docker instance

Send a message to two people and then login as one of them and go to inbox - read message and hit reply all

[Robert Lyon (robertl-9)]

There is also a broken lang string for deleted users

To test this:

1) As admin send a message to two people Person A and Person B
2) Delete Person A
3) Log in as person B and reply to the message - the message shown above the reply form should say
 To: Person B ; 1 deleted account

4) As admin send a message to three people Person C, D, and E
2) Delete Person C and D
3) Log in as person E and reply to the message - the message shown above the reply form should say
 To: Person E ; 2 deleted accounts

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13498
Committed: https://git.mahara.org/mahara/mahara/commit/c7035977109743834f0da6503c523c3175054d1d
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit c7035977109743834f0da6503c523c3175054d1d
Author: Robert Lyon <email address hidden>
Date: Fri Nov 25 12:13:36 2022 +1300

Bug 1997918: Fix issue with nested <A> links

Nested links are illegal - The a element can be wrapped around entire
paragraphs, lists, tables, and so forth, even entire sections, so long
as there is no interactive content within (e.g., buttons or other links).

We now have the 'From' link be part of the list within the
collapsible body

Signed-off-by: Robert Lyon <email address hidden>
Change-Id: Iecdefb95f9471eaa6dd68a6073e91c85b94f39dc
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "22.10_DEV" branch: https://reviews.mahara.org/c/mahara/+/13566

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13566
Committed: https://git.mahara.org/mahara/mahara/commit/ba18b0d3661b20f6469e7e97ae6ffb9af58aed91
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.10_DEV

commit ba18b0d3661b20f6469e7e97ae6ffb9af58aed91
Author: Robert Lyon <email address hidden>
Date: Fri Nov 25 12:13:36 2022 +1300

Bug 1997918: Fix issue with nested <A> links

Nested links are illegal - The a element can be wrapped around entire
paragraphs, lists, tables, and so forth, even entire sections, so long
as there is no interactive content within (e.g., buttons or other links).

We now have the 'From' link be part of the list within the
collapsible body

Signed-off-by: Robert Lyon <email address hidden>
Change-Id: Iecdefb95f9471eaa6dd68a6073e91c85b94f39dc
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c7035977109743834f0da6503c523c3175054d1d)