LDAP not working in correctly in 22.10

Bug #1997906 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
22.10
Fix Released
High
Unassigned
23.04
Fix Released
High
Unassigned

Bug Description

We now get a:

PHP Fatal error: Cannot redeclare group_user_access() (previously declared in /var/www/html/lib/group.php:38) in /var/www/html/lib/group.php on line 38

This is because we are already including the lib/group.php file earlier in the chain of loading things in some instances.

We need to adjust the require() calls to require_once()

Robert Lyon (robertl-9)
Changed in mahara:
status: New → In Progress
importance: Undecided → High
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/13495
Committed: https://git.mahara.org/mahara/mahara/commit/08ce93a266fdd397d6168460410519d714be709b
Submitter: "Gold <email address hidden>"
Branch: main

commit 08ce93a266fdd397d6168460410519d714be709b
Author: Robert Lyon <email address hidden>
Date: Thu Nov 24 13:43:30 2022 +1300

Bug 1997906: Avoid calling Mahara libraries twice

When using LDAP

Change-Id: I452e14882a9f1b4f556d03bba9084438228c317c
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/c/mahara/+/13494
Committed: https://git.mahara.org/mahara/mahara/commit/e1aaa4283f8cd61d0f0589f899f5f6bd471953cb
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.10_DEV

commit e1aaa4283f8cd61d0f0589f899f5f6bd471953cb
Author: Robert Lyon <email address hidden>
Date: Thu Nov 24 13:43:30 2022 +1300

Bug 1997906: Avoid calling Mahara libraries twice

When using LDAP

Change-Id: I452e14882a9f1b4f556d03bba9084438228c317c
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 23.04.0 → none
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
no longer affects: mahara
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.