LTI/LTI_Advantage and webservice check

[Robert Lyon]

Now that we pair up webservice auth instances to the thing that required them it means we can have more than one auth instance where the institution and authmethod are the same.

But in LTI / LTI_Advantage we do a get_field() check that expects only one record to be returned.

We need to adjust this check to make sure at least one record exists.

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13487

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13487
Committed: https://git.mahara.org/mahara/mahara/commit/220b3ae6a6edaf653b8797d078875bc41f7345ad
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 220b3ae6a6edaf653b8797d078875bc41f7345ad
Author: Robert Lyon <email address hidden>
Date: Tue Nov 22 11:26:10 2022 +1300

Bug 1997280: Refining the webservice check

To match the exact row we care about

Change-Id: I1aad492a689f7393bb4ec8e194060f18dc20b2a3
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "22.10_DEV" branch: https://reviews.mahara.org/c/mahara/+/13562

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13562
Committed: https://git.mahara.org/mahara/mahara/commit/0cfa520b6e14cee8a6aef40cdcf1c0e511775545
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.10_DEV

commit 0cfa520b6e14cee8a6aef40cdcf1c0e511775545
Author: Robert Lyon <email address hidden>
Date: Tue Nov 22 11:26:10 2022 +1300

Bug 1997280: Refining the webservice check

To match the exact row we care about

Change-Id: I1aad492a689f7393bb4ec8e194060f18dc20b2a3
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 220b3ae6a6edaf653b8797d078875bc41f7345ad)

[Robert Lyon (robertl-9)]

The change worked but caused a problem if the external_application doesn't have a matching auth_instance row.

So we need an upgrade step to make sure all things are in sync

[Mahara Bot (dev-mahara)]

Patch for "22.10_STABLE" branch: https://reviews.mahara.org/c/mahara/+/13567

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13555
Committed: https://git.mahara.org/mahara/mahara/commit/530fb751929e68f777d47abf9a4ebe6446c30fad
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 530fb751929e68f777d47abf9a4ebe6446c30fad
Author: Robert Lyon <email address hidden>
Date: Fri Dec 16 09:53:29 2022 +1300

Bug 1997280 - checking external app has correct webservice

and adding it if missing

Change-Id: If2d9beb5a6b880d5f36db66d63e27c0b5a7fe69b
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "22.10_DEV" branch: https://reviews.mahara.org/c/mahara/+/13621

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13621
Committed: https://git.mahara.org/mahara/mahara/commit/4f73379623be2f580b7b171c98faae59c04e39fc
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.10_DEV

commit 4f73379623be2f580b7b171c98faae59c04e39fc
Author: Robert Lyon <email address hidden>
Date: Fri Dec 16 09:53:29 2022 +1300

Bug 1997280 - checking external app has correct webservice

and adding it if missing

Change-Id: If2d9beb5a6b880d5f36db66d63e27c0b5a7fe69b
Signed-off-by: Robert Lyon <email address hidden>