Respect the 'do not send stats' when not in production mode

Bug #1996472 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
21.10
Fix Released
High
Unassigned
22.04
Fix Released
High
Unassigned
22.10
Fix Released
High
Unassigned
23.04
Fix Released
High
Unassigned

Bug Description

When you create a site when " $cfg->productionmode = false; " you can't register the site with Mahara.org (which is correct).
And if you change the site to " $cfg->productionmode = true; " you can register with Mahara.org (again this correct).
But if you then set the site back to " $cfg->productionmode = false; " it will continue to send registration data (this is not correct).

We need a check to see what mode the site is in before sending the data and only do it if the site is currently in production mode.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/13464
Committed: https://git.mahara.org/mahara/mahara/commit/9fa2cfd8a60fc8c32c561fd5907a30d367602797
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 9fa2cfd8a60fc8c32c561fd5907a30d367602797
Author: Robert Lyon <email address hidden>
Date: Mon Nov 14 12:54:00 2022 +1300

Bug 1996472: Stop sending registration stats while site is not in prod mode

If we set the site to 'productionmode' = false we should
stop the sending of stats even if the 'registration_sendweeklyupdates'
is true.

This is for sites that were in production more but are set to not be
in production (maybe temporarily or maybe permanently)

Change-Id: I4746edcb3c6ad08f99be6c954dcf70894fdade16
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "22.10_DEV" branch: https://reviews.mahara.org/c/mahara/+/13806

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "22.04_DEV" branch: https://reviews.mahara.org/c/mahara/+/13807

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "21.10_DEV" branch: https://reviews.mahara.org/c/mahara/+/13808

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/13806
Committed: https://git.mahara.org/mahara/mahara/commit/f7639a9ff048735fd60ee6af6058975087a5ebb4
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.10_DEV

commit f7639a9ff048735fd60ee6af6058975087a5ebb4
Author: Robert Lyon <email address hidden>
Date: Mon Nov 14 12:54:00 2022 +1300

Bug 1996472: Stop sending registration stats while site is not in prod mode

If we set the site to 'productionmode' = false we should
stop the sending of stats even if the 'registration_sendweeklyupdates'
is true.

This is for sites that were in production more but are set to not be
in production (maybe temporarily or maybe permanently)

Change-Id: I4746edcb3c6ad08f99be6c954dcf70894fdade16
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 9fa2cfd8a60fc8c32c561fd5907a30d367602797)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/c/mahara/+/13808
Committed: https://git.mahara.org/mahara/mahara/commit/0023731c6d11372c40ee4011c2f4a58bdb72eabc
Submitter: "Robert Lyon <email address hidden>"
Branch: 21.10_DEV

commit 0023731c6d11372c40ee4011c2f4a58bdb72eabc
Author: Robert Lyon <email address hidden>
Date: Mon Nov 14 12:54:00 2022 +1300

Bug 1996472: Stop sending registration stats while site is not in prod mode

If we set the site to 'productionmode' = false we should
stop the sending of stats even if the 'registration_sendweeklyupdates'
is true.

This is for sites that were in production more but are set to not be
in production (maybe temporarily or maybe permanently)

Change-Id: I4746edcb3c6ad08f99be6c954dcf70894fdade16
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 9fa2cfd8a60fc8c32c561fd5907a30d367602797)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/c/mahara/+/13807
Committed: https://git.mahara.org/mahara/mahara/commit/af740948f21e757c691e9f0119032e53e0f49c92
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.04_DEV

commit af740948f21e757c691e9f0119032e53e0f49c92
Author: Robert Lyon <email address hidden>
Date: Mon Nov 14 12:54:00 2022 +1300

Bug 1996472: Stop sending registration stats while site is not in prod mode

If we set the site to 'productionmode' = false we should
stop the sending of stats even if the 'registration_sendweeklyupdates'
is true.

This is for sites that were in production more but are set to not be
in production (maybe temporarily or maybe permanently)

Change-Id: I4746edcb3c6ad08f99be6c954dcf70894fdade16
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 9fa2cfd8a60fc8c32c561fd5907a30d367602797)

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 23.04.0 → none
no longer affects: mahara
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.