nvidia-graphics-drivers-418-server FTBFS with linux 5.19

[Alberto Milone]

[ Impact ]

 * nvidia-graphics-drivers-418-server reached its EOL, however it is the last driver supporting certain GPU families. For this reason, to give users some time to transition to newer GPUs, we would like to move the driver to multiverse for now.

 * The driver should also be patched to be compatible with Kinetic and Jammy's kernels.

[ Test Plan ]

 * Install Linux 5.19:

   - In Jammy:
     sudo apt install linux-image-unsigned-5.19.0-30-generic linux-image-generic-hwe-22.04-edge linux-headers-5.19.0-30-generic

   - In Kinetic:
     sudo apt install linux-generic

* Install the nvidia driver from -proposed:
  sudo apt install nvidia-driver-418-server

* Make sure that the driver builds correctly:
  dkms status

[ Where problems could occur ]

 * In its current state, the driver does not build against Kinetic's kernel,
   hence no regression is possible, in this sense.

 * As for Jammy, the changes introduced by the patch are well contained,
   and only apply when "LINUX_VERSION_CODE >= KERNEL_VERSION(5, 18, 0)".
   When using linux-image-generic-hwe-22.04-edge, this will be the first
   case of the 418 driver working with it.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Andrea Righi (arighi)]

debdiff in attach fixes all the build errors with linux 5.19 on jammy.

[Łukasz Zemczak (sil2100)]

Just so that I have context, since I don't really use this package. I noticed that all the .install files and others change from installing /usr/lib/x86_64-linux-gnu to /usr/lib/aarch64-linux-gnu, which is weird as this package is amd64-ish. Is that expected? What is the rationale for this change here? It's not mentioned in the changelog nor here in the bug?

[Alberto Milone (albertomilone)]

@Łukasz: those are automatically generated when building the sources, and will be generated again (from the files in the debian/templates directory) when building the packages. I generated the sources on an aarch64 system. If you prefer, I can do that again on amd64 system, but it won't really affect anything.

[Łukasz Zemczak (sil2100)]

Oh, ok! Good to know! If those will be regenerated, let's accept as is. The paths looked sane besides the switch from x86 to aarch64.

[Łukasz Zemczak (sil2100)]

Hello Alberto, or anyone else affected,

Accepted nvidia-graphics-drivers-418-server into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nvidia-graphics-drivers-418-server/418.226.00-0ubuntu5~0.22.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Łukasz Zemczak (sil2100)]

Can we get ubuntu5 backported to kinetic as well? Does it make sense? I see the bug targets kinetic as well.

[Alberto Milone (albertomilone)]

Yes, I did upload to kinetic, and it ended up in NEW:

[ubuntu/kinetic-proposed] nvidia-graphics-drivers-418-server 418.226.00-0ubuntu5~0.22.10.1 (New)

[Andrea Righi (arighi)]

Tested in jammy both with stock kernel 5.15 and new kernel 5.19 (I could only test the build via `apt install nvidia-dkms-418-server`, because I don't have the hardware to verify if the driver is working properly).

Result:

- 5.15:

nvidia.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-66-generic/updates/dkms/

nvidia-modeset.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-66-generic/updates/dkms/

nvidia-drm.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-66-generic/updates/dkms/

- 5.19:

nvidia.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.19.0-32-generic/updates/dkms/

nvidia-modeset.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.19.0-32-generic/updates/dkms/

nvidia-drm.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.19.0-32-generic/updates/dkms/

[Launchpad Janitor (janitor)]

This bug was fixed in the package nvidia-graphics-drivers-418-server - 418.226.00-0ubuntu5~0.22.04.1

---------------
nvidia-graphics-drivers-418-server (418.226.00-0ubuntu5~0.22.04.1) jammy; urgency=medium

  [ Andrea Righi ]
  * debian/dkms_nvidia/patches/buildfix_kernel_5.19.patch,
    debian/templates/dkms_nvidia.conf.in: apply buildfix_kernel_5.19.patch:
    - Add support for Linux 5.19 (LP: #1993328).

 -- Alberto Milone <email address hidden> Mon, 23 Jan 2023 11:31:36 +0000

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for nvidia-graphics-drivers-418-server has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Łukasz Zemczak (sil2100)]

Hello Alberto, or anyone else affected,

Accepted nvidia-graphics-drivers-418-server into kinetic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nvidia-graphics-drivers-418-server/418.226.00-0ubuntu5~0.22.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-kinetic to verification-done-kinetic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-kinetic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Steve Langasek (vorlon)]

My recollection is that we were blocking this package in devel-proposed because it failed to build the kernel modules with the release kernel. But according to the change to the bug description, and the released SRU in jammy, it appears the build failure with newer kernels has been fixed. I'm therefore dropping the 'block-proposed' tag to let this package migrate into the mantic release pocket.

If it fails with the 6.2/6.3 kernel there, we should demote it again (but preferably we should open a new bug report so that we don't muddle the description of this one, which was used for the 5.19-fixing SRU).

Note also that the package is missing from the kinetic and lunar release pockets, so users of this driver on jammy will lose their driver support if they do a non-LTS upgrade, unless the SRU for kinetic is completed and an SRU for lunar is uploaded.

[Launchpad Janitor (janitor)]

This bug was fixed in the package nvidia-graphics-drivers-418-server - 418.226.00-0ubuntu5

---------------
nvidia-graphics-drivers-418-server (418.226.00-0ubuntu5) lunar; urgency=medium

  [ Andrea Righi ]
  * debian/dkms_nvidia/patches/buildfix_kernel_5.19.patch,
    debian/templates/dkms_nvidia.conf.in: apply buildfix_kernel_5.19.patch:
    - Add support for Linux 5.19 (LP: #1993328).

 -- Alberto Milone <email address hidden> Mon, 23 Jan 2023 11:31:36 +0000

[Utkarsh Gupta (utkarsh)]

Ubuntu 22.10 (Kinetic Kudu) has reached end of life, so this bug will not be fixed for that specific release.