apport hook that collects snap's information is outdated

[Olivier Tilloy]

Impact
------

The Apport hook of the Chromium browser is outdated. It collects information about core18, but the snap uses core20.

Moreover, it does not collect information about other interface providers.

Test plan
---------

1. Install the current chromium-browser.

2. Generate a report with

  apport-bug --save /tmp/c1 chromium-browser

3. Install chromium-browser from proposed.

4. Generate another report with

  apport-bug --save /tmp/c2 chromium-browser

Note: If the package was built and generated locally, you will need APPORT_DISABLE_DISTRO_CHECK=1 in the environment.

5. Compare the files. The meaningful differences should be in the Snap.Info.xxxx sections, namely:

  - Snap.Info.core18 -> Snap.Info.core20
  - {None} -> Snap.Info.cups
  - {None} -> Snap.Info.gnome-3-38-2004

Differences should not be observed in Snap.Info.{chromium,core,gtk-common-themes}.

Regression potential
--------------------

Being Apport a bug reporting program, an incorrect parsing of the SNAP_META file could lead to insertion of unwanted information in the report or to suppress the insertion of information about the relevant interfaces.

Original report
---------------

See https://bazaar.launchpad.net/~chromium-team/chromium-browser/groovy-stable/view/head:/debian/apport/chromium-browser.py#L59.

It collects information about core18, but the chromium snap was rebased on core20 almost a year ago.

[Nathan Teodosio (nteodosio)]

Those would be the corresponding diffs I suppose, are them to be
sponsored? I suppose a SRU will be needed for Jammy and Focal.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "focal.diff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Simon Quigley (tsimonq2)]

Hi, is this still an issue? If so, could you please fill out the description as an SRU? (Or explain why it should not be.)

Thanks.

[Nathan Teodosio (nteodosio)]

I already prepared the SRU but didn't involve the SRU team yet as the fix is not release in Lunar yet.

[Simon Quigley (tsimonq2)]

Uploaded to Lunar, currently in the SRU queue for Kinetic, Jammy, and Focal. Unsubscribing sponsors.

Thanks for your contributions!

[Launchpad Janitor (janitor)]

This bug was fixed in the package chromium-browser - 1:85.0.4183.83-0ubuntu3

---------------
chromium-browser (1:85.0.4183.83-0ubuntu3) lunar; urgency=medium

  [ Olivier Tilloy ]
  * debian/apport/chromium-browser.py: update the apport hook to collect
    up-to-date information from the chromium snap (LP: #1993191)

 -- Nathan Pratta Teodosio <email address hidden> Mon, 17 Oct 2022 18:53:30 +0200

[Brian Murray (brian-murray)]

Hello Olivier, or anyone else affected,

Accepted chromium-browser into kinetic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/chromium-browser/1:85.0.4183.83-0ubuntu2.22.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-kinetic to verification-done-kinetic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-kinetic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Brian Murray (brian-murray)]

Hello Olivier, or anyone else affected,

Accepted chromium-browser into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/chromium-browser/1:85.0.4183.83-0ubuntu2.22.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Brian Murray (brian-murray)]

Hello Olivier, or anyone else affected,

Accepted chromium-browser into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/chromium-browser/1:85.0.4183.83-0ubuntu0.20.04.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted chromium-browser (1:85.0.4183.83-0ubuntu2.22.10.1) for kinetic have finished running.
The following regressions have been reported in tests triggered by the package:

sabnzbdplus/3.6.1+dfsg-1 (arm64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/kinetic/update_excuses.html#chromium-browser

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Nathan Teodosio (nteodosio)]

In Jammy virtual machine,

Installed chromium-browser, apport-bug --save /tmp/x1 chromium-browser.

Installed chromium-browser from proposed, apport-bug --save /tmp/x2
chromium-browser.

Then compared the files (attached) with vimdiff.

Indeed, the meaningful differences were in the Snap.Info.xxxx sections,
namely:

   - Snap.Info.core18 -> Snap.Info.core20
   - {None} -> Snap.Info.cups
   - {None} -> Snap.Info.gnome-3-38-2004

Differences should not be observed in
Snap.Info.{chromium,core,gtk-common-themes}.

[Nathan Teodosio (nteodosio)]

In Focal virtual machine,

Installed chromium-browser, apport-bug --save x1 chromium-browser.

Installed chromium-browser from proposed, apport-bug --save x2
chromium-browser.

Then compared the files (attached) with vimdiff.

Indeed, the meaningful differences were in the Snap.Info.xxxx sections,
namely:

    - Snap.Info.core18 -> Snap.Info.core20
    - {None} -> Snap.Info.cups
    - {None} -> Snap.Info.gnome-3-38-2004

Differences were not be observed in
Snap.Info.{chromium,core,gtk-common-themes}.

[Nathan Teodosio (nteodosio)]

In Kinetic virtual machine,

Installed chromium-browser, apport-bug --save x1 chromium-browser.

Installed chromium-browser from proposed, apport-bug --save x2
chromium-browser.

Then compared the files (attached) with vimdiff.

Indeed, the meaningful differences were in the Snap.Info.xxxx sections,
namely:

     - Snap.Info.core18 -> Snap.Info.core20
     - {None} -> Snap.Info.cups
     - {None} -> Snap.Info.gnome-3-38-2004

Differences were not be observed in
Snap.Info.{chromium,core,gtk-common-themes}.

[Launchpad Janitor (janitor)]

This bug was fixed in the package chromium-browser - 1:85.0.4183.83-0ubuntu2.22.10.1

---------------
chromium-browser (1:85.0.4183.83-0ubuntu2.22.10.1) kinetic; urgency=medium

  [ Olivier Tilloy ]
  * debian/apport/chromium-browser.py: update the apport hook to collect
    up-to-date information from the chromium snap (LP: #1993191)

 -- Nathan Pratta Teodosio <email address hidden> Mon, 17 Oct 2022 18:53:30 +0200

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for chromium-browser has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package chromium-browser - 1:85.0.4183.83-0ubuntu0.20.04.3

---------------
chromium-browser (1:85.0.4183.83-0ubuntu0.20.04.3) focal; urgency=medium

  [ Olivier Tilloy ]
  * debian/apport/chromium-browser.py: update the apport hook to collect
    up-to-date information from the chromium snap (LP: #1993191)

 -- Nathan Pratta Teodosio <email address hidden> Mon, 17 Oct 2022 18:53:30 +0200

[Launchpad Janitor (janitor)]

This bug was fixed in the package chromium-browser - 1:85.0.4183.83-0ubuntu2.22.04.1

---------------
chromium-browser (1:85.0.4183.83-0ubuntu2.22.04.1) jammy; urgency=medium

  [ Olivier Tilloy ]
  * debian/apport/chromium-browser.py: update the apport hook to collect
    up-to-date information from the chromium snap (LP: #1993191)

 -- Nathan Pratta Teodosio <email address hidden> Mon, 17 Oct 2022 18:53:30 +0200