MNet not saving expiry date correctly on insert of new instance

Bug #1993079 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
22.10
Fix Released
Medium
Unassigned
23.04
Fix Released
Medium
Unassigned

Bug Description

Also not saving on update of MNet instance in some cases.

To test have a moodle to connect to and then in mahara make a MNet connection in an institution by adding an xmlrpc auth method.

On saving the form it should set an expiry for the certificate.

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 22.10.1
status: New → In Progress
importance: Undecided → Medium
Revision history for this message
Robert Lyon (robertl-9) wrote :

To test:

Edit an institution
Add auth method XML-RPC
Set the required config values to:
  Authority name: Moodle
  WWW root: https://webservices-moodle.catalystdemo.co.nz
  Site name: MoodleInstance
And save the form

Then edit the instance again (by clicking on MoodleInstance) and you should see:
  Public key expires with a valid date

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/13224
Committed: https://git.mahara.org/mahara/mahara/commit/9de606003cc79c5405fbb7e085796adc974efb0f
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 9de606003cc79c5405fbb7e085796adc974efb0f
Author: Robert Lyon <email address hidden>
Date: Wed Oct 12 14:08:59 2022 +1300

Bug 1993079: Need to save the xmlrpc expiry date on insert

Also need to save changes on update

Change-Id: I5917769153aaf645ff45e5ea691e327323f2b370
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "22.10_DEV" branch: https://reviews.mahara.org/c/mahara/+/13560

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/13560
Committed: https://git.mahara.org/mahara/mahara/commit/764531eb5a4cd0b0449076fd5ee39cd72c69c592
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.10_DEV

commit 764531eb5a4cd0b0449076fd5ee39cd72c69c592
Author: Robert Lyon <email address hidden>
Date: Wed Oct 12 14:08:59 2022 +1300

Bug 1993079: Need to save the xmlrpc expiry date on insert

Also need to save changes on update

Change-Id: I5917769153aaf645ff45e5ea691e327323f2b370
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 9de606003cc79c5405fbb7e085796adc974efb0f)

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 22.10.1 → none
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
no longer affects: mahara
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.