FTBFS on ppc64el - is not a constant expression

[Olivier Gayot]

On ppc64el, libcamera 0~git20211108+1b30992b623e-4 FTBFS with the following error:

In file included from /usr/include/c++/12/chrono:39,
                 from ../include/libcamera/base/log.h:10,
                 from ../src/ipa/raspberrypi/raspberrypi.cpp:18:
../src/ipa/raspberrypi/raspberrypi.cpp:64:53: in ‘constexpr’ expansion of ‘std::chrono::operator/<long double, std::ratio<1>, double>(std::literals::chrono_literals::operator""s(1.0e+0l), 3.0e+1)’
/usr/include/c++/12/bits/chrono.h:694:39: error: ‘(1.0e+0l / 3.0e+1)’ is not a constant expression
  694 | return __cd(__cd(__d).count() / __s);
      | ~~~~~~~~~~~~~~~~~~^~~~~
../src/ipa/raspberrypi/raspberrypi.cpp:73:56: in ‘constexpr’ expansion of ‘std::chrono::operator/<long double, std::ratio<1>, double>(std::literals::chrono_literals::operator""s(1.0e+0l), 6.0e+1)’
/usr/include/c++/12/bits/chrono.h:694:39: error: ‘(1.0e+0l / 6.0e+1)’ is not a constant expression

[Olivier Gayot (ogayot)]

Adding debdiff adjusting the expressions to make them valid constant expressions on all arches, including ppc64el.

[Olivier Gayot (ogayot)]

Successful PPA build on
ppc64el: https://launchpad.net/~ogayot/+archive/ubuntu/kinetic-proposed/+build/24536512
amd64: https://launchpad.net/~ogayot/+archive/ubuntu/kinetic-proposed/+build/24536511

[Olivier Gayot (ogayot)]

Link to similar bug report where modifying the expression is the recommended approach.

https://bugzilla.redhat.com/show_bug.cgi?id=1538817#c6

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "1-ubuntu1.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Olivier Gayot (ogayot)]

Uploading revised debdiff. Forwarded to Debian and to libcamera upstream.

[Simon Chopin (schopin)]

Uploaded to Kinetic, waiting for release team approval. Thanks :)

[Launchpad Janitor (janitor)]

This bug was fixed in the package libcamera - 0~git20211108+1b30992b623e-5

---------------
libcamera (0~git20211108+1b30992b623e-5) unstable; urgency=medium

  * Team upload.

  [ Olivier Gayot ]
  * Add patch that fixes FTBFS on ppc64el + GCC (Closes: #1021544, LP: #1992331)

 -- Benjamin Drung <email address hidden> Wed, 12 Oct 2022 11:43:40 +0200