[SRU] ladvd FTBFS: error: ‘MAXPATHLEN’ undeclared

[Benjamin Drung]

[ Impact ]

ladvd fails to build in Jammy.

[ Test Plan ]

Confirm that ladvd builds.
Execute ladvd in Jammy to confirm it starts runnning.

But for anyone testing, these are the commands for some basic testing to see ladvd is running.
ladvd -vvvvv -f -a

[ Where problems could occur ]

The patch is backported from Debian which is also an upstream fix.
The fix (apart from the white-space changes) is only adding header file to the source code to fix the ftbfs.
So, it should not change the behaviour and has little chance of regressing the user behaviour.

[ Other Info ]

 The problem exists in 1.1.2-1 and has been fixed by Debian with the version 1.1.2-2.
 It has been updated on Ubuntu Lunar, Mantic and Noble. But Jammy still has the problem and the ftbfs can be seen.

Original Bug Description:

libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../../src -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wformat -Wformat-security -DPIE -D_FORTIFY_SOURCE=2 --param ssp-buffer-size=4 -fstack-protector -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DLIBBSD_OVERLAY -isystem /usr/include/bsd -MT util.lo -MD -MP -MF .deps/util.Tpo -c ../../src/util.c -fPIC -DPIC -o .libs/util.o
In file included from ../../src/common.h:40,
                 from ../../src/util.c:20:
/usr/include/bsd/vis.h:107:2: warning: #warning "NetBSD added incompatible strnvis() and strnunvis(), please see <bsd/vis.h> for more detils." [-Wcpp]
  107 | #warning "NetBSD added incompatible strnvis() and strnunvis(), please see <bsd/vis.h> for more detils."
      | ^~~~~~~
../../src/util.c: In function ‘my_chroot’:
../../src/util.c:151:20: error: ‘MAXPATHLEN’ undeclared (first use in this function)
  151 | char component[MAXPATHLEN];
      | ^~~~~~~~~~
../../src/util.c:151:20: note: each undeclared identifier is reported only once for each function it appears in
../../src/util.c:151:10: warning: unused variable ‘component’ [-Wunused-variable]
  151 | char component[MAXPATHLEN];
      | ^~~~~~~~~
make[3]: *** [Makefile:599: util.lo] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/build/src'

Full log: https://launchpadlibrarian.net/625443175/buildlog_ubuntu-kinetic-amd64.ladvd_1.1.2-1build1_BUILDING.txt.gz

[Sudip Mukherjee (sudipmuk)]

The FTBFS has been fixed in version 1.1.2-2 and so it only affects Jammy.

[Sudip Mukherjee (sudipmuk)]

Attaching debdiff for Jammy.

[Paride Legovini (paride)]

Hello and thanks for preparing the upload. A couple of comments:

* The quilt patch is not excellent. It includes changes that were not part of the upstream commit [1] that fixes the FTBFS. The changes are not harmful but they make the patch "dirty".

* The dep-3 headers are not fully correct. The patch comes from upstream, so we should have "Origin: upstream, <link>", and not Applied-Upstream.

I see that these issue are directly inherit from Debian (1.1.2-2). From one side keeping the patch identical to what we have in the Ubuntu devel release (and Debian) is nice, but I think the SRU team will prefer a clean patch only touching what's necessary.

Now one comment on the d/changelog entry you added for this change. You mention that the patch is a "backport", which makes me think that you somehow adapted the Debian patch, while this is not the case, it is taken as-is. Please consider rewording (perhaps using dep3changelog).

If you agree with these comments, could you please update your debdiff accordingly?

Also please note that the upload will likely be staged [2], as it is low priority.

Thanks!

[1] https://github.com/sspans/ladvd/commit/763358ea4a22795b616410fcba8ca182cb97a08e
[2] https://wiki.ubuntu.com/StableReleaseUpdates#Staging_an_upload

[Sudip Mukherjee (sudipmuk)]

Thanks for looking Paride.

Updated debdiff attached.

[Sergio Durigan Junior (sergiodj)]

Thank you, Sudip.

The changes look fine now. I have prepared the upload with rich history using git-ubuntu, and will now sponsor it.

As Paride mentioned, this upload will be staged and hopefully released when a more urgent SRU is done for this package.

Thanks.

[Timo Aaltonen (tjaalton)]

Hello Benjamin, or anyone else affected,

Accepted ladvd into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ladvd/1.1.2-1ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Sudip Mukherjee (sudipmuk)]

I can confirm that the ladvd package in jammy-proposed has fixed the bug.

Test done:
1. Install ladvd in a jammy installation.
2. Confirm that it works by giving the command mentioned in the test plan
3. enable jammy-proposed in apt sources
4. Update ldvd from jammy-proposed
5. confirmed that the new package version has been installed.
   - which shows its a new package and so the ftbfs bug has been fixed.
6. Executed the same command from the test plan and verified that the output is still same as the previous ladvd version from jammy to check for any regression.

Test result:
1. new version of ladvd was installed from jammy-proposed
2. the command execution output was as expected.

Package tested:
$ dpkg -l | grep ladvd
ii ladvd 1.1.2-1ubuntu1 amd64 LLDP/CDP sender

[Benjamin Drung (bdrung)]

Thanks for verifying.