do-release-upgrade fails when ESM packages are installed
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-advantage-tools (Ubuntu) |
Fix Released
|
Critical
|
Renan Rodrigo | ||
Xenial |
Fix Released
|
Undecided
|
Unassigned | ||
Bionic |
Fix Released
|
Undecided
|
Unassigned | ||
Focal |
Fix Released
|
Undecided
|
Unassigned | ||
Jammy |
Fix Released
|
Undecided
|
Unassigned | ||
Kinetic |
Fix Released
|
Critical
|
Renan Rodrigo |
Bug Description
[Impact]
With u-a-t 27.11, currently on -proposed, upgrading from Xenial to Bionic fails when unattached.
The reason is: Bionic has some updates available in esm-apps, and the repositories are present due to the postinst script seeing that the service is not beta anymore.
However, the preferences file only pins esm for Xenial, and do-release-upgrade:
1. Sees the packages in the Bionic ESM repository
2. Ignores the pinning to 'never'
3. Fails to get those packages - all of them are 401ed
4. Fail to calculate the diffs and exits 1.
Although found and reproducible when upgrading from Xenial to Bionic, this bug may affect any upgrade across releases where the system is unattached, and has any given package installed which is present in the ESM repository of the next release.
[Test Case]
This bug was caught by the ubuntu-
The test case result is pasted as a comment to this bug. I am marking this bug as verified.
[Regression Potential]
If the files related to Apps existed before, this fix would not be enough to fix those - we would need a postinst script to change them. But as those will only be created when ESM-Apps goes GA, the SRU will have it done before that happens.
Related branches
- Andreas Hasenack: Approve
- Canonical Server: Pending requested
-
Diff: 1945 lines (+507/-512)34 files modifieddebian/changelog (+20/-0)
debian/ubuntu-advantage-tools.postinst (+1/-1)
dev/null (+0/-45)
features/api_full_auto_attach.feature (+1/-2)
features/apt_messages.feature (+24/-25)
features/attach_invalidtoken.feature (+1/-1)
features/attached_commands.feature (+0/-24)
features/attached_enable.feature (+98/-55)
features/attached_status.feature (+0/-2)
features/enable_fips_vm.feature (+6/-6)
features/motd_messages.feature (+98/-98)
features/security_status.feature (+78/-99)
features/ubuntu_upgrade.feature (+1/-1)
features/ubuntu_upgrade_unattached.feature (+1/-0)
features/unattached_commands.feature (+15/-3)
features/unattached_status.feature (+36/-52)
uaclient/api/tests/test_u_pro_attach_auto_full_auto_attach_v1.py (+8/-8)
uaclient/apt.py (+2/-5)
uaclient/cli.py (+7/-7)
uaclient/entitlements/esm.py (+4/-3)
uaclient/entitlements/ros.py (+1/-0)
uaclient/entitlements/tests/test_esm.py (+25/-18)
uaclient/jobs/tests/test_update_messaging.py (+1/-1)
uaclient/jobs/update_messaging.py (+28/-1)
uaclient/messages.py (+10/-1)
uaclient/security_status.py (+9/-4)
uaclient/tests/test_apt.py (+1/-1)
uaclient/tests/test_cli.py (+0/-2)
uaclient/tests/test_cli_disable.py (+2/-2)
uaclient/tests/test_cli_enable.py (+2/-2)
uaclient/tests/test_cli_security_status.py (+1/-2)
uaclient/tests/test_cli_status.py (+19/-32)
uaclient/tests/test_status.py (+6/-8)
uaclient/version.py (+1/-1)
Changed in ubuntu-advantage-tools (Ubuntu): | |
assignee: | nobody → Renan Rodrigo (renanrodrigo) |
importance: | Undecided → Critical |
tags: | added: block-proposed |
FYI - PR being discussed in https:/ /github. com/canonical/ ubuntu- advantage- client/ pull/2261