[FFe] Sync Debian pipewire packaging adding new system group

[Jeremy Bícha]

We are requesting to sync https://launchpad.net/debian/+source/pipewire/0.3.58-2 which is a bugfix upstream update including Debian packaging changes to define a new group and give it rtkit permission.

The rtkit usage is similar to what pulseaudio is doing today, also we are currently not adding any user to the new group so it has a limited impact

the debdiff and build logs are available on
https://launchpad.net/~ubuntu-desktop/+archive/ubuntu/ppa/+sourcepub/13987317/+listing-archive-extra

--------------------
extra details from the original report

I am requesting a Feature Freeze Exception to sync Debian's packaging change for pipewire that adds a new 'pipewire' system group with tweaks to system resource limits.

The new 'pipewire' group is not used by default, but it's available for users to opt into if they think they need it.

https://salsa.debian.org/utopia-team/pipewire/-/commit/a8fd8933

https://salsa.debian.org/utopia-team/pipewire/-/commit/8052ea41

https://gitlab.freedesktop.org/pipewire/pipewire/-/wikis/Performance-tuning#rlimits

[Daniel van Vugt (vanvugt)]

Setting rlimits indeed sounds like something PipeWire should do (PulseAudio does too). But the changes being non-trivial and none of us being PipeWire experts, might make this hard to be confident about.

[Dylan Aïssi (daissi)]

The jackd2 package (in main) also proposes similar tweaks to system resource limits for the audio system group.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Utkarsh Gupta (utkarsh)]

Hello,

> Since I'm not familiar with the resource limits, I wanted to get
> confirmation from people who understand the impact of this change
> and whether it's appropriate for Ubuntu 22.10 now.

Just to be clear, are you pursuing for an FFe or still waiting to gather enough information?

I'm setting this to "Incomplete" until the time all the information is gathered and once you want to pursue an FFe here, set it to New/Confirmed again and we'll have a look. TIA. :)

[Dylan Aïssi (daissi)]

If this FFe is not accepted, then could you please apply the attached Debian patch from pipewire 0.3.58-2 [1-2]. It's to prevent a race condition where pipewire-pulse service is ready before wireplumber, leaving users without any devices available thus no sound. That would be a terrible first impression to users.

[1] https://salsa.debian.org/utopia-team/pipewire/-/commit/8e261cecee214b59b156e09b0bfe8a1111471a1b
[2] https://salsa.debian.org/utopia-team/pipewire/-/commits/ubuntu/kinetic

[amano (jyaku)]

Well, it's a new Pipewire feature for those who might need it and it is disabled by default. Thus, no regressions from older Pipewire versions are likely to occur.
We all come from PulseAudio but for those who need the rlimits functionality the transition from PA to Pipewire might be less painful.

[Graham Inggs (ginggs)]

This is looking good Sebastien, thanks for clearing things up.

I just have one question, this version (0.3.58-2) has:

Conflicts: pulseaudio

which was subsequently reverted in Debian:

https://salsa.debian.org/utopia-team/pipewire/-/commit/d626406c0412c2c62c4f3c92ae48622c35f5890a

Do you want the Conflicts or not?

[Sebastien Bacher (seb128)]

Technically I think the conflicts is right but it's a bit late, I will revert to minimize the potential of creating issue for kinetic and will talk to Debian about adding back next cycle, thanks for pointing it out. Should I consider the FFe accepted with that revert?

[Graham Inggs (ginggs)]

Yes, FFe granted, please go ahead!

[Launchpad Janitor (janitor)]

This bug was fixed in the package pipewire - 0.3.58-2ubuntu1

---------------
pipewire (0.3.58-2ubuntu1) kinetic; urgency=medium

  * New bugfix version synced from Debian, including packaging changes
    to create a new pipewire group allowing realtime priority. Users
    don't get added to that group by default. (ffe lp: #1990313)
  * Include the fix to ensure the the service is started after the
    session manager, otherwise no device is listed (lp: #1992101)
  * Revert 'Let pipewire-pulse conflicts on pulseaudio' since it's late
    for that change, we will revisit doing that next cycle

pipewire (0.3.58-2) unstable; urgency=medium

  * Mention to install pipewire-alsa and pipewire-jack
      in README.Debian (Closes: #1019971)
  * Add debian/pipewire-alsa.TODO
  * Patch pipewire-pulse.service to be sure it is started
      after a session manager (Closes: #1019944)
    Because of a bug in the way systemd handles aliases, they have been removed
    in wireplumber and pipewire-media-session services to avoid a conflict.
    This change needs to be reflected in the pipewire-pulse service to be sure
    it is started after a session manager, otherwise pipewire-pulse doesn't
    see any devices.

pipewire (0.3.58-1) unstable; urgency=medium

  [ Dylan Aïssi ]
  * New upstream release
      - Fix crackling sound if pavucontrol is open (Closes: #1019888)
  * Create a pipewire group and define real-time priority limits
      (Closes: #1011399)
  * Add suggestion to install wireplumber in pipewire.README.Debian
  * Clarify relation between pipewire and libspa-0.2-bluetooth in
      pipewire.README.Debian (Closes: #998220, #1011035)
  * Remove reference to experimental status of pipewire for audio

  [ Sebastien Bacher ]
  * Let pipewire-pulse conflicts on pulseaudio
      (Closes: #1013276, LP: #1975823)

 -- Sebastien Bacher <email address hidden> Fri, 07 Oct 2022 16:38:13 +0200