FTBFS with GCC 12

[Sergio Durigan Junior]

squid's "upstream-test-suite" dep8 test is currently FTBFSing with GCC 12 on Kinetic:

libtool: compile: g++ -DHAVE_CONFIG_H -DDEFAULT_CONFIG_FILE=\"/etc/squid.conf\" -DDEFAULT_SQUID_DATA_DIR=\"/usr/share\" -DDEFAULT_SQUID_CONFIG_DIR=\"/etc\" -I../.. -I../../include -I../../lib -I../../src -I../../include -isystem /usr/include/mit-krb5 -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/libxml2 -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Wshadow -Woverloaded-virtual -Werror -pipe -D_REENTRANT -I/usr/include/libxml2 -I/usr/include/p11-kit-1 -g -O2 -ffile-prefix-map=/tmp/autopkgtest.6E1e0D/build.pFL/src=. -flto=auto -ffat-lto-objects -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -march=native -c File.cc -fPIC -DPIC -o .libs/File.o
In file included from ../../src/base/File.h:12,
                 from File.cc:10:
../../src/sbuf/SBuf.h:48:34: error: 'template<class _Category, class _Tp, class _Distance, class _Pointer, class _Reference> struct std::iterator' is deprecated [-Werror=deprecated-declarations]
   48 | class SBufIterator : public std::iterator<std::input_iterator_tag, char>
      | ^~~~~~~~
In file included from /usr/include/c++/12/string:45,
                 from /usr/include/c++/12/stdexcept:39,
                 from ../../src/base/TextException.h:14,
                 from ../../src/sbuf/SBuf.h:15:
/usr/include/c++/12/bits/stl_iterator_base_types.h:127:34: note: declared here
  127 | struct _GLIBCXX17_DEPRECATED iterator
      | ^~~~~~~~
cc1plus: all warnings being treated as errors

[Sergio Durigan Junior (sergiodj)]

https://salsa.debian.org/squid-team/squid/-/commit/c88ab9c5a4239dbf583f31570239a2597680f88c added -Wno-error=deprecated-declarations to d/rules, but didn't replicate the change to d/t/upstream-test-suite.

Either way, we don't need to silence this error anymore because it's been fixed upstream by https://github.com/squid-cache/squid/commit/617ce5838aa6bcb437b3f9ecc8bbfb5c17c44ee2.

[Sergio Durigan Junior (sergiodj)]

Bah, it turns out that we still need to silence the error because the OpenSSL 3 patch we carry still uses std::iterator.

[Sergio Durigan Junior (sergiodj)]

For future reference, the two upstream commits that fix the problem are:

https://github.com/squid-cache/squid/commit/617ce5838aa6bcb437b3f9ecc8bbfb5c17c44ee2

https://github.com/squid-cache/squid/commit/91d65f9cc61c70a709dcc5e0e08ad4d1726b6fe6

[Launchpad Janitor (janitor)]

This bug was fixed in the package squid - 5.6-1ubuntu2

---------------
squid (5.6-1ubuntu2) kinetic; urgency=medium

  * d/t/upstream-test-suite: Also export DEB_*_MAINT_APPEND variables
    here. (LP: #1988217)

 -- Sergio Durigan Junior <email address hidden> Tue, 30 Aug 2022 19:32:59 -0400