Please backport systemd-hwdb patches to support src:systemd-hwe tests
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
systemd (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Jammy |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Impact]
We plan to SRU src:systemd-hwe to Jammy[1] to provide an easier way to SRU HWE hwdb rules to Ubuntu. The src:systemd-hwe package contains a test script[2] to ensure that no redundant hwdb rules are added to the package, i.e. rules that are already present in src:systemd. This test requires patches to implement --root flag support for the `systemd-hwdb query` command[3]. These patches are already present in kinetic.
Without these patches in Jammy, src:systemd-hwe would have to disable these tests, which are important to maintaining HWE hwdb rules in Ubuntu.
[1] https:/
[2] https:/
[3] https:/
[Test plan]
* Create a new directory for testing hwdb rule queries:
$ mkdir -p fakeroot/
* Add a new .hwdb file to override an existing rule. For example, I chose to override the last entry from /lib/udev/
$ tail -2 /lib/udev/
$ sed -i 's/chromebook/
$ cat fakeroot/
evdev:atkbd:
XKB_FIXED_
* Create the hwdb.bin within fakeroot:
$ systemd-hwdb update --root fakeroot
$ ls fakeroot/
fakeroot/
* Finally, attempt to query this new hwdb.bin using systemd-hwdb query. On an unpatched system, we will see results from the system's hwdb.bin:
$ systemd-hwdb query --root fakeroot evdev:atkbd:
XKB_FIXED_
...and on a patched system we should see the overridden rule:
$ systemd-hwdb query --root fakeroot evdev:atkbd:
XKB_FIXED_
[Where problems could occur]
The patches add support for the --root flag when calling systemd-hwdb query, thus changing the behavior of this command (previously, query would always load the system's hwdb.bin). It is unlikely that existing scripts try to use the --root flag with `systemd-hwdb query`, but if they did, this is where we would see problems.
Related branches
- Lukas Märdian: Approve
-
Diff: 438 lines (+359/-2)7 files modifieddebian/changelog (+14/-2)
debian/control (+1/-0)
debian/libsystemd0.symbols (+2/-0)
debian/patches/lp1988078-hwdb-implement-root-option-for-systemd-hwdb-query.patch (+95/-0)
debian/patches/lp1988078-sd-hwdb-add-sd_hwdb_new_from_path.patch (+215/-0)
debian/patches/lp1988078-sd-hwdb-include-sys-stat.h-in-hwdb-internal.h.patch (+29/-0)
debian/patches/series (+3/-0)
Changed in systemd (Ubuntu): | |
status: | New → Fix Released |
Hello Nick, or anyone else affected,
Accepted systemd into jammy-proposed. The package will build now and be available at https:/ /launchpad. net/ubuntu/ +source/ systemd/ 249.11- 0ubuntu3. 5 in a few hours, and then in the -proposed repository.
Please help us by testing this new package. See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification- needed- jammy to verification- done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed- jammy. In either case, without details of your testing we will not be able to proceed.
Further information regarding the verification process can be found at https:/ /wiki.ubuntu. com/QATeam/ PerformingSRUVe rification . Thank you in advance for helping!
N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.