[SRU] Failure to start on 22.04

Bug #1987073 reported by s0600204
32
This bug affects 5 people
Affects Status Importance Assigned to Milestone
linux-show-player (Ubuntu)
Fix Released
Undecided
Unassigned
Jammy
Fix Released
Undecided
Unassigned

Bug Description

[ Impact ]

linux-show-player is completely unusable as it will fail with the below error whenever any user tries to run "linux-show-player":

Traceback (most recent call last):
  File "/usr/bin/linux-show-player", line 3, in <module>
    from lisp.main import main
  File "/usr/lib/python3/dist-packages/lisp/main.py", line 30, in <module>
    from lisp import modules
  File "/usr/lib/python3/dist-packages/lisp/modules/__init__.py", line 23, in <module>
    from lisp.ui import elogging
  File "/usr/lib/python3/dist-packages/lisp/ui/elogging.py", line 28, in <module>
    from lisp.ui.widgets import QDetailedMessageBox
  File "/usr/lib/python3/dist-packages/lisp/ui/widgets/__init__.py", line 1, in <module>
    from .cueaction_combobox import CueActionComboBox
  File "/usr/lib/python3/dist-packages/lisp/ui/widgets/cueaction_combobox.py", line 25, in <module>
    from lisp.cues.cue import Cue, CueAction
  File "/usr/lib/python3/dist-packages/lisp/cues/cue.py", line 25, in <module>
    from lisp.core.fade_functions import FadeInType, FadeOutType
  File "/usr/lib/python3/dist-packages/lisp/core/fade_functions.py", line 32, in <module>
    from lisp.core.util import FunctionProxy
  File "/usr/lib/python3/dist-packages/lisp/core/util.py", line 22, in <module>
    from collections import Mapping

As mentioned in the original bug report, this has been caused by Python3.10.

[ Test Plan ]

* Execute "linux-show-player"
* if its not fixed then it will fail as the error above
* With fixed package the "linux-show-player" window will be displayed.

[ Where problems could occur ]

This is an upstream patch which only changes the code to import the correct module and use integer-float properly. The only major change in the code is to call QRectF() instead of QRect() but QRectF() is basically same as QRect() with floating point precision. So, imho, there should not be any regression. Also, currently its completely unusable, there can not be a bigger regression than that.

[ Other Info ]

It has been fixed in upstream release 0.5.3 and so Mantic and Noble are not affected.

[ Original Bug Description ]

[Impact]

 * It is currently not possible to run the repository-provided version (0.5.2) of `linux-show-player` upon Ubuntu 22.04. This is caused by Ubuntu 22.04 using python 3.10, which contains some changes that breaks `linux-show-player`.

 * Linux Mint 21 has relatively recently (2022-07-31) been released, which (re)uses the Ubuntu 22.04 repositories, and as such suffers from the same issue.

 * Pop! OS 22.04 also (re)uses the Ubuntu 22.04 repositories, and as such suffers from the same issue.

 * Upstream bug reports (and backtraces) can be found at:

   - https://github.com/FrancescoCeruti/linux-show-player/issues/238
   - https://github.com/FrancescoCeruti/linux-show-player/issues/245
   - https://github.com/FrancescoCeruti/linux-show-player/issues/250
   - https://github.com/FrancescoCeruti/linux-show-player/issues/261
   - https://github.com/FrancescoCeruti/linux-show-player/issues/296
   - On the project's chat/discussion stream: https://gitter.im/linux-show-player/linux-show-player?at=62e657e97ccf6b6d459fc8b8

 * There exists a newer release of `linux-show-player` (0.5.3) which contains within it a fix for this issue (corrected imports and better differentiation of integer/float values).

 * Users have reported that the newer release works for them, when they install it manually.

 * The newer release is currently packaged and available in the repositories of the fledgling Ubuntu 22.10 release-to-be. (As well as the repositories of Debian 12 and Unstable.)

[Test Plan]

 * Install package from repository;

 * Attempt to run the program from the Launcher;

 * Note that it does not start, or rather: it does but crashes;

 * Attempt to run the program via a terminal [emulator]: `$ linux-show-player`;

 * Note the errors (or lack thereof with the newer release);

[Where problems could occur]

 * There are other changes contained in the gap between 0.5.2 and 0.5.3 beyond the fix for Python 3.10. That said, the other changes can be summarised as being mostly documentation and CI improvements, along with a branding update and a new translation. A full changeset may be found here: https://github.com/FrancescoCeruti/linux-show-player/compare/v0.5.2...v0.5.3

 * The changes required to get `linux-show-player` to work on python 3.10 are compatible with earlier versions of python 3.x, so there shouldn't be a problem if a user prefers to use an earlier version of python. (The project doesn't support python 2.x, and as such is not expected to run under that.)

[Other info]

 * Note that I myself do not use Ubuntu or a Ubuntu-derived distro: I am a contributor to the linux-show-player project who is filing this on behalf of our users who use Ubuntu 22.04 and Linux Mint 21. I am hoping that this is a simple case of backporting the package from 22.10 to 22.04, but lack the resources to test this.

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in linux-show-player (Ubuntu):
status: New → Confirmed
s0600204 (s0600204)
description: updated
s0600204 (s0600204)
description: updated
Revision history for this message
Sudip Mukherjee (sudipmuk) wrote :

This can be reproduced on Jammy. I have also tested and confirmed that Focal, Mantic or Noble are not affected.

Changed in linux-show-player (Ubuntu):
status: Confirmed → Fix Released
Changed in linux-show-player (Ubuntu Jammy):
status: New → In Progress
assignee: nobody → Sudip Mukherjee (sudipmuk)
Revision history for this message
Sudip Mukherjee (sudipmuk) wrote :

Debdiff attached for Jammy.

summary: - Failure to start on 22.04
+ [SRU] Failure to start on 22.04
description: updated
Changed in linux-show-player (Ubuntu Jammy):
status: In Progress → Confirmed
assignee: Sudip Mukherjee (sudipmuk) → nobody
Simon Quigley (tsimonq2)
Changed in linux-show-player (Ubuntu Jammy):
status: Confirmed → In Progress
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello s0600204, or anyone else affected,

Accepted linux-show-player into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/linux-show-player/0.5.2-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in linux-show-player (Ubuntu Jammy):
status: In Progress → Fix Committed
Revision history for this message
Sudip Mukherjee (sudipmuk) wrote :

I can confirm that the linux-show-player package in jammy-proposed has fixed the bug for me.

Test done:
Installed linux-show-player from jammy-proposed.
Executed linux-show-player.
The linux-show-player window was displayed.

Test result: the errors with linux-show-player has been fixed.

Package tested:

$ apt-cache policy linux-show-player
linux-show-player:
  Installed: 0.5.2-1ubuntu0.1
  Candidate: 0.5.2-1ubuntu0.1
  Version table:
 *** 0.5.2-1ubuntu0.1 500
        500 http://gb.archive.ubuntu.com/ubuntu jammy-proposed/universe amd64 Packages
        500 http://gb.archive.ubuntu.com/ubuntu jammy-proposed/universe i386 Packages
        100 /var/lib/dpkg/status
     0.5.2-1 500
        500 http://gb.archive.ubuntu.com/ubuntu jammy/universe amd64 Packages
        500 http://gb.archive.ubuntu.com/ubuntu jammy/universe i386 Packages

tags: added: verification-done verification-done-jammy
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-show-player - 0.5.2-1ubuntu0.1

---------------
linux-show-player (0.5.2-1ubuntu0.1) jammy; urgency=medium

  * Apply upstream patch to support python3.10. (LP: #1987073)
    - Fix: ImportError: cannot import name 'Mapping' from 'collections'
    - Fix: type 'float' but 'int' is expected

 -- Sudip Mukherjee <email address hidden> Sun, 28 Jan 2024 12:59:06 +0000

Changed in linux-show-player (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for linux-show-player has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.