MNet failing to set parent auth correctly when creating account via MNet

[Robert Lyon]

MNet has the ability to set a parent authentication instance so that when an account is created that is the value saved as 'authinstance' instead.

However, there is a bug in the code where 'internal' gets saved every time.

This is very old bug which has caused much head-scratching over the years.

To test
1 Have a Mahara site that one can MNet into from something like a Moodle site
2 Have the MNet instance set up to have a parent auth that is not internal, say SAML
3 Have a person that doesn't have a mahara account log in via MNet jump link

Expected
new account created with their 'authinstance' being SAML option

Actual
new account created with their 'authinstance' being internal option

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13075

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13075
Committed: https://git.mahara.org/mahara/mahara/commit/38c8c5d04f06dafd1e0466a81ffc51aef66d5e64
Submitter: "Gold <email address hidden>"
Branch: main

commit 38c8c5d04f06dafd1e0466a81ffc51aef66d5e64
Author: Robert Lyon <email address hidden>
Date: Fri Aug 19 16:37:37 2022 +1200

Bug 1987027: Correctly save MNet parent auth on account creation

Change-Id: I666a76e14ba84a4a1c036aff448c480039203ddb
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "22.04_DEV" branch: https://reviews.mahara.org/c/mahara/+/13150

[Mahara Bot (dev-mahara)]

Patch for "21.10_DEV" branch: https://reviews.mahara.org/c/mahara/+/13151

[Mahara Bot (dev-mahara)]

Patch for "21.04_DEV" branch: https://reviews.mahara.org/c/mahara/+/13152

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13151
Committed: https://git.mahara.org/mahara/mahara/commit/5a2ec9c305243bc2cd4eb8bc2e788779cf5277a9
Submitter: "Robert Lyon <email address hidden>"
Branch: 21.10_DEV

commit 5a2ec9c305243bc2cd4eb8bc2e788779cf5277a9
Author: Robert Lyon <email address hidden>
Date: Fri Aug 19 16:37:37 2022 +1200

Bug 1987027: Correctly save MNet parent auth on account creation

Change-Id: I666a76e14ba84a4a1c036aff448c480039203ddb
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 38c8c5d04f06dafd1e0466a81ffc51aef66d5e64)

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13152
Committed: https://git.mahara.org/mahara/mahara/commit/54c2cd609d1db145e5317f14447a1b75c97b2adb
Submitter: "Robert Lyon <email address hidden>"
Branch: 21.04_DEV

commit 54c2cd609d1db145e5317f14447a1b75c97b2adb
Author: Robert Lyon <email address hidden>
Date: Fri Aug 19 16:37:37 2022 +1200

Bug 1987027: Correctly save MNet parent auth on account creation

Change-Id: I666a76e14ba84a4a1c036aff448c480039203ddb
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 38c8c5d04f06dafd1e0466a81ffc51aef66d5e64)

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13150
Committed: https://git.mahara.org/mahara/mahara/commit/739bff8a0a9c67867d0d513cdbfb270c60f2ce1b
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.04_DEV

commit 739bff8a0a9c67867d0d513cdbfb270c60f2ce1b
Author: Robert Lyon <email address hidden>
Date: Fri Aug 19 16:37:37 2022 +1200

Bug 1987027: Correctly save MNet parent auth on account creation

Change-Id: I666a76e14ba84a4a1c036aff448c480039203ddb
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 38c8c5d04f06dafd1e0466a81ffc51aef66d5e64)