Multiple vulnerabilities in Bionic, Focal, Jammy and Kinetic

Bug #1982670 reported by Luís Infante da Câmara
258
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Jupyter Notebook
Unknown
Critical
jupyter-notebook (Debian)
Fix Released
Unknown
jupyter-notebook (Ubuntu)
Fix Released
Undecided
Nishit Majithia

Bug Description

The versions in Bionic, Focal, Jammy and Kinetic may be vulnerable to CVE-2018-19351, CVE-2019-9644, CVE-2019-10255, CVE-2019-10856, CVE-2018-21030, CVE-2020-26215, CVE-2021-32798, CVE-2022-24758 and CVE-2022-29238.

Please release patched packages.

Tags: patch
information type: Public → Public Security
Changed in jupyter-notebook (Ubuntu):
status: New → In Progress
assignee: nobody → Luís Cunha dos Reis Infante da Câmara (luis220413)
Revision history for this message
Luís Infante da Câmara (luis220413) wrote (last edit ):

In Ubuntu 18.04 (bionic), jupyter-notebook has a large test suite (with 252 tests that run on both Python 2 and Python 3) that runs at build time and fails the build if it fails.

Revision history for this message
Luís Infante da Câmara (luis220413) wrote :

This patch does not fix CVE-2021-32798.

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "jupyter-notebook_bionic.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Revision history for this message
Luís Infante da Câmara (luis220413) wrote :

A patched package for Focal is in my PPA, but the tests interrupt very quickly, causing the build to fail: https://launchpad.net/~luis220413/+archive/ubuntu/security-updates/+packages

Is an upgrade to 6.4.12 acceptable for a security update for Jammy, given that the package has an extensive testsuite?

Revision history for this message
Luís Infante da Câmara (luis220413) wrote :

Today I reported to the upstream project that CVE-2019-10856 is unfixed in the 6.x series.

Changed in jupyter-notebook:
importance: Unknown → Critical
Revision history for this message
Luís Infante da Câmara (luis220413) wrote :

I will file a Debian bug tomorrow.

summary: - Multiple vulnerabilities in Bionic, Focal and Jammy
+ Multiple vulnerabilities in Bionic, Focal, Jammy and Kinetic
description: updated
Revision history for this message
Luís Infante da Câmara (luis220413) wrote :
Revision history for this message
Luís Infante da Câmara (luis220413) wrote :

The package builds successfully with this patch.

Revision history for this message
Luís Infante da Câmara (luis220413) wrote :

The Debian bug was filed by another person on July 21.

Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

In response to comment #4, no, bumping the version isn't acceptable as a security update. Please backport the minimum fixes required to solve the security issues. Thanks!

Revision history for this message
Luís Infante da Câmara (luis220413) wrote :
Revision history for this message
Luís Infante da Câmara (luis220413) wrote (last edit ):

CVE-2019-10856 is unfixed in Kinetic and is pending on a new upstream release including the fix or a security fix by the Debian maintainer. I have filed a bug in the upstream project for this CVE, linked in this bug.

Revision history for this message
Luís Infante da Câmara (luis220413) wrote :

Patched source and binary packages are available in my PPA (https://launchpad.net/~luis220413/+archive/ubuntu/security-updates).

Changed in jupyter-notebook (Ubuntu):
status: In Progress → Fix Committed
status: Fix Committed → In Progress
Changed in jupyter-notebook (Ubuntu):
status: In Progress → Fix Committed
assignee: Luís Cunha dos Reis Infante da Câmara (luis220413) → nobody
Revision history for this message
Eduardo Barretto (ebarretto) wrote :

Hi Luis,

could you please provide test results, test plan and instructions?

Changed in jupyter-notebook (Ubuntu):
status: Fix Committed → Incomplete
Changed in jupyter-notebook (Debian):
status: Unknown → Confirmed
Revision history for this message
Luís Infante da Câmara (luis220413) wrote :

An extensive test suite is run during the build on Ubuntu 18.04, 20.04 and 22.04, and fails the build if it fails. All tests pass or are skipped in these Ubuntu versions.

Changed in jupyter-notebook (Ubuntu):
status: Incomplete → Fix Committed
Revision history for this message
Luís Infante da Câmara (luis220413) wrote :

If anyone wants to test this package, please use a version of libjs-moment patched for CVE-2022-24785, that can be obtained from my PPA (https://launchpad.net/~luis220413/+archive/ubuntu/security-updates) and that I expect to be uploaded to the Ubuntu archive soon.

Revision history for this message
Luís Infante da Câmara (luis220413) wrote (last edit ):

Please release the package for Jammy after releasing those in bug #1982617.

Revision history for this message
Luís Infante da Câmara (luis220413) wrote (last edit ):

Note that CVE-2021-32798 is still unpatched in Bionic and Focal. Can we discuss it in the #ubuntu-motu channel in Libera.Chat?

Revision history for this message
Luís Infante da Câmara (luis220413) wrote (last edit ):

Please release the packages for Ubuntu Bionic and Focal, even though CVE-2021-32798 is unfixed for those releases.

Revision history for this message
Luís Infante da Câmara (luis220413) wrote :

This is a partial log, but that contains full test results, of running autopkgtest locally with an Ubuntu 22.04 amd64 schroot for the sagemath source package with updated packages from my PPA (https://launchpad.net/~luis220413/+archive/ubuntu/security-updates).

Revision history for this message
Luís Infante da Câmara (luis220413) wrote :

The same run for the metakernel source package fails. It is possible that this is not a regression. I am attaching all result files from this run.

Revision history for this message
Luís Infante da Câmara (luis220413) wrote :
Revision history for this message
Luís Infante da Câmara (luis220413) wrote :
Revision history for this message
Luís Infante da Câmara (luis220413) wrote :
Revision history for this message
Luís Infante da Câmara (luis220413) wrote :
Revision history for this message
Luís Infante da Câmara (luis220413) wrote :
Revision history for this message
Luís Infante da Câmara (luis220413) wrote :
Revision history for this message
Luís Infante da Câmara (luis220413) wrote :
Revision history for this message
Luís Infante da Câmara (luis220413) wrote :
Revision history for this message
Luís Infante da Câmara (luis220413) wrote :

I have rerun the autopkgtest for the sagemath source package in Ubuntu 22.04. I will attach its logs now.

Revision history for this message
Luís Infante da Câmara (luis220413) wrote :
Revision history for this message
Luís Infante da Câmara (luis220413) wrote :
Revision history for this message
Luís Infante da Câmara (luis220413) wrote :
Revision history for this message
Luís Infante da Câmara (luis220413) wrote :
Revision history for this message
Luís Infante da Câmara (luis220413) wrote :
Revision history for this message
Luís Infante da Câmara (luis220413) wrote :
Revision history for this message
Luís Infante da Câmara (luis220413) wrote :
Revision history for this message
Nishit Majithia (0xnishit) wrote :

Hi Luis, I will be checking debdiffs and start working on this sponsoring
Thanks

Changed in jupyter-notebook (Ubuntu):
assignee: nobody → Nishit Majithia (0xnishit)
Revision history for this message
Nishit Majithia (0xnishit) wrote :

> Please release the packages for Ubuntu Bionic and Focal, even though CVE-2021-32798 is unfixed
> for those releases.

Hi Luis,

Since CVE-2021-32798 is unfixed in focal and bionic, can you please upload the new debdiffs for these two releases without mentioning this CVE in the changelog, since we don't usually mention anything in the changelog which is **not fixed**

Thanks

Revision history for this message
Luís Infante da Câmara (luis220413) wrote :
Revision history for this message
Luís Infante da Câmara (luis220413) wrote :
Revision history for this message
Luís Infante da Câmara (luis220413) wrote :

Could the USN for this update mention that CVE-2021-32798 is unfixed, given its severity?

Revision history for this message
Eduardo Barretto (ebarretto) wrote :

USNs only mention fixed CVEs, if CVE-2021-32798 is not mentioned there, you consider it unfixed.
Mentioning it would be more confusing than helpful.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package jupyter-notebook - 6.4.8-1ubuntu0.1

---------------
jupyter-notebook (6.4.8-1ubuntu0.1) jammy-security; urgency=medium

  * SECURITY UPDATE: Crafted link to login page redirects to malicious site
    (LP: #1982670)
    - debian/patches/CVE-2019-10856.patch: Handle empty netloc being
      interpreted as first path part being the netloc by buggy browsers.
    - CVE-2019-10856
  * SECURITY UPDATE: Sensitive information disclosure leading to unauthorized
    access (LP: #1982670)
    - debian/patches/CVE-2022-24758.patch: Log only a non-sensitive subset of
      the headers when a HTTP 5xx error other than HTTP 502 is triggered.
    - CVE-2022-24758
  * SECURITY UPDATE: Access to hidden files or to files in hidden directories
    (LP: #1982670)
    - debian/patches/CVE-2022-29238-1.patch: Add checks for hidden file or path on
      file get.
    - debian/patches/CVE-2022-29238-2.patch: added hidden checks on
      FileContentsManager and accompanying tests.
    - debian/patches/CVE-2022-29238-3.patch: Added hidden checks on
      notebook/services/contents/handlers.py and accompanying tests.
    - debian/patches/CVE-2022-29238-4.patch: Update log message to mention
      hidden directories.
    - debian/patches/CVE-2022-29238-5.patch: Update error messages to not
      mention hidden files.
    - CVE-2022-29238
  * debian/source/lintian-overrides: Update to fix Lintian warnings.

 -- Luís Infante da Câmara <email address hidden> Fri, 29 Jul 2022 21:35:10 +0100

Changed in jupyter-notebook (Ubuntu):
status: Fix Committed → Fix Released
Changed in jupyter-notebook (Debian):
status: Confirmed → Fix Released
To post a comment you must log in.