r8125-dkms fails to build on kinetic with latest kernel 5.19

[Andrea Righi]

[Impact]

r8125-dkms fails to build on 5.19 kernel with the following error:

/var/lib/dkms/r8125/9.009.01/build/r8125_n.c: In function ‘rtl8125_init_board’:
/var/lib/dkms/r8125/9.009.01/build/r8125_n.c:11955:14: error: implicit declaration of function ‘pci_set_dma_mask’ [-Werror=implicit-function-declaration]
11955 | !pci_set_dma_mask(pdev, DMA_BIT_MASK(64)) &&
      | ^~~~~~~~~~~~~~~~
/var/lib/dkms/r8125/9.009.01/build/r8125_n.c:11956:14: error: implicit declaration of function ‘pci_set_consistent_dma_mask’ [-Werror=implicit-function-declaration]
11956 | !pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64))) {
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/var/lib/dkms/r8125/9.009.01/build/r8125_n.c: In function ‘rtl8125_init_one’:
/var/lib/dkms/r8125/9.009.01/build/r8125_n.c:12718:17: error: implicit declaration of function ‘netif_set_gso_max_size’; did you mean ‘netif_set_tso_max_size’? [-Werror=implicit-function-declaration]
12718 | netif_set_gso_max_size(dev, LSO_64K);
      | ^~~~~~~~~~~~~~~~~~~~~~
      | netif_set_tso_max_size

[Test case]

$ sudo apt install r8125-dkms

[Fix]

Provide the proper ABI to support kernels >= 5.18.

[Regression potential]

We may see regressions with this drivers on kernels >= 5.18.

[Andrea Righi (arighi)]

Fix (debdiff) in attach allows to build this module on a kernel >= 5.18.

[Launchpad Janitor (janitor)]

This bug was fixed in the package r8125 - 9.009.01-1ubuntu1

---------------
r8125 (9.009.01-1ubuntu1) kinetic; urgency=medium

  * Support linux >= 5.18 (LP: #1981993):
    - debian/patches/0001-support-linux-5.18.patch

 -- Andrea Righi <email address hidden> Mon, 18 Jul 2022 13:53:38 +0000

[Andrea Righi (arighi)]

debdiff in attach allows to support linux hwe 5.19 in jammy.

[Łukasz Zemczak (sil2100)]

Hello Andrea, or anyone else affected,

Accepted r8125 into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/r8125/9.007.01-3ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Kleber Sacilotto de Souza (kleber-souza)]

Performed only build tests due to lack of hardware for better testing.

Build test with hwe-5.19 kernel:

=========================================================
Setting up r8125-dkms (9.007.01-3ubuntu0.1) ...
Loading new r8125-9.007.01 DKMS files...
Building for 5.19.0-32-generic
Building initial module for 5.19.0-32-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.
=========================================================

Build test with generic 5.15 kernel:

=========================================================
Setting up r8125-dkms (9.007.01-3ubuntu0.1) ...
Loading new r8125-9.007.01 DKMS files...
Building for 5.15.0-60-generic 5.19.0-32-generic
Building initial module for 5.15.0-60-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.
=========================================================

[Launchpad Janitor (janitor)]

This bug was fixed in the package r8125 - 9.007.01-3ubuntu0.1

---------------
r8125 (9.007.01-3ubuntu0.1) jammy; urgency=medium

  * Support linux >= 5.18 (LP: #1981993):
    - debian/patches/0001-support-linux-5.19.patch

 -- Andrea Righi <email address hidden> Wed, 18 Jan 2023 08:04:11 +0000

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for r8125 has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.