Storage Pools: Add support for minor NFS versions

[Alan Baghumian]

Currently, libvirt only supports unsigned integers for protocol versions, when it comes to NFS-backed storage pools (1).

We need to expand this support so minor versions such as 4.1 and 4.2 are also supported. The purpose of this is to benefit from version constraint features such as pNFS which are only available with NFS 4.1 (2).

There is currently a patch available which I believe can be ported to Ubuntu packages (3).

Thank you.

(1) https://libvirt.org/formatstorage.html
(2) https://listman.redhat.com/archives/libvirt-users/2022-June/013615.html
(3) https://listman.redhat.com/archives/libvir-list/2022-June/232541.html

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Christian Ehrhardt  (paelzer)]

That has not yet concluded upstream.
It got a bit constructive and not much negative feedback, but currently is stuck here.
last entry:
https://listman.redhat.com/archives/libvir-list/2022-June/232579.html

I hope that it might still make it into 8.6 which we hope to pick up for the coming Ubuntu release.
If not, but accepted and committed later we can still apply it.

Only once it is then available in Kinetic (22.10) can we start considering SRU which is:
- easy because it is rather small and self contained
- hard because it isn't really a fix, it is anew feature
So let us postpone SRU considerations until later.

[Christian Ehrhardt  (paelzer)]

I mentioned/linked it from the merge bug 1971289 to later have a look how this resolved upstream.

[Christian Ehrhardt  (paelzer)]

FYI - landed in 8.6.0

commit c44930d932203b4a58dccbbeaa814fff6cea8216
Author: Peter Krempa <email address hidden>
Date: Thu Jun 23 17:17:06 2022 +0200

    storage: pool: Allow more intricate nfs protocol versions

$ git tag --contains c44930d932203b4a58dccbbeaa814fff6cea8216
v8.6.0

[Launchpad Janitor (janitor)]

This bug was fixed in the package libvirt - 8.6.0-0ubuntu1

---------------
libvirt (8.6.0-0ubuntu1) kinetic; urgency=medium

  * Merge 8.0.0 from Debian unstable (LP: #1971289)
    Among many other fixes and improvements this fixes:
    - support for minor NFS versions (LP: #1980134)
    - launching VMs with SGX enabled (LP: #1982896)
    Remaining changes:
    - libvirt-uri.sh, d/rules: Automatically switch default libvirt URI
      for users via user profile (xen URI on dom0, qemu:///system otherwise)
    - Disable libssh2 support (universe dependency)
    - d/control: add libzfslinux-dev to build-deps
    - d/control: drop libvirt-lxc, vbox and xen drivers to suggest
    - debian/patches/ubuntu/ovmf_paths.patch: adjust paths to secboot.fd UEFI
      Secure Boot enabled variants of the OVMF firmware and variable store for
      the paths where we ship these files in Ubuntu.
    - Set qemu-group to kvm (for compat with older ubuntu)
    - Additional apport package-hook
    - Autostart default bridged network (As upstream does, but not Debian).
      In addition to just enabling it our solution provides:
      + do not autostart if subnet is already taken (e.g. in guests).
      + iterate some alternative subnets before giving up
    - d/p/ubuntu/Allow-libvirt-group-to-access-the-socket.patch: This is
      the group based access to libvirt functions as it was used in Ubuntu
      for quite a long time.
      + d/p/ubuntu/daemon-augeas-fix-expected.patch fix some related tests
        due to the group access change.
      + d/libvirt-daemon-system.postinst: add users in sudo to the libvirt
        group.
    - Update README.Debian with Ubuntu changes
    - d/p/ubuntu/ubuntu_machine_type.patch: accept ubuntu types as pci440fx
    - fix autopkgtests (LP 1899180)
      + d/t/control, d/t/smoke-qemu-session: fixup smoke-qemu-session by making
        vmlinuz available and accessible (Debian bug 848314)
      + d/t/control: fix smoke-qemu-session by ensuring the service will run
        installing libvirt-daemon-system
      + d/t/smoke-lxc: fix smoke-lxc by ignoring potential issues on destroy as
        long as the following undefine succeeds
      + d/t/smoke-lxc: use systemd instead of sysV to restart the service
      + d/t/control, d/t/smoke-lxc: retry service restart and skip test if
        failing; This was flaky on some release/architectures
      + d/t/smoke-lxc: retry check_domain being flaky on arm64
    - dnsmasq related enhancements
      + run dnsmasq as libvirt-dnsmasq (LP: 1743718)
      + d/libvirt-daemon-system.postinst: add libvirt-dnsmasq user and group
      + d/libvirt-daemon-system.postrm: remove libvirt-dnsmasq user and group
        on purge
      + d/p/ubuntu/dnsmasq-as-priv-user: write dnsmasq config with user
        libvirt-dnsmasq and adapt the self tests to expect that config
      + d/libvirt-daemon-system.postinst: fix old libvirt-dnsmasq users group
      + Add dnsmasq configuration to work with system wide dnsmasq-base
    - d/p/ubuntu/set-default-machine-to-ubuntu.patch: to select default
      machine type correctly with newer qemu/libvirt
    - d/p/ubuntu/lp-1861125-ubuntu-models: recognize Ubuntu models fo...