The 'show more' pagination needs to be a bit more flexible
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Wishlist
|
Robert Lyon |
Bug Description
Currently when fetching new data with the 'show more' button it will replace the content parent HTML element of the button with the new content.
This worked fine when the parent element was a <div> tag but fails if the parent HTML element of the button is something like a <TD> we end up replacing content of table rows into the table cell rather than replacing the table row.
Need an adjustment on the 'show more' pagination where we can specify the closest HTML tag to do the replace content step on.
To test:
As this change is just to make the 'show more' pagination more robust the testing will be making sure current places work correctly still.
So easiest test is to go to 'Pages and collection' page and have enough pages to cause the 'Show more' button to appear, say 14 page, and then clicking it appends more data to the page.
Changed in mahara: | |
milestone: | none → 22.10.0 |
importance: | Undecided → Wishlist |
status: | New → In Progress |
Changed in mahara: | |
assignee: | nobody → Gold (gold.catalyst) |
Changed in mahara: | |
assignee: | Gold (gold.catalyst) → Robert Lyon (robertl-9) |
Changed in mahara: | |
status: | In Progress → Fix Committed |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
Patch for "main" branch: https:/ /reviews. mahara. org/c/mahara/ +/12944