[SRU] Stable point releases for python-os-brick

[Corey Bryant]

[Impact]
This release sports mostly bug-fixes and we would like to make sure all of our users have access to these improvements.

While python-os-brick is not covered under the OpenStack stable release exception I would like to see if these would be covered by the Ubuntu SRU "New upstream microrelease" exception.

The update contains the following package updates:

   * python-os-brick 5.0.2 (Xena/Impish)
   * python-os-brick 4.3.3 (Wallaby)
   * python-os-brick 4.0.5 (Victoria)
   * python-os-brick 3.0.8 (Ussuri/Focal)

[Test Case]
The following SRU process was followed:
https://wiki.ubuntu.com/OpenStack/StableReleaseUpdates

In order to avoid regression of existing consumers, the OpenStack team will run their continuous integration test against the packages that are in -proposed. A successful run of all available tests will be required before the proposed packages can be let into -updates.

The OpenStack team will be in charge of attaching the output summary of the executed tests. The OpenStack team members will not mark ‘verification-done’ until this has happened.

[Regression Potential]
In order to mitigate the regression potential, the results of the aforementioned tests are attached to this bug.

[Discussion]
Thew new versions of os-brick are defined by opentack's upper-constraints which are the versions that get tested by the upstream gate: https://github.com/openstack/requirements/blob/master/upper-constraints.txt

Following are the delta of fixes between the current versions in Ubuntu/UCA and the new versions that we would like to pick up:

# Xena (Impish)
/tmp/os-brick$ git-pretty 5.0.1..5.0.2
 - [19a4820] Use file locks in connectors
 - [4d11648] multipath/iscsi: iSCSI connections are not reinitiated after reboot

# Wallaby
/tmp/os-brick$ git-pretty 4.3.1..4.3.3
 - [d09dc9e] linuxscsi: Only raise and log multipathd errors when required
 - [ecaf7f8] Use file locks in connectors
 - [779d1e4] multipath/iscsi: iSCSI connections are not reinitiated after reboot
 - [0c7f5fc] NVMe-oF: Flush on disconnect
 - [0cd58a9] multipath/iscsi: remove devices from multipath monitoring
 - [d0884a8] Drop lower-constraints job

# Victoria
/tmp/os-brick$ git-pretty 4.0.1..4.0.5
 - [ffe0cbf] linuxscsi: Only raise and log multipathd errors when required
 - [b03eca8] Use file locks in connectors
 - [7c7650b] multipath/iscsi: iSCSI connections are not reinitiated after reboot
 - [a0e995b] multipath/iscsi: remove devices from multipath monitoring
 - [9f73446] Drop lower-constraints job
 - [9528cea] iSCSI: Fix flushing after multipath cfg change
 - [57c8f43] Avoid unhandled exceptions during connecting to iSCSI portals
 - [3adcb40] FC: Fix not flushing on detach
 - [9317f9f] ScaleIO: More connection info backward compatibility
 - [2bf4dcc] opencas: Use BrickException instead of Exception
 - [958e4f5] Improve error handling on target query
 - [1ffde6b] Adjust requirements and lower-constraints

# Ussuri (Focal)
/tmp/os-brick$ git-pretty 3.0.1..3.0.8
 - [9d3ce01] Use file locks in connectors
 - [d0eea8a] multipath/iscsi: iSCSI connections are not reinitiated after reboot
 - [c336cb7] Avoid unhandled exceptions during connecting to iSCSI portals
 - [5c031cb] multipath/iscsi: remove devices from multipath monitoring
 - [579e464] Drop lower-constraints job
 - [4894b24] iSCSI: Fix flushing after multipath cfg change
 - [fba9810] ScaleIO: More connection info backward compatibility
 - [1e7ad8b] FC: Fix not flushing on detach
 - [897dbdb] Improve error handling on target query
 - [f815146] Add oslo.context dependency
 - [9a8726a] Adjust lower-constraints
 - [91c73a4] New fix for rbd connector to work with ceph octopus
 - [d3ee7a0] rbd: Warn if ceph udev rules are not configured
 - [31c01b5] Leverage the iSCSI mpath to get the WWN
 - [a04e553] iSCSI detect multipath DM with no WWN
 - [930ce7f] Add release note for scaleio connector upgrade
 - [31589a6] ScaleIO: Connection info backward compatibility
 - [935daea] Improve WWN detection
 - [9491b6a] prepend platform info to by-path string
 - [bf0faea] rbd: Support 'rbd showmapped' output from ceph 13.2.0+
 - [a1c9f64] Remove VxFlex OS credentials from connection_properties
 - [55cfc97] rbd: Correct local_attach disconnect test and showmapped arguments
 - [dfd835e] Fix hacking min version to 3.0.1
 - [396fe1a] Update TOX/UPPER_CONSTRAINTS_FILE for stable/ussuri
 - [0cc24c0] Update .gitreview for stable/ussuri

[Discussion]
It is important to note that upstream has:

1) a reliable and credible test suite for assuring the quality of every commit or release,
2) the tests are covering both functionality and API/ABI stability

The upstream policy for testing is described a bit here: https://docs.openstack.org/cinder/latest/contributor/contributing.html#getting-your-patch-merged
(specifically see the paragraphs starting with "Patches lacking unit tests are unlikely to be approved." and "If your patch has a -1 from Zuul.."). Pep8, unit, and functional (tempest) tests are run during the gate for each patch. For example, looking at the following upstream review: https://review.opendev.org/c/openstack/os-brick/+/822025 we can see that zuul tests must vote +1 in order for the patch to be merged. It is also important to note the upstream openstack stable branch policy noted at https://docs.openstack.org/project-team-guide/stable-branches.html#review-guidelines.

It is also import to note that the ubuntu package has:

1) unit tests run during package build to cover all architectures

Additionally, the OpenStack team will run their continuous integration test against the packages that are in -proposed (a juju deployed openstack with tempest functional tests executed to validate the cloud). A successful run of all available tests will be required before the proposed packages can be let into -updates.

[Corey Bryant (corey.bryant)]

I've uploaded these new versions of python-os-brick to the focal and impish unapproved queues, as well as to victoria-staging and wallaby-staging.

[Corey Bryant (corey.bryant)]

Hello Corey, or anyone else affected,

Accepted python-os-brick into wallaby-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:wallaby-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-wallaby-needed to verification-wallaby-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-wallaby-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Brian Murray (brian-murray)]

python-os-brick seems like a package which could follow the microrelease process but a couple of criteria for that process are not specifically called out in the bug description. Does upstream have the following?

1) a reliable and credible test suite for assuring the quality of every commit or release,
2) the tests are covering both functionality and API/ABI stability
3) the tests run during package build to cover all architectures

For reference I'm looking at https://wiki.ubuntu.com/StableReleaseUpdates#New_upstream_microreleases which also states "The upstream QA process must be documented/demonstrated and linked from the SRU tracking bug."

[Corey Bryant (corey.bryant)]

Brian, Thanks for taking a look. I've added details on the upstream/ubuntu testing in the [Discussion] section of the Bug Description above.

[Brian Murray (brian-murray)]

Hello Corey, or anyone else affected,

Accepted python-os-brick into impish-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python-os-brick/5.0.2-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-impish to verification-done-impish. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-impish. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Brian Murray (brian-murray)]

Hello Corey, or anyone else affected,

Accepted python-os-brick into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python-os-brick/3.0.8-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Corey Bryant (corey.bryant)]

Hello Corey, or anyone else affected,

Accepted python-os-brick into xena-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:xena-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-xena-needed to verification-xena-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-xena-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Corey Bryant (corey.bryant)]

Hello Corey, or anyone else affected,

Accepted python-os-brick into victoria-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:victoria-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-victoria-needed to verification-victoria-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-victoria-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Corey Bryant (corey.bryant)]

Hello Corey, or anyone else affected,

Accepted python-os-brick into ussuri-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:ussuri-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-ussuri-needed to verification-ussuri-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-ussuri-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Corey Bryant (corey.bryant)]

Verified successfully on xena-proposed:

====== Totals
======
Ran: 182 tests in 1720.7669 sec.
 - Passed: 167
 - Skipped: 12
 - Expected Fail: 0
 - Unexpected Success: 0
 - Failed: 3
Sum of execute time for each test: 572.7215 sec.

Note: The 3 failures are unrelated and known policy issues with manila and octavia.

[Brian Murray (brian-murray)]

Ubuntu 21.10 (Impish Indri) has reached end of life, so this bug will not be fixed for that specific release.

[Corey Bryant (corey.bryant)]

Verified successfully on wallaby-proposed:

======
Totals
======
Ran: 182 tests in 2307.6826 sec.
 - Passed: 166
 - Skipped: 12
 - Expected Fail: 0
 - Unexpected Success: 0
 - Failed: 4
Sum of execute time for each test: 1241.3604 sec.

Note: The failures are unrelated and known policy issues with manila and octavia.

[Corey Bryant (corey.bryant)]

Verified successfully on victoria-proposed:

======
Totals
======
Ran: 106 tests in 1706.9799 sec.
 - Passed: 89
 - Skipped: 16
 - Expected Fail: 0
 - Unexpected Success: 0
 - Failed: 1
Sum of execute time for each test: 559.3312 sec.

Note: The failure is unrelated and a known policy issues with octavia.

[Corey Bryant (corey.bryant)]

Verified successfully on focal-proposed:

======
Totals
======
Ran: 106 tests in 1321.9390 sec.
 - Passed: 89
 - Skipped: 16
 - Expected Fail: 0
 - Unexpected Success: 0
 - Failed: 1
Sum of execute time for each test: 452.3710 sec.

Note: The failure is unrelated and a known policy issues with octavia.

[Corey Bryant (corey.bryant)]

Verified successfully on ussuri-proposed:

======
Totals
======
Ran: 101 tests in 1560.7742 sec.
 - Passed: 89
 - Skipped: 11
 - Expected Fail: 0
 - Unexpected Success: 0
 - Failed: 1
Sum of execute time for each test: 644.2611 sec.

Note: The failure is unrelated and a known policy issues with octavia.

[Corey Bryant (corey.bryant)]

The verification of the Stable Release Update for python-os-brick has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Corey Bryant (corey.bryant)]

This bug was fixed in the package python-os-brick - 5.0.2-0ubuntu1~cloud0
---------------

 python-os-brick (5.0.2-0ubuntu1~cloud0) focal-xena; urgency=medium
 .
   * New upstream release for the Ubuntu Cloud Archive.
 .
 python-os-brick (5.0.2-0ubuntu1) impish; urgency=medium
 .
   * d/gbp.conf: Create stable/xena branch.
   * New stable point release for OpenStack Xena (LP: #1978465).

[Corey Bryant (corey.bryant)]

The verification of the Stable Release Update for python-os-brick has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Corey Bryant (corey.bryant)]

This bug was fixed in the package python-os-brick - 4.3.3-0ubuntu1~cloud0
---------------

 python-os-brick (4.3.3-0ubuntu1~cloud0) focal-wallaby; urgency=medium
 .
   * d/gbp.conf: Create stable/wallaby branch.
   * New stable point release for OpenStack Wallaby (LP: #1978465).

[Corey Bryant (corey.bryant)]

The verification of the Stable Release Update for python-os-brick has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Corey Bryant (corey.bryant)]

This bug was fixed in the package python-os-brick - 4.0.5-0ubuntu1~cloud0
---------------

 python-os-brick (4.0.5-0ubuntu1~cloud0) focal-victoria; urgency=medium
 .
   * New stable point release for OpenStack Victoria (LP: #1978465).
   * d/control: Align (Build-)Depends with upstream.
   * d/p/lp1915678-avoid-unhandled-exceptions-during-connecting-to-iscsi-portals.patch:
     Dropped. Fixd in new stable point release.

[Launchpad Janitor (janitor)]

This bug was fixed in the package python-os-brick - 3.0.8-0ubuntu1

---------------
python-os-brick (3.0.8-0ubuntu1) focal; urgency=medium

  * New stable point release for OpenStack Ussuri (LP: #1978465).
  * d/control: Align (Build-)Depends with upstream.
  * d/p/lp1915678-avoid-unhandled-exceptions-during-connecting-to-iscsi-portals.patch,
    d/p/lp1865754-fix-rbd-connector-for-octopus.patch,
    d/CVE-2020-10755.patch: Dropped. Fixed in new stable point release.

 -- Corey Bryant <email address hidden> Tue, 14 Jun 2022 13:59:53 -0400

[Corey Bryant (corey.bryant)]

The verification of the Stable Release Update for python-os-brick has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Corey Bryant (corey.bryant)]

This bug was fixed in the package python-os-brick - 3.0.8-0ubuntu1~cloud0
---------------

 python-os-brick (3.0.8-0ubuntu1~cloud0) bionic-ussuri; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 python-os-brick (3.0.8-0ubuntu1) focal; urgency=medium
 .
   * New stable point release for OpenStack Ussuri (LP: #1978465).
   * d/control: Align (Build-)Depends with upstream.
   * d/p/lp1915678-avoid-unhandled-exceptions-during-connecting-to-iscsi-portals.patch,
     d/p/lp1865754-fix-rbd-connector-for-octopus.patch,
     d/CVE-2020-10755.patch: Dropped. Fixed in new stable point release.