Extension does odd things when other extension is disabled

Bug #1978330 reported by Sergio Costas
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-shell-extension-desktop-icons-ng (Ubuntu)
Fix Released
High
Sergio Costas
Jammy
Fix Released
High
Sergio Costas

Bug Description

Impact
------
When an extension that was enabled before DING is disabled, the desktop with the icons stops behaving like a desktop, and instead they behave like a transparent window that can be over other windows, be moved by pressing the "Windows" key, and so on.

Test Case
---------
1. When logged in, run these 2 commands:
gsettings reset org.gnome.shell enabled-extensions
gsettings reset org.gnome.shell disabled-extensions
2. Install the update
3. Install the Extension Manager app
sudo apt install gnome-shell-extension-manager
4. Log out then log in.
5. Open the Extension Manager app.
6. Disable the Ubuntu AppIndicators extension.

What should happen: the desktop should display normally. There shouldn't be an extra "gjs" app in the Ubuntu Dock on the left side of the screen.

7. Run the commands from #1 again to get your system back to the default configuration.

What Could Go Wrong
--------------------
The fix is to keep the extension from launching twice when an extension enabled before it is disabled.

The Desktop Icons NG GNOME Shell extension is enabled by default on Ubuntu 22.04 LTS so a bug here could make desktops unusable.

Other Info
----------
The Ubuntu AppIndicators extension is listed before the DING extension in /usr/share/gnome-shell/modes/ubuntu.json which is why this test case works for reproducing the bug.

https://gitlab.com/rastersoft/desktop-icons-ng/-/merge_requests/338

Revision history for this message
Sergio Costas (rastersoft-gmail) wrote :
Revision history for this message
Daniel van Vugt (vanvugt) wrote :
tags: added: fixed-in-46 fixed-upstream
Changed in gnome-shell-extension-desktop-icons-ng (Ubuntu):
status: New → Fix Released
Jeremy Bícha (jbicha)
Changed in gnome-shell-extension-desktop-icons-ng (Ubuntu Jammy):
assignee: nobody → Sergio Costas (rastersoft-gmail)
status: New → Triaged
Jeremy Bícha (jbicha)
description: updated
Changed in gnome-shell-extension-desktop-icons-ng (Ubuntu Jammy):
importance: Undecided → High
Changed in gnome-shell-extension-desktop-icons-ng (Ubuntu):
importance: Undecided → High
Jeremy Bícha (jbicha)
description: updated
Jeremy Bícha (jbicha)
Changed in gnome-shell-extension-desktop-icons-ng (Ubuntu Jammy):
status: Triaged → In Progress
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Sergio, or anyone else affected,

Accepted gnome-shell-extension-desktop-icons-ng into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell-extension-desktop-icons-ng/43-2ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in gnome-shell-extension-desktop-icons-ng (Ubuntu Jammy):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-jammy
Revision history for this message
Andy Chi (andch) wrote :

Install gnome-shell-extension-desktop-icons-ng (43-2ubuntu1) on my XPS 9310, followed the steps in the description. Every thing works well

tags: added: verification-done verification-done-jammy
removed: verification-needed verification-needed-jammy
Revision history for this message
Jeremy Bícha (jbicha) wrote :

I have also successfully completed the test case for this bug with gnome-shell-extension-desktop-icons-ng/43-2ubuntu1

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-shell-extension-desktop-icons-ng - 43-2ubuntu1

---------------
gnome-shell-extension-desktop-icons-ng (43-2ubuntu1) jammy; urgency=medium

  [ Sergio Costas]
  * Ensure that the extension isn't loaded twice, fixing problems when other
    extensions are disabled (LP: #1978330)
  * Keep the application even if there are no connected monitors,
    fixing excessive journal error logging & CPU usage (LP: #1978331)
  * Fix hang when using 2 monitors with different zoom settings (LP: #1976204)

 -- Jeremy Bicha <email address hidden> Tue, 28 Jun 2022 08:57:13 -0400

Changed in gnome-shell-extension-desktop-icons-ng (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for gnome-shell-extension-desktop-icons-ng has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.