PHP 8 Compatibility: skin

Bug #1976428 reported by Gold
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Gold

Bug Description

This is to track patchsets that will bring the codebase up to be compliant with PHP 8.1.

The initial run through will be on a top level directory basis. i.e. the directories below htdocs. It will focus on the results from the PHPStan and Phan static analysis tools.

This bug tracks files in the skin directory.

Testing will require identifying, from the patchset, where the code is used and then verifying that that area of the site still works in both PHP 7.4 and PHP 8.1.

https://phpstan.org/
https://github.com/phan/phan

Gold (gold.catalyst)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/12941
Committed: https://git.mahara.org/mahara/mahara/commit/e937381816ac2c6f462e38b7c24b0d20d5f06267
Submitter: "Doris Tam <email address hidden>"
Branch: main

commit e937381816ac2c6f462e38b7c24b0d20d5f06267
Author: Gold <email address hidden>
Date: Wed Jun 22 10:58:58 2022 +1200

Bug 1976428: PHP 8 Compatibility: skin

Signed-off-by: Gold <email address hidden>
Change-Id: Ief98ed875d39b959dfa8a1583fca19fbe4e90903

Doris Tam (doristam)
Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
importance: High → Wishlist
tags: added: newfeature
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.