PHP 8 Compatibility: lib

[Gold]

This is to track patchsets that will bring the codebase up to be compliant with PHP 8.1.

The initial run through will be on a top level directory basis. i.e. the directories below htdocs. It will focus on the results from the PHPStan and Phan static analysis tools.

This bug tracks files in the lib directory.

Testing will require identifying, from the patchset, where the code is used and then verifying that that area of the site still works in both PHP 7.4 and PHP 8.1.

https://phpstan.org/
https://github.com/phan/phan

[Gold (gold.catalyst)]

This section is difficult.

The way Mahara has managed 3rd party libraries has resulted in some classes that extend other classes that don't exist. This should resolve itself in time as we update how we manage these libraries. For now though, I'm moving on to other parts of the code base.

[Gold (gold.catalyst)]

...and another one where the bug number was added to the commit after the initial push.

https://reviews.mahara.org/c/mahara/+/12921

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12921
Committed: https://git.mahara.org/mahara/mahara/commit/166e6e5c15e978796d9009b63797708364d140ef
Submitter: "Doris Tam <email address hidden>"
Branch: main

commit 166e6e5c15e978796d9009b63797708364d140ef
Author: Gold <email address hidden>
Date: Mon Jun 20 15:27:29 2022 +1200

Bug 1976423: PHP 8 Compatibility: lib

Signed-off-by: Gold <email address hidden>
Change-Id: Iab18c09cd0967011c33c34f2aa2c7e0acc6b45cc