PHP 8 Compatibility: api

[Gold]

This is to track patchsets that will bring the codebase up to be compliant with PHP 8.1.

The initial run through will be on a top level directory basis. i.e. the directories below htdocs. It will focus on the results from the PHPStan and Phan static analysis tools.

This bug tracks files in the api directory.

Testing will require identifying, from the patchset, where the code is used and then verifying that that area of the site still works in both PHP 7.4 and PHP 8.1.

https://phpstan.org/
https://github.com/phan/phan

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/12832

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12832
Committed: https://git.mahara.org/mahara/mahara/commit/b619397b913dbf25702aca3c462c37d30d8bbc07
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit b619397b913dbf25702aca3c462c37d30d8bbc07
Author: Gold <email address hidden>
Date: Wed Jun 1 14:37:44 2022 +1200

Bug 1976416: PHP 8 Compatibility: api

ssl_*() functions:

https://www.php.net/manual/en/function.openssl-seal.php
https://www.php.net/manual/en/function.openssl-open.php

cipher_algo (param 5) is no longer an optional parameter. The default is RC4
but is considered insecure.

Someone that knows more about what is going on here should chip in. Can we
just switch out the cipher_algo to something more reliable or does this
interact with outside sources that also need to be updated?

Change-Id: I7aa784d3bcf4fba110ab75f082ee74c6ae95eca5