patron registration form sends unnecessary data when saving

[Galen Charlton]

When the AngularJS patron registration form saves a record, the request to update the patron record includes some virtual fields that not needed:

- notes (which nowadays is coming from user messages)
- user activity
- standing penalties

These are coming from the fleshing set by the AngularJS patron service when it retrieves a patron record. They're retrieved for various purposes, but those purposes do not include any relevant to the patron editor

When the patron record is saved via open-ils.actor.patron.update, those fleshed columns are ignored.

Ordinarily this wouldn't be anything more than a minor waste of bandwidth, but patrons can sometimes have hundreds of notes if A/T events are generating patron messages. That can add up to an overlarge request.

Evergreen 3.8+

[Mike Rylander (mrylander)]

Here's a branch that removes those fields when saving the user data: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp-1976126-remove-needless-fleshing

[Galen Charlton (gmc)]

Tested and signed off, branch is user/gmcharlt/lp1976126-signoff

The signoff branch includes a follow-up patch to update the API documentation for open-ils.actor.patron.update, as a future developer could reasonably assume that that method could be extended to cover standing penalty and notes updates.

[Terran McCanna (tmccanna)]

Note: good idea to backport as far back as feasible as well.

[Galen Charlton (gmc)]

Pushed down to rel_3_9.