systemd: fix test-execute autotest failure with kernel 5.15 in focal

Bug #1975587 reported by Andrea Righi
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
systemd (Ubuntu)
Fix Released
Undecided
Unassigned
Focal
Fix Released
Medium
Unassigned

Bug Description

[Impact]

test-execute autotest is failing in focal with kernel 5.15. This is because the following kernel commit changed the ABI for ioprio:

e70344c05995 ("block: fix default IO priority handling")

Previously setting IOPRIO_CLASS_NONE for a process would report IOPRIO_CLASS_NONE back. But starting with 5.15 it reports IOPRIO_CLASS_BE instead.

[Test case]

Run systemd autopkgtest and check for the test-execute result.

[Fix]

Change test/test-execute/exec-ioschedulingclass-none.service to recognize both "none" and "best-effort" as valid returned strings from ionice.

This change is already available in jammy and above.

[Regression potential]

We may see regressions in systemd autopkgtest, we won't introduce any potential regressions in systemd itself, because this is only affecting the specific unit test.

Related branches

Revision history for this message
Andrea Righi (arighi) wrote (last edit ):

This seems to fix the test failure.

tags: added: patch
Changed in systemd (Ubuntu):
status: New → Fix Released
Changed in systemd (Ubuntu Focal):
status: New → In Progress
Changed in systemd (Ubuntu Focal):
importance: Undecided → Medium
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Used systemd packaging repo's ./debian/git-cherry-pick and gbp dch + gbp tag to convert the cherry-pick request into a typical looking systemd sru backport.

Submitted merge proposal to https://code.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/+git/systemd/+merge/429491

will ask for review and/or will upload it to proposed shortly.

Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello Andrea, or anyone else affected,

Accepted systemd into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/systemd/245.4-4ubuntu3.19 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in systemd (Ubuntu Focal):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-focal
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (systemd/245.4-4ubuntu3.19)

All autopkgtests for the newly accepted systemd (245.4-4ubuntu3.19) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

linux-aws-5.13/5.13.0-1031.35~20.04.1 (amd64)
munin/2.0.56-1ubuntu1 (arm64)
linux-gcp-5.8/5.8.0-1039.41 (amd64)
gvfs/1.44.1-1ubuntu1.1 (amd64)
linux-gcp-5.11/5.11.0-1030.34~20.04.3 (amd64)
linux-hwe-5.15/5.15.0-52.58~20.04.1 (amd64)
linux-oem-5.13/5.13.0-1029.36 (amd64)
systemd/245.4-4ubuntu3.19 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#systemd

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Dimitri John Ledkov (xnox) wrote (last edit ):

all autopkgtests now pass https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#systemd

now testing if the new testcase is fixed with v5.15 kernels in focal.

Test request submitted.

Result history
https://autopkgtest.ubuntu.com/packages/systemd/focal/amd64
arch
amd64
package
systemd
release
focal
requester
xnox
triggers
['linux-meta-hwe-5.15/5.15.0.53.59~20.04.21', 'linux-hwe-5.15/5.15.0-53.59~20.04.1', 'linux-signed-hwe-5.15/5.15.0-53.59~20.04.1', 'systemd/245.4-4ubuntu3.19']

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

In the triggered logs

PASS: test-execute

is present with new kernel and new systemd

-env=ADT_TEST_TRIGGERS=linux-meta-hwe-5.15/5.15.0.53.59~20.04.21 linux-hwe-5.15/5.15.0-53.59~20.04.1 linux-signed-hwe-5.15/5.15.0-53.59~20.04.1 systemd/245.4-4ubuntu3.19'

https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/amd64/s/systemd/20221118_144307_c3504@/log.gz

there are other failures, i.e. seccomp, which will need to be address separately.

tags: added: verification-done verification-done-focal
removed: verification-needed verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package systemd - 245.4-4ubuntu3.19

---------------
systemd (245.4-4ubuntu3.19) focal; urgency=medium

  [ dann frazier ]
  * Add support for the v247 network naming scheme, but keep v245 as default
    (LP: #1945225)
    Author: dann frazier
    Files:
    - debian/patches/lp1945225/0001-udev-net_id-parse-_SUN-ACPI-index-as-a-signed-intege.patch
    - debian/patches/lp1945225/0002-udev-net_id-don-t-generate-slot-based-names-if-multi.patch
    - debian/patches/lp1945225/0003-net_id-fix-newly-added-naming-scheme-name.patch
    - debian/patches/lp1945225/0004-Add-remaining-supported-schemes-as-options-for-defau.patch
    - debian/rules
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=f569231b5134a8e4901621ee5b2c33826184dae6

  [ Dimitri John Ledkov ]
  * test: fix test-execute autotest failure with kernel 5.15 (LP: #1975587)
    File: debian/patches/test-make-test-execute-pass-on-Linux-5.15.patch
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=7b3140ab5916269c020978ce678f06869a769f5c

 -- Dimitri John Ledkov <email address hidden> Thu, 08 Sep 2022 10:58:15 +0100

Changed in systemd (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for systemd has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.