OVN port loses its virtual type after port update

Bug #1973276 reported by Gregory Thiemonge
32
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Ubuntu Cloud Archive
Fix Released
Undecided
Unassigned
Ussuri
Fix Released
High
Unassigned
Victoria
Fix Released
High
Unassigned
Wallaby
Fix Released
Undecided
Unassigned
Xena
Fix Released
Undecided
Unassigned
Yoga
Fix Released
Undecided
Unassigned
Zed
Fix Released
Undecided
Unassigned
neutron
Fix Released
Medium
Rodolfo Alonso
neutron (Ubuntu)
Fix Released
Undecided
Unassigned
Focal
Fix Released
High
Unassigned

Bug Description

Bug found in Octavia (master)

Octavia creates at least 2 ports for each load balancer:
- the VIP port, it is down, it keeps/stores the IP address of the LB
- the VRRP port, plugged into a VM, it has the VIP address in the allowed-address list (and the VIP address is configured on the interface in the VM)

When sending an ARP request for the VIP address, the VRRP port should reply with its mac-address.

In OVN the VIP port is marked as "type: virtual".

But when the VIP port is updated, it loses its "port: virtual" status and that breaks the ARP resolution (OVN replies to the ARP request by sending the mac-address of the VIP port - which is not used/down).

Quick reproducer that simulates the Octavia behavior:

===========================

import subprocess
import time

import openstack

conn = openstack.connect(cloud="devstack-admin-demo")

network = conn.network.find_network("public")

sg = conn.network.find_security_group('sg')
if not sg:
    sg = conn.network.create_security_group(name='sg')

vip_port = conn.network.create_port(
    name="lb-vip",
    network_id=network.id,
    device_id="lb-1",
    device_owner="me",
    is_admin_state_up=False)

vip_address = [
    fixed_ip['ip_address']
    for fixed_ip in vip_port.fixed_ips
    if '.' in fixed_ip['ip_address']][0]

vrrp_port = conn.network.create_port(
    name="lb-vrrp",
    device_id="vrrp",
    device_owner="vm",
    network_id=network.id)
vrrp_port = conn.network.update_port(
    vrrp_port,
    allowed_address_pairs=[
        {"ip_address": vip_address,
         "mac_address": vrrp_port.mac_address}])

time.sleep(1)

output = subprocess.check_output(
    f"sudo ovn-nbctl show | grep -A2 'port {vip_port.id}'",
    shell=True)
output = output.decode('utf-8')

if 'type: virtual' in output:
    print("Port is virtual, this is ok.")
print(output)

conn.network.update_port(
    vip_port,
    security_group_ids=[sg.id])

time.sleep(1)

output = subprocess.check_output(
    f"sudo ovn-nbctl show | grep -A2 'port {vip_port.id}'",
    shell=True)
output = output.decode('utf-8')

if 'type: virtual' not in output:
    print("Port is not virtual, this is an issue.")
print(output)

===========================

In my env (devstack master on c9s):
$ python3 /mnt/host/virtual_port_issue.py
Port is virtual, this is ok.
    port e0fe2894-e306-42d9-8c5e-6e77b77659e2 (aka lb-vip)
        type: virtual
        addresses: ["fa:16:3e:93:00:8f 172.24.4.111 2001:db8::178"]

Port is not virtual, this is an issue.
    port e0fe2894-e306-42d9-8c5e-6e77b77659e2 (aka lb-vip)
        addresses: ["fa:16:3e:93:00:8f 172.24.4.111 2001:db8::178"]
    port 8ec36278-82b1-436b-bc5e-ea03ef22192f

In Octavia, the "port: virtual" is _sometimes_ back after other updates of the ports, but in some cases the LB is unreachable.

(and "ovn-nbctl lsp-set-type <vip-port-id> virtual" fixes the LB)

=== Ubuntu SRU Details ===

[Impact]
This bug causes loadbalancer vip ports to lose their "virtual" type in ovn and results in broken connectivity to amphora vms after failover. There are two patches, one that fixes new ports and one that retroactively fixes existing ones. We are backporting the former since it is clean and simple but the latter does not apply cleanly so we will defer.

[Test Case]
  * deploy openstack ussuri or victoria with neutron + ovn and octavia
  * create a loadbalancer
  * check ovn-nbctl for the vip port and check that type is virtual
  * failover the loadbalancer
  * check ovn-nbctl for the vip port and check that type is still virtual and that lb vip is reachable

[Where things could go wrong]
There are not anticipated to be any regressions from this backport.

Changed in neutron:
importance: Undecided → High
status: New → Confirmed
Changed in neutron:
status: Confirmed → New
Revision history for this message
Rodolfo Alonso (rodolfo-alonso-hernandez) wrote :

Hello Gregory:

I can't reproduce this behaviour in master branch. Reproducer: https://paste.opendev.org/show/bTstD8079kCv6MQTxAvu/

I've executed this reproducer while checking the OVN NB logical_switch_port register:
$ watch -n1 -d "ovn-nbctl list logical_switch_port <vip_id>"

What is different in your system? Apart from Octavia.

Regards.

Revision history for this message
Rodolfo Alonso (rodolfo-alonso-hernandez) wrote :

Update: using CLI commands, the problem does not appear. Using the python network client, it does. I still need to investigate what the neutron client is doing there.

Revision history for this message
Rodolfo Alonso (rodolfo-alonso-hernandez) wrote :

The problem in the python reproducer is the VIP device_owner. The VIP must not have one. Once removed from the python reproducer code, the VIP never looses its type "virtual".

Changed in neutron:
status: New → Invalid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/841711

Changed in neutron:
status: Invalid → In Progress
importance: High → Medium
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/842293

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/842294

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/842295

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/842296

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/842297

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/841711
Committed: https://opendev.org/openstack/neutron/commit/4c37497e7c98180fb6b1118021acd8e96b7028d0
Submitter: "Zuul (22348)"
Branch: master

commit 4c37497e7c98180fb6b1118021acd8e96b7028d0
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu May 12 09:26:36 2022 +0000

    [OVN] Allow VIP ports with a defined "device_owner"

    Now OVN VIP port can have a "device_owner" defined.

    Closes-Bug: #1973276
    Change-Id: Id1907481077d230e4461906a1a2a1447abac330a

tags: added: ovn
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/842293
Committed: https://opendev.org/openstack/neutron/commit/7b53aae4cd395909c95dd5946492663a436af52c
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 7b53aae4cd395909c95dd5946492663a436af52c
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu May 12 09:26:36 2022 +0000

    [OVN] Allow VIP ports with a defined "device_owner"

    Now OVN VIP port can have a "device_owner" defined.

    Closes-Bug: #1973276
    Change-Id: Id1907481077d230e4461906a1a2a1447abac330a
    (cherry picked from commit 4c37497e7c98180fb6b1118021acd8e96b7028d0)

tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 20.1.0

This issue was fixed in the openstack/neutron 20.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/843474

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/842295
Committed: https://opendev.org/openstack/neutron/commit/c4d98634cd90bba64b842f538ac7d8a7cef04f2a
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit c4d98634cd90bba64b842f538ac7d8a7cef04f2a
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu May 12 09:26:36 2022 +0000

    [OVN] Allow VIP ports with a defined "device_owner"

    Now OVN VIP port can have a "device_owner" defined.

    Conflicts:
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py

    Closes-Bug: #1973276
    Change-Id: Id1907481077d230e4461906a1a2a1447abac330a
    (cherry picked from commit 4c37497e7c98180fb6b1118021acd8e96b7028d0)
    (cherry picked from commit 9e2425111b6f7413098bbb38f6013d18b3804303)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/842294
Committed: https://opendev.org/openstack/neutron/commit/9e2425111b6f7413098bbb38f6013d18b3804303
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 9e2425111b6f7413098bbb38f6013d18b3804303
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu May 12 09:26:36 2022 +0000

    [OVN] Allow VIP ports with a defined "device_owner"

    Now OVN VIP port can have a "device_owner" defined.

    Conflicts:
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py

    Closes-Bug: #1973276
    Change-Id: Id1907481077d230e4461906a1a2a1447abac330a
    (cherry picked from commit 4c37497e7c98180fb6b1118021acd8e96b7028d0)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/842297
Committed: https://opendev.org/openstack/neutron/commit/be933757faa3e26f689b0bb9a11216ab2dc8082d
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit be933757faa3e26f689b0bb9a11216ab2dc8082d
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu May 12 09:26:36 2022 +0000

    [OVN] Allow VIP ports with a defined "device_owner"

    Now OVN VIP port can have a "device_owner" defined.

    Conflicts:
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py
        neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py

    Closes-Bug: #1973276
    Change-Id: Id1907481077d230e4461906a1a2a1447abac330a
    (cherry picked from commit 4c37497e7c98180fb6b1118021acd8e96b7028d0)
    (cherry picked from commit 9e2425111b6f7413098bbb38f6013d18b3804303)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/842296
Committed: https://opendev.org/openstack/neutron/commit/2ca6dfad81dd09164f5393457c4a1ebddca98217
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 2ca6dfad81dd09164f5393457c4a1ebddca98217
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu May 12 09:26:36 2022 +0000

    [OVN] Allow VIP ports with a defined "device_owner"

    Now OVN VIP port can have a "device_owner" defined.

    Conflicts:
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py
        neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py

    Closes-Bug: #1973276
    Change-Id: Id1907481077d230e4461906a1a2a1447abac330a
    (cherry picked from commit 4c37497e7c98180fb6b1118021acd8e96b7028d0)
    (cherry picked from commit 9e2425111b6f7413098bbb38f6013d18b3804303)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/843474
Committed: https://opendev.org/openstack/neutron/commit/3c93da7bdf35c3be6081384b7f6d9a4ce13510d3
Submitter: "Zuul (22348)"
Branch: master

commit 3c93da7bdf35c3be6081384b7f6d9a4ce13510d3
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Sat May 14 23:54:10 2022 +0000

    Set "type=virtual" for OVN LSP with parent ports

    This is a follow-up of [1]. Before this patch, any virtual logical
    switch port that was updated and the "device_owner" was not and empty
    string, had its type set to '' (empty string).

    This maintenance task, that is executed only once, lists all logical
    switch ports, checks the presence or not of virtual parents and
    sets the type to "virtual" if needed.

    Related-Bug: #1973276

    [1]https://review.opendev.org/c/openstack/neutron/+/841711

    Change-Id: I6cf1167d556f0c2c2aa2013f05c809648020b377

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (stable/yoga)

Related fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/845906

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (stable/xena)

Related fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/845909

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (stable/wallaby)

Related fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/845910

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (stable/victoria)

Related fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/845911

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (stable/ussuri)

Related fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/845912

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/845906
Committed: https://opendev.org/openstack/neutron/commit/316b55440ab7a2b27e0468a87545ee1db9e85b84
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 316b55440ab7a2b27e0468a87545ee1db9e85b84
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Sat May 14 23:54:10 2022 +0000

    Set "type=virtual" for OVN LSP with parent ports

    This is a follow-up of [1]. Before this patch, any virtual logical
    switch port that was updated and the "device_owner" was not and empty
    string, had its type set to '' (empty string).

    This maintenance task, that is executed only once, lists all logical
    switch ports, checks the presence or not of virtual parents and
    sets the type to "virtual" if needed.

    Related-Bug: #1973276

    [1]https://review.opendev.org/c/openstack/neutron/+/841711

    Conflicts:
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py
        neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_maintenance.py

    Change-Id: I6cf1167d556f0c2c2aa2013f05c809648020b377
    (cherry picked from commit 3c93da7bdf35c3be6081384b7f6d9a4ce13510d3)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/845909
Committed: https://opendev.org/openstack/neutron/commit/29ef60c4c6ef7d973d361d5dcf4f29eef7a38183
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 29ef60c4c6ef7d973d361d5dcf4f29eef7a38183
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Sat May 14 23:54:10 2022 +0000

    Set "type=virtual" for OVN LSP with parent ports

    This is a follow-up of [1]. Before this patch, any virtual logical
    switch port that was updated and the "device_owner" was not and empty
    string, had its type set to '' (empty string).

    This maintenance task, that is executed only once, lists all logical
    switch ports, checks the presence or not of virtual parents and
    sets the type to "virtual" if needed.

    Related-Bug: #1973276

    [1]https://review.opendev.org/c/openstack/neutron/+/841711

    Conflicts:
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py
        neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_maintenance.py
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py
        neutron/tests/unit/db/test_db_base_plugin_v2.py
        neutron/tests/unit/extensions/test_portsecurity.py
        neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py

    Change-Id: I6cf1167d556f0c2c2aa2013f05c809648020b377
    (cherry picked from commit 3c93da7bdf35c3be6081384b7f6d9a4ce13510d3)
    (cherry picked from commit 316b55440ab7a2b27e0468a87545ee1db9e85b84)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/845911
Committed: https://opendev.org/openstack/neutron/commit/a75203acf340f4146ee034fd3e35ed9ba0f2b44d
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit a75203acf340f4146ee034fd3e35ed9ba0f2b44d
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Sat May 14 23:54:10 2022 +0000

    Set "type=virtual" for OVN LSP with parent ports

    This is a follow-up of [1]. Before this patch, any virtual logical
    switch port that was updated and the "device_owner" was not and empty
    string, had its type set to '' (empty string).

    This maintenance task, that is executed only once, lists all logical
    switch ports, checks the presence or not of virtual parents and
    sets the type to "virtual" if needed.

    Related-Bug: #1973276

    [1]https://review.opendev.org/c/openstack/neutron/+/841711

    Conflicts:
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py
        neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_maintenance.py
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py
        neutron/tests/unit/db/test_db_base_plugin_v2.py
        neutron/tests/unit/extensions/test_portsecurity.py
        neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py

    Change-Id: I6cf1167d556f0c2c2aa2013f05c809648020b377
    (cherry picked from commit 3c93da7bdf35c3be6081384b7f6d9a4ce13510d3)
    (cherry picked from commit 316b55440ab7a2b27e0468a87545ee1db9e85b84)
    (cherry picked from commit 8c79b631aa36d31be916427c2dbba10f5086389a)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/845912
Committed: https://opendev.org/openstack/neutron/commit/3b9f1be5e5d1287dda6670020a349381f8ba9993
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 3b9f1be5e5d1287dda6670020a349381f8ba9993
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Sat May 14 23:54:10 2022 +0000

    Set "type=virtual" for OVN LSP with parent ports

    This is a follow-up of [1]. Before this patch, any virtual logical
    switch port that was updated and the "device_owner" was not and empty
    string, had its type set to '' (empty string).

    This maintenance task, that is executed only once, lists all logical
    switch ports, checks the presence or not of virtual parents and
    sets the type to "virtual" if needed.

    Related-Bug: #1973276

    [1]https://review.opendev.org/c/openstack/neutron/+/841711

    Conflicts:
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py
        neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_maintenance.py
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py
        neutron/tests/unit/db/test_db_base_plugin_v2.py
        neutron/tests/unit/extensions/test_portsecurity.py
        neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py

    Change-Id: I6cf1167d556f0c2c2aa2013f05c809648020b377
    (cherry picked from commit 3c93da7bdf35c3be6081384b7f6d9a4ce13510d3)
    (cherry picked from commit 316b55440ab7a2b27e0468a87545ee1db9e85b84)
    (cherry picked from commit 8c79b631aa36d31be916427c2dbba10f5086389a)
    (cherry picked from commit d6f395378ce4ed3697c0011afebe2c1d142d8040)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/845910
Committed: https://opendev.org/openstack/neutron/commit/be0a1c3e8110a01e649c01d1c625c2797db34724
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit be0a1c3e8110a01e649c01d1c625c2797db34724
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Sat May 14 23:54:10 2022 +0000

    Set "type=virtual" for OVN LSP with parent ports

    This is a follow-up of [1]. Before this patch, any virtual logical
    switch port that was updated and the "device_owner" was not and empty
    string, had its type set to '' (empty string).

    This maintenance task, that is executed only once, lists all logical
    switch ports, checks the presence or not of virtual parents and
    sets the type to "virtual" if needed.

    Related-Bug: #1973276

    [1]https://review.opendev.org/c/openstack/neutron/+/841711

    Conflicts:
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py
        neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_maintenance.py
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py
        neutron/tests/unit/db/test_db_base_plugin_v2.py
        neutron/tests/unit/extensions/test_portsecurity.py
        neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py

    Change-Id: I6cf1167d556f0c2c2aa2013f05c809648020b377
    (cherry picked from commit 3c93da7bdf35c3be6081384b7f6d9a4ce13510d3)
    (cherry picked from commit 316b55440ab7a2b27e0468a87545ee1db9e85b84)
    (cherry picked from commit 29ef60c4c6ef7d973d361d5dcf4f29eef7a38183)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 18.5.0

This issue was fixed in the openstack/neutron 18.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 19.4.0

This issue was fixed in the openstack/neutron 19.4.0 release.

Revision history for this message
Edward Hope-Morley (hopem) wrote :

patch exists on point release down to wallaby so only need sru for v and u. patch 3b9f1be does not backport cleanly to ubuntu packages so am starting with the other patch ([OVN] Allow VIP ports with a defined "device_owner") that is clean.

Revision history for this message
Edward Hope-Morley (hopem) wrote :
Revision history for this message
Edward Hope-Morley (hopem) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "lp1973276-ussuri.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Revision history for this message
Corey Bryant (corey.bryant) wrote :

New versions of neutron with this fix have been uploaded to victoria-staging and the ubuntu unapproved queue.

Changed in neutron (Ubuntu):
status: New → Fix Released
Changed in neutron (Ubuntu Focal):
importance: Undecided → High
status: New → Triaged
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 21.0.0.0rc1

This issue was fixed in the openstack/neutron 21.0.0.0rc1 release candidate.

Revision history for this message
Corey Bryant (corey.bryant) wrote : Please test proposed package

Hello Gregory, or anyone else affected,

Accepted neutron into victoria-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:victoria-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-victoria-needed to verification-victoria-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-victoria-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-victoria-needed
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Gregory, or anyone else affected,

Accepted neutron into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/neutron/2:16.4.2-0ubuntu4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in neutron (Ubuntu Focal):
status: Triaged → Fix Committed
tags: added: verification-needed verification-needed-focal
Revision history for this message
Corey Bryant (corey.bryant) wrote :

Hello Gregory, or anyone else affected,

Accepted neutron into ussuri-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:ussuri-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-ussuri-needed to verification-ussuri-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-ussuri-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-ussuri-needed
Revision history for this message
Edward Hope-Morley (hopem) wrote :

focal-proposed verified using [Test Plan] and had the following output:

# apt-cache policy neutron-common
neutron-common:
  Installed: 2:16.4.2-0ubuntu4
  Candidate: 2:16.4.2-0ubuntu4
  Version table:
 *** 2:16.4.2-0ubuntu4 500
        500 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     2:16.4.2-0ubuntu3 500
        500 http://nova.clouds.archive.ubuntu.com/ubuntu focal-updates/main amd64 Packages
     2:16.0.0~b3~git2020041516.5f42488a9a-0ubuntu2 500
        500 http://nova.clouds.archive.ubuntu.com/ubuntu focal/main amd64 Packages

ovn-central output:

# before
# ovn-nbctl list Logical_Switch_port| egrep "type|external_ids"| grep octavia-lb -A 1| grep type
type : ""
type : virtual
type : ""

# after
# ovn-nbctl list Logical_Switch_port| egrep "type|external_ids"| grep octavia-lb -A 1| grep type
type : ""
type : ""
type : virtual

I can curl my LB port 80 before/after.

tags: added: verification-done-focal
removed: verification-needed-focal
Revision history for this message
Edward Hope-Morley (hopem) wrote :

victoria-proposed verified using [Test Plan] and had the following output:

# apt-cache policy neutron-common
neutron-common:
  Installed: 2:17.4.1-0ubuntu1~cloud3
  Candidate: 2:17.4.1-0ubuntu1~cloud3
  Version table:
 *** 2:17.4.1-0ubuntu1~cloud3 500
        500 http://ubuntu-cloud.archive.canonical.com/ubuntu focal-proposed/victoria/main amd64 Packages
        100 /var/lib/dpkg/status
     2:16.4.2-0ubuntu3 500
        500 http://nova.clouds.archive.ubuntu.com/ubuntu focal-updates/main amd64 Packages
     2:16.0.0~b3~git2020041516.5f42488a9a-0ubuntu2 500
        500 http://nova.clouds.archive.ubuntu.com/ubuntu focal/main amd64 Packages

# ovn-nbctl list Logical_Switch_port| egrep "type|external_ids|^addresses"| grep octavia-lb -C 1|egrep "type|addresses"
addresses : ["fa:16:3e:04:15:df 192.168.21.218"]
type : ""
addresses : ["fa:16:3e:b4:d6:cd 192.168.21.22"]
type : ""
addresses : ["fa:16:3e:9a:31:f8 192.168.21.109"]
type : virtual
# ovn-nbctl list Logical_Switch_port| egrep "type|external_ids|^addresses"| grep octavia-lb -C 1|egrep "type|addresses"
addresses : ["fa:16:3e:e6:34:39 192.168.21.157"]
type : ""
addresses : ["fa:16:3e:9a:31:f8 192.168.21.109"]
type : virtual
addresses : ["fa:16:3e:ec:1a:ad 192.168.21.190"]
type : ""

I can curl my LB port 80 before/after.

tags: added: verification-victoria-done
removed: verification-victoria-needed
Revision history for this message
Edward Hope-Morley (hopem) wrote :

ussuri-proposed verified using [Test Plan] and had the following output:

# ovn-nbctl list Logical_Switch_port| egrep "type|external_ids|^addresses"| grep octavia-lb -C 1|egrep "type|addresses"
addresses : ["fa:16:3e:c5:e6:0e 192.168.21.54"]
type : ""
addresses : ["fa:16:3e:9b:4c:23 192.168.21.175"]
type : virtual
addresses : ["fa:16:3e:7f:f1:36 192.168.21.105"]
type : ""
# ovn-nbctl list Logical_Switch_port| egrep "type|external_ids|^addresses"| grep octavia-lb -C 1|egrep "type|addresses"
addresses : ["fa:16:3e:d0:6c:a6 192.168.21.73"]
type : ""
addresses : ["fa:16:3e:ac:b8:5e 192.168.21.42"]
type : ""
addresses : ["fa:16:3e:9b:4c:23 192.168.21.175"]
type : virtual

# apt-cache policy neutron-common
neutron-common:
  Installed: 2:16.4.2-0ubuntu4~cloud0
  Candidate: 2:16.4.2-0ubuntu4~cloud0
  Version table:
 *** 2:16.4.2-0ubuntu4~cloud0 500
        500 http://ubuntu-cloud.archive.canonical.com/ubuntu bionic-proposed/ussuri/main amd64 Packages
        100 /var/lib/dpkg/status
     2:12.1.1-0ubuntu8 500
        500 http://nova.clouds.archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages
     2:12.0.1-0ubuntu1 500
        500 http://nova.clouds.archive.ubuntu.com/ubuntu bionic/main amd64 Packages

tags: added: verification-done verification-ussuri-done
removed: verification-needed verification-ussuri-needed
Revision history for this message
Corey Bryant (corey.bryant) wrote : Update Released

The verification of the Stable Release Update for neutron has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Corey Bryant (corey.bryant) wrote :

This bug was fixed in the package neutron - 2:17.4.1-0ubuntu1~cloud3
---------------

 neutron (2:17.4.1-0ubuntu1~cloud3) focal-victoria; urgency=medium
 .
   [ Zhang Hua ]
   * d/p/defer-flow-deletion-in-openvswitch-firewall.patch:
     Defer flow deletion in openvswitch firewall (LP: #1975674)
 .
   [ Edward Hope-Morley ]
   * Ensure ovn virtual port type not removed (LP: #1973276)
     - d/p/ovn-allow-vip-ports-with-defined-device-owner.patch
     - d/p/set-type-virtual-for-ovn-lsp-with-parent-ports.patch

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package neutron - 2:16.4.2-0ubuntu4

---------------
neutron (2:16.4.2-0ubuntu4) focal; urgency=medium

  [ Zhang Hua ]
  * d/p/defer-flow-deletion-in-openvswitch-firewall.patch:
    Defer flow deletion in openvswitch firewall (LP: #1975674)

  [ Edward Hope-Morley ]
  * Ensure ovn virtual port type not removed (LP: #1973276)
    - d/p/ovn-allow-vip-ports-with-defined-device-owner.patch
    - d/p/set-type-virtual-for-ovn-lsp-with-parent-ports.patch

 -- Corey Bryant <email address hidden> Thu, 15 Sep 2022 15:42:05 -0400

Changed in neutron (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Corey Bryant (corey.bryant) wrote :

The verification of the Stable Release Update for neutron has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Corey Bryant (corey.bryant) wrote :

This bug was fixed in the package neutron - 2:16.4.2-0ubuntu4~cloud0
---------------

 neutron (2:16.4.2-0ubuntu4~cloud0) bionic-ussuri; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 neutron (2:16.4.2-0ubuntu4) focal; urgency=medium
 .
   [ Zhang Hua ]
   * d/p/defer-flow-deletion-in-openvswitch-firewall.patch:
     Defer flow deletion in openvswitch firewall (LP: #1975674)
 .
   [ Edward Hope-Morley ]
   * Ensure ovn virtual port type not removed (LP: #1973276)
     - d/p/ovn-allow-vip-ports-with-defined-device-owner.patch
     - d/p/set-type-virtual-for-ovn-lsp-with-parent-ports.patch

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron ussuri-eol

This issue was fixed in the openstack/neutron ussuri-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron victoria-eom

This issue was fixed in the openstack/neutron victoria-eom release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.