[radeon] Xorg crashed with SIGSEGV when using the RADEON driver

[Daniel]

* Impact

The xserver crash, closing the session, when trying to rotate the screen when using the ati driver

* Test case
- start an xorg based session
- try to rotate the screen by 90°

-> the session shouldn't close

* Regression potential

if the fix was incorrect it could lead to screen parameters not being set correctly. Try changing the resolution and rotation and ensure the changes are what is expected

------------------------

When using Settings/Display/Orientation/Portret right and Apply then X crashes and login screen is displayed. Tested with 3 different AMD systems (older). Bug is not present with Intel graphics

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: xorg 1:7.7+23ubuntu2
ProcVersionSignature: Ubuntu 5.15.0-25.25-generic 5.15.30
Uname: Linux 5.15.0-25-generic x86_64
NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair
ApportVersion: 2.20.11-0ubuntu82
Architecture: amd64
BootLog: Error: [Errno 13] Permission denied: '/var/log/boot.log'
CasperMD5CheckResult: pass
CasperVersion: 1.470
CompositorRunning: None
CurrentDesktop: ubuntu:GNOME
Date: Tue Apr 26 19:30:33 2022
DistUpgraded: Fresh install
DistroCodename: jammy
DistroVariant: ubuntu
ExtraDebuggingInterest: No
GraphicsCard:
 Advanced Micro Devices, Inc. [AMD/ATI] Caicos [Radeon HD 6450/7450/8450 / R5 230 OEM] [1002:6779] (prog-if 00 [VGA controller])
   Subsystem: ASUSTeK Computer Inc. Caicos [Radeon HD 6450/7450/8450 / R5 230 OEM] [1043:03da]
LiveMediaBuild: Ubuntu 22.04 LTS "Jammy Jellyfish" - Release amd64 (20220419)
MachineType: Hewlett-Packard HP Compaq 6005 Pro MT PC
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=ro_RO.UTF-8
 SHELL=/bin/bash
ProcKernelCmdLine: BOOT_IMAGE=/casper/vmlinuz file=/cdrom/preseed/username.seed maybe-ubiquity quiet splash ---
SourcePackage: xorg
Symptom: display
Title: Xorg crash
UpgradeStatus: No upgrade log present (probably fresh install)
dmi.bios.date: 08/04/2010
dmi.bios.release: 1.11
dmi.bios.vendor: Hewlett-Packard
dmi.bios.version: 786G6 v01.11
dmi.board.asset.tag: CZC1332VBJ
dmi.board.name: 3047h
dmi.board.vendor: Hewlett-Packard
dmi.chassis.asset.tag: CZC1332VBJ
dmi.chassis.type: 6
dmi.chassis.vendor: Hewlett-Packard
dmi.modalias: dmi:bvnHewlett-Packard:bvr786G6v01.11:bd08/04/2010:br1.11:svnHewlett-Packard:pnHPCompaq6005ProMTPC:pvr:rvnHewlett-Packard:rn3047h:rvr:cvnHewlett-Packard:ct6:cvr:skuAT493AV:
dmi.product.family: 103C_53307F
dmi.product.name: HP Compaq 6005 Pro MT PC
dmi.product.sku: AT493AV
dmi.sys.vendor: Hewlett-Packard
version.compiz: compiz N/A
version.libdrm2: libdrm2 2.4.110-1ubuntu1
version.libgl1-mesa-dri: libgl1-mesa-dri 22.0.1-1ubuntu2
version.libgl1-mesa-glx: libgl1-mesa-glx N/A
version.xserver-xorg-core: xserver-xorg-core 2:21.1.3-2ubuntu2
version.xserver-xorg-input-evdev: xserver-xorg-input-evdev N/A
version.xserver-xorg-video-ati: xserver-xorg-video-ati 1:19.1.0-2build3
version.xserver-xorg-video-intel: xserver-xorg-video-intel 2:2.99.917+git20210115-1
version.xserver-xorg-video-nouveau: xserver-xorg-video-nouveau 1:1.0.17-2build1

[Daniel van Vugt (vanvugt)]

It appears the problem started in the RADEON driver and then Xorg crashed:

[ 186.951] (EE) RADEON(0): drmmode_do_crtc_dpms cannot get last vblank counter
[ 186.958] (II) RADEON(0): Allocate new frame buffer 1080x1920
[ 186.963] (II) RADEON(0): VRAM usage limit set to 218116K
[ 186.965] (EE)
[ 186.965] (EE) Backtrace:
[ 186.966] (EE) 0: /usr/lib/xorg/Xorg (OsLookupColor+0x139) [0x563b05a0d2b9]
[ 186.967] (EE) 1: /lib/x86_64-linux-gnu/libc.so.6 (__sigaction+0x50) [0x7f1b91765520]
[ 186.968] (EE) 2: ? (?+0x0) [0x0]
[ 186.968] (EE) 3: ? (?+0x0) [0x0]
[ 186.968] (EE)
[ 186.968] (EE) Segmentation fault at address 0x0
[ 186.968] (EE)
Fatal server error:
[ 186.968] (EE) Caught signal 11 (Segmentation fault). Server aborting
[ 186.968] (EE)

[Daniel van Vugt (vanvugt)]

Please choose a Wayland session on the login screen if you can. That should avoid it.

[Daniel (tulpina)]

Wayland session prevent crash, i can confirm. So, it is about Xorg and Radeon driver

[Daniel (tulpina)]

Also tested and reproduce bug on these devices:

Advanced Micro Devices, Inc. [AMD/ATI] Kaveri [Radeon R7 Graphics] (rev d7)
Advanced Micro Devices, Inc. [AMD/ATI] Mullins [Radeon R4/R5 Graphics] (rev 01)

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[pl.profetes (pl-profetes)]

Advanced Micro Devices, Inc. [AMD/ATI] Pitcairn PRO [Radeon HD 7850 / R7 265 / R9 270 1024SP]

Wayland is not affected. Xorg crashes as soon as rotated screen is being initialized. I have my other screen rotated permanently in Gnome setting and this bug makes it impossible to log in (crash after providing a password) on Xorg.

Bug was not present in Ubuntu 21.10 (I upgraded yesterday)

port used does not matter, happens both on DP and HDMI.

[Simon Iremonger (ubuntu-iremonger)]

I can confirm the same crash happening with 22.04 Xorg and radeon card:-

VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Cedar [Radeon HD 5000/6000/7350/8350 Series]

... when trying to rotate... which always used to work before e.g. in 20.04LTS.

[Launchpad Janitor (janitor)]

This bug was fixed in the package xserver-xorg-video-ati - 1:19.1.0-3

---------------
xserver-xorg-video-ati (1:19.1.0-3) unstable; urgency=medium

  * fix-rotation.diff: Fix crash on rotation. (Closes: #1009325)
    (LP: #1970473)

 -- Timo Aaltonen <email address hidden> Fri, 08 Jul 2022 12:52:34 +0300

[Sebastien Bacher (seb128)]

SRU uploaded to the 22.04 review queue now

[Robie Basak (racb)]

Hello Daniel, or anyone else affected,

Accepted xserver-xorg-video-ati into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/xserver-xorg-video-ati/1:19.1.0-2ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Simon Iremonger (ubuntu-iremonger)]

Versions tested against jammy (retrieved via jammy-proposed updates):-
ii xserver-xorg-video-ati 1:19.1.0-2ubuntu1
ii xserver-xorg-video-radeon 1:19.1.0-2ubuntu1
Tried these updates alone, tried in combination with other jammy-proposed too.
Tried on previously-crashing radeon system. Tried on intel system.
All ways tested:-
* rotation works
* 3d applications work
* no other errors/issues apparent to me.

**NB** I do not seem to have the $magic or permission to:-
tag -verification-needed-jammy
tag verification-done-jammy

[Launchpad Janitor (janitor)]

This bug was fixed in the package xserver-xorg-video-ati - 1:19.1.0-2ubuntu1

---------------
xserver-xorg-video-ati (1:19.1.0-2ubuntu1) jammy; urgency=medium

  * debian/patches/fix-rotation.patch:
    - fix xserver crashing on screen rotation (LP: #1970473)

 -- Sebastien Bacher <email address hidden> Mon, 11 Jul 2022 16:58:10 +0200

[Robie Basak (racb)]

The verification of the Stable Release Update for xserver-xorg-video-ati has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.