[SRU] impressive segfault

[Joseph Maillardet]

[ Impact ]

'impressive' is completely unusable in Jammy. It fails to open any pdf and results in a segfault with the following error:

Welcome to Impressive version 0.13.0-beta2 (SVN r298)
pygame 2.1.2 (SDL 2.0.20, Python 3.10.12)
Hello from the pygame community. https://www.pygame.org/contribute.html
Detected screen size: 1280x800 pixels
PDF renderer: Xpdf/Poppler
pdftkParse() FAILED
Segmentation fault (core dumped)

[ Test Plan ]

 * install impressive in a Jammy installation
 * try open any pdf from cmdline using the command:
   impressive <pdfname>
   Example: $ impressive test.pdf
 * It will fail and will print the error message with segfault.
 * With the fix, impressive will be able to open the pdf and display it.

[ Where problems could occur ]

 * The fix is checking for the pygame sdl version and then based on the version using the correct SDL library.
   It does not change any other code and so does not change the behaviour and has little chance of regressing the user behaviour.

[ Other Info ]

* When any user executes impressive, it will try to load the Pygame SDL libraries. And the old v0.13.0-beta2 expects the Pygame SDL libraries to be pre-v2.0.0. But Jammy has a later version of Pygame and as a result 'impressive' fails to find the library.

* The problem exists in v0.13.0~beta2-2 and has been fixed by upstream in v0.13.1 and so only Jammy is affected.

[ Original Bug Description ]

On Ubuntu 22.04 with default Ubuntu session (Wayland) impressive crash when trying to open any PDF files. Terminal say :

Welcome to Impressive version 0.13.0-beta2 (SVN r298)
pygame 2.1.2 (SDL 2.0.20, Python 3.10.4)
Hello from the pygame community. https://www.pygame.org/contribute.html
Detected screen size: 2560x1080 pixels
PDF renderer: MuPDF 1.4 or newer
Segmentation error

Crash happen with or without mupdf installed.

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: impressive 0.13.0~beta2-2
ProcVersionSignature: Ubuntu 5.15.0-25.25-generic 5.15.30
Uname: Linux 5.15.0-25-generic x86_64
ApportVersion: 2.20.11-0ubuntu82
Architecture: amd64
CasperMD5CheckResult: unknown
CurrentDesktop: ubuntu:GNOME
Date: Fri Apr 22 19:15:49 2022
EcryptfsInUse: Yes
PackageArchitecture: all
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=fr_FR.UTF-8
 SHELL=/bin/bash
SourcePackage: impressive
UpgradeStatus: Upgraded to jammy on 2022-04-22 (0 days ago)
modified.conffile..etc.default.apport:
 # set this to 0 to disable apport, or to 1 to enable it
 # you can temporarily override this with
 # sudo service apport start force_start=1
 enabled=0
mtime.conffile..etc.default.apport: 2015-11-27T14:42:56.796345

[Joseph Maillardet (jokx)]

I have tried on another computer with Wayland or X.org session, and i got the same "core dumped" crash.

Output on X.org:

Welcome to Impressive version 0.13.0-beta2 (SVN r298)
pygame 2.1.2 (SDL 2.0.20, Python 3.10.4)
Hello from the pygame community. https://www.pygame.org/contribute.html
Detected screen size: 1680x1050 pixels
PDF renderer: MuPDF 1.4 or newer
pdftkParse() FAILED
Erreur de segmentation (core dumped)

[Joseph Maillardet (jokx)]

Third try on a computer with Intel graphical card (the first two was AMD powered), with ubuntu live session. Same core dump crash.

Fun fact, the "demo.pdf" given with the package have "no page" :D

Welcome to Impressive version 0.13.0-beta2 (SVN r298)
pygame 2.1.2 (SDL 2.0.20, Python 3.10.4)
Hello from the pygame community. https://www.pygame.org/contribute.html
Detected screen size: 1920x1080 pixels
PDF renderer: Xpdf/Poppler
pdftkParse() FAILED
WARNING: The input file `/usr/share/doc/impressive/demo.pdf' could not be analyzed.
The presentation doesn't have any pages, quitting.

With another PDF :

Welcome to Impressive version 0.13.0-beta2 (SVN r298)
pygame 2.1.2 (SDL 2.0.20, Python 3.10.4)
Hello from the pygame community. https://www.pygame.org/contribute.html
Detected screen size: 1920x1080 pixels
PDF renderer: Xpdf/Poppler
pdftkParse() FAILED
Erreur de segmentation (core dumped)

[Joseph Maillardet (jokx)]

impressive 0.13.1 downloaded from sourceforge.net work well.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Martin Fiedler (keyj-ubuntu)]

Original author of the software here. The old 0.13.0-beta2 version of Impressive is fundamentally incompatible with PyGame 2.x, but focal ships with that combination.

The proper resolution would be to push an update to focal so it gets impressive 0.13.1 (of which a package exists) or, if it's planned to update python3-pil to >=10.0 during focal's lifetime, even 0.13.2.

[Cool Dude (eijentwun)]

I fixed this issue by simply downloading the impressive-0.13.2.tar.gz and unpacking it and dragging the impressive to usr/bin/ and the impressive.py to usr/share/impressive/ and I renamed the ones that wee already in there to: impressve-old and impressive-old.py just incase it dint work out as I planned and now everything works!
This was on Linux Mint 21.2 MATE which is the equivalent of Ubuntu 22.04 Jammy Jellyfish so probably should be the same.

[Cool Dude (eijentwun)]

By the way to get into the bin and usr/share/impressive folders I navigate to them and then right click the folder I am about to enter and select Open As Administrator and put my password... I am now able to copy and delete files in these folders until I close them. I am a hands on Guy and despise doing this kind of thing through the terminal. this is alot easier. This works on MATE/Caja...dont know if other Filemanagers have this option. Another win for the best Desktop Environment....MATE!

[Sudip Mukherjee (sudipmuk)]

I can reproduce the issue on Jammy with 0.13.0~beta2-2 and have also tested and confirmed that Lunar, Mantic and Noble are not affected.

[Sudip Mukherjee (sudipmuk)]

Attaching debdiff for Jammy.

[Sudip Mukherjee (sudipmuk)]

Modified debdiff for Jammy with corrected version and dep-3 headers attached.

[Steve Langasek (vorlon)]

Hello Joseph, or anyone else affected,

Accepted impressive into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/impressive/0.13.0~beta2-2ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Sudip Mukherjee (sudipmuk)]

I can confirm that the impressive package in jammy-proposed has fixed the bug for me.

Test done:
1. Install impressive on a jammy installation.

2. Tried to open a pdf from a terminal with the command
 "impressive <pdfname>" which failed with segfault.

3. Add jammy-proposed to apt sources

4. Update impressive from jammy-proposed.

5. execute the command again and the pdf is displayed in the impressive window.

Test result: the errors with impressive has been fixed.

Package tested:

$ dpkg -l impressive
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Architecture Description
+++-==============-=======================-============-======================================
ii impressive 0.13.0~beta2-2ubuntu0.1 all PDF presentation tool with eye candies

[Robie Basak (racb)]

The verification of the Stable Release Update for impressive has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package impressive - 0.13.0~beta2-2ubuntu0.1

---------------
impressive (0.13.0~beta2-2ubuntu0.1) jammy; urgency=medium

  * Apply upstream fix to find correct SDL library. (LP: #1969968)

 -- Sudip Mukherjee <email address hidden> Thu, 14 Dec 2023 17:49:43 +0000