oss4-dkms '-mfloat-abi=hard' build failure

[Andrea Righi]

[Impact]

oss4-dkms fails to build in Jammy with the following error:

gcc: error: unrecognized command-line option ‘-mfloat-abi=hard’

[Test case]

 $ sudo apt install oss4-dkms

[Fix]

Get rid of -float-abi=hard, since it doesn't really provide any benefits nowdays.

[Regression potential]

We may experience performance regressions in oss4, but getting rid of '-mfloat-abi=hard’ provides a better compatibility across all the supported architectures and toolchains.

[Andrea Righi (arighi)]

v2: drop -mfloat-abi=hard and build only on amd64.

[Dimitri John Ledkov (xnox)]

In unapproved.

[Steve Langasek (vorlon)]

> We may experience performance regressions in oss4, but
> getting rid of '-mfloat-abi=hard’ provides a better
> compatibility across all the supported architectures and toolchains.

Where, according to the newly-uploaded package, "supported architectures" are being reduced to amd64-only. That is not normally a change we allow in SRU. Please elaborate why it is appropriate to reduce the architecture support in this package.

[Andrea Righi (arighi)]

@vorlon oss4 is an ancient sound system platform that is rarely used nowdays, it would actually make sense to drop the support completely. Restricting the support to amd64-only seems a good compromise to fix the current build errors w/ modern toolchain, because of the -mfloat-abi=hard build option (that is blocking kernels promotions) and still provide a minimal support for this sound system. I think it's very unlikely to have users of this dkms outside of the amd64 world.

But I'm open to better solutions/ideas to fix this.

[Heinrich Schuchardt (xypron)]

Duplicate to LP #1969145

As normally alsa is used as sound system and there is alsa-oss to provide a compatibility layer dropping non-amd64 architectures makes sense.

[Thomas Ward (teward)]

FYI #1969145 has been closed as a duplicate of this bug, and sponsors unsubscribed from that bug.

[Steve Langasek (vorlon)]

Andrea, the -mfloat-abi=hard is only relevant on armhf; what about dropping support for it only on armhf?

[Steve Langasek (vorlon)]

And I'm more than happy for us to drop this as obsolete in kinetic and later; please file a separate bug report for that and subscribe ubuntu-archive.

[Andrea Righi (arighi)]

@vorlon JFYI, I've just created LP: #1975499 for kinetic.

[Steve Langasek (vorlon)]

I've removed the package from kinetic now.

Have you considered the suggestion to build for all architectures except for armhf?

[Robie Basak (racb)]

This is fixed for Kinetic in bug 1975499 so that's somewhere between Invalid and Fix Released now.

For Jammy, Steve's question hasn't been answered in over a month so I'm removing the upload to clean up the queue. The bug remains open.

[Robie Basak (racb)]

An upload of oss4 to jammy-proposed has been rejected from the upload queue for the following reason: "See https://bugs.launchpad.net/ubuntu/+source/oss4/+bug/1969752/comments/12".

[Andrea Righi (arighi)]

debdiff in attach allows to support linux 5.19 in jammy and it handles -mfloat-abi=hard correctly, enabling it only on armhf (since it's relevant only on this arch).

[Łukasz Zemczak (sil2100)]

Accepting this, but please be sure to include proper DEP-3 patch headers for patches included in SRUs next time.

[Łukasz Zemczak (sil2100)]

Hello Andrea, or anyone else affected,

Accepted oss4 into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/oss4/4.2-build2010-5ubuntu9.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Kleber Sacilotto de Souza (kleber-souza)]

Confirmed that it can be built for both generic 5.15 and hwe 5.19 kernels:

=========================================================
Setting up oss4-dkms (4.2-build2010-5ubuntu9.1) ...
Loading new oss4-4.2-build2010 DKMS files...
Building for 5.15.0-60-generic 5.19.0-32-generic
Building initial module for 5.15.0-60-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

osscore.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-60-generic/updates/dkms/

oss_sbpci.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-60-generic/updates/dkms/

oss_sbxfi.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-60-generic/updates/dkms/

oss_via823x.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-60-generic/updates/dkms/

oss_geode.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-60-generic/updates/dkms/

oss_envy24.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-60-generic/updates/dkms/

oss_userdev.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-60-generic/updates/dkms/

oss_digi96.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-60-generic/updates/dkms/

oss_midiloop.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-60-generic/updates/dkms/

oss_imux.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-60-generic/updates/dkms/

oss_hdaudio.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-60-generic/updates/dkms/

oss_envy24ht.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-60-generic/updates/dkms/

oss_cmi878x.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-60-generic/updates/dkms/

oss_atiaudio.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Ins...

[Launchpad Janitor (janitor)]

This bug was fixed in the package oss4 - 4.2-build2010-5ubuntu9.1

---------------
oss4 (4.2-build2010-5ubuntu9.1) jammy; urgency=medium

  * Correctly handle -mfloat-abi=hard that is only relevant on armhf
    (LP: #1969752).
  * Support linux 5.19:
    - d/p/530-Linux-5.19-fix-stdarg-include.patch

 -- Andrea Righi <email address hidden> Tue, 17 Jan 2023 16:05:10 +0000

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for oss4 has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.