Unable to select a skin for a page with the keyboard

Bug #1969717 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned
22.04
Fix Released
Medium
Unassigned
22.10
Fix Released
Medium
Unassigned

Bug Description

When I am creating a page and I want to use a skin, I am unable to select a skin using the keyboard only to select it.

1. Log in as site admin.
2. Create a site skin at Admin menu → Configure site → Skins.
3. Create one new account.
4. Create a personal skin via Main menu → Create → Skins and make it a public one.
5. Log in as the other account holder.
6. Favourite the site admin's skin via Main menu → Create → Skins.
7. Create a personal skin.
8. Add a page and use the keyboard to navigate to the 'Skins' panel on the 'Settings' page.

Results:
- Expected: You can select your personal skin, click the panels for the favourite and site skins and select those.
- Actual result: You can only click the headers, but not the skins themselves, and the panels for the favourite and site skins don't expand.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote (last edit ):

Probably tabindex needed in skin <div>. the skin box has an a tag but needs an href="#"

tags: added: bite-sized
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/13078
Committed: https://git.mahara.org/mahara/mahara/commit/991cb739310a3f87eb6e180de1f8f6e07d8b2f7a
Submitter: "Gold <email address hidden>"
Branch: main

commit 991cb739310a3f87eb6e180de1f8f6e07d8b2f7a
Author: Robert Lyon <email address hidden>
Date: Wed Aug 24 13:30:29 2022 +1200

Bug 1969717: Add ability to select a skin for a page with the keyboard

Change-Id: I63568d997c441937ad48397eb41264600be4074c
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "22.04_DEV" branch: https://reviews.mahara.org/c/mahara/+/13145

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/13145
Committed: https://git.mahara.org/mahara/mahara/commit/034c9503fa2d2667f40ea574081772e29662165d
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.04_DEV

commit 034c9503fa2d2667f40ea574081772e29662165d
Author: Robert Lyon <email address hidden>
Date: Wed Aug 24 13:30:29 2022 +1200

Bug 1969717: Add ability to select a skin for a page with the keyboard

Change-Id: I63568d997c441937ad48397eb41264600be4074c
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 991cb739310a3f87eb6e180de1f8f6e07d8b2f7a)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.