gitk requires wish8.5 but depends on tk8.4

Bug #196846 reported by Vance Lankhaar
62
Affects Status Importance Assigned to Milestone
git-core (Ubuntu)
Fix Released
High
Steve Langasek
Hardy
Fix Released
High
Steve Langasek

Bug Description

Binary package hint: gitk

Gitk seems to need tk8.5 but does not Depend on it.

$ gitk
exec: 3: /usr/bin/wish8.5: not found

$ head -n 3 `which gitk`
#!/bin/sh
# Tcl ignores the next line -*- tcl -*- \
exec /usr/bin/wish8.5 "$0" -- "$@"

$ apt-cache show gitk | grep ^Depends
Depends: git-core (>> 1:1.5.4.3), git-core (<< 1:1.5.4.3-.), tk8.4

$ dpkg --list tk\*.* git{-core,k}
ii git-core 1:1.5.4.3-1ubuntu1 fast, scalable, distributed revision control system
ii gitk 1:1.5.4.3-1ubuntu1 fast, scalable, distributed revision control system (revision tr
ii tk8.4 8.4.16-2ubuntu1 Tk toolkit for Tcl and X11, v8.4 - run-time files

Tags: bitesize patch
Revision history for this message
Tyler Willingham (tyler-ubuntu) wrote :

I am seeing this on hardy.

Changed in git-core:
status: New → Confirmed
Revision history for this message
Bregor Esgarothian (me-bregor) wrote :

As a temporary solution I did the following:

# ln -s /usr/bin/wish8.4 /usr/bin/wish8.5

Revision history for this message
Bryan Donlan (bdonlan) wrote :

Attached is a trivial patch to fix this. I'm also uploading a fixed package to my PPA.

Nominating this for hardy, as the fix is truly trivial, and gitk is broken without it.

Revision history for this message
James Westby (james-w) wrote :

Hi,

This also applies to git-gui.

Is there a reason that the dependency is not just updated?

Thanks,

James

Iulian Udrea (iulian)
Changed in git-core:
importance: Undecided → High
Revision history for this message
Daniel Hahler (blueyed) wrote :

From debian/changelog in Hardy:

git-core (1:1.5.4.3-1ubuntu1) hardy; urgency=low

  * debian/control: Switch back Tcl/Tk dependencies to 8.4, since that's what
    we settled for in Hardy.
  [...]

 -- Martin Pitt <email address hidden> Wed, 27 Feb 2008 16:34:26 +0100

Revision history for this message
Daniel Hahler (blueyed) wrote :

Bryan, thanks for the debdiff. Can you please fix the version in the changelog, so that it's ready for sponsoring?
I've tested the patch: it fixes the wrong path in /usr/bin/git-gui, at least.

Changed in git-core:
milestone: none → ubuntu-8.04
status: Confirmed → Triaged
Revision history for this message
Bryan Donlan (bdonlan) wrote :

Fixed debdiff attached. I've also uploaded it to my PPA, in case that's more convenient.

dget http://ppa.launchpad.net/bdonlan/ubuntu/pool/main/g/git-core/git-core_1.5.4.3-1ubuntu2.dsc once the update run completes.

Revision history for this message
Steve Langasek (vorlon) wrote :

Bryan, thank you for the patch. I'm assigning this bug to myself, and plan to upload in the morning after verifying that the patch fixes all the references to wish8.5.

Changed in git-core:
assignee: nobody → vorlon
status: Triaged → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package git-core - 1:1.5.4.3-1ubuntu2

---------------
git-core (1:1.5.4.3-1ubuntu2) hardy; urgency=low

  * debian/rules: Use wish8.4 for the tcl interpreter, to match our dependency
    in debian/control. (LP: #196846)

 -- Bryan Donlan <email address hidden> Sun, 06 Apr 2008 18:53:53 -0400

Changed in git-core:
status: In Progress → Fix Released
Revision history for this message
Ohad Lutzky (lutzky) wrote :

The fix is suboptimal, as wish8.5 can be installed (part of tk8.5, which is available in hardy), and shows antialiased fonts. The best option IMO would be the one currently in git (the git repository of gitk, that is), which is to leave it at /usr/bin/wish and let people choose with update-alternatives.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.