Disabling the display of window decorations no longer works.

[Tomaz Kapias]

Since version 5.5 of Xpad, apparently you have prepared the ground for the switch to GTK4.

Unfortunately, since the update, I noticed the loss of 2 important features:

1. Clicking in the notification area no longer toggles the appearance of notes. As seen in the bug report n°1965034: https://bugs.launchpad.net/xpad/+bug/1965034. Ok, too bad, we can do without.

2. But also the option to disable the display of window decorations does not work anymore. I still see the window borders.

I'm using Debian 11 with the i3wm-gaps (i3wm fork) window manager and Compton (Picom fork).

Everything worked fine with version 5.4.0-2, then not anymore with higher versions, including 5.7.0-2, currently stable under Debian.

I reinstalled a package of 5.4.0-2, from Debian snapshots, manually for the moment.

[Arthur Borsboom (arthurborsboom)]

Hi Tomaz,

I have a guess of what you are talking about, but I would like to be sure.
Would you mind to share a screenshot of the window decorations that are still showing?

[Tomaz Kapias (tkapias)]

I captured the situation with both versions. Same settings and dependencies.

[Arthur Borsboom (arthurborsboom)]

Hi Tomaz,

My guess was right. I noticed as well there is a border of about 5 pixels that have magically appeared. I dislike GTK.... it is a pain for maintenance. Every time something changes and breaks, just like this. :(

I will have a look if there is something I can do to fix this.

[Arthur Borsboom (arthurborsboom)]

Version 5.8

* Fix: the move from GtkSourceView 3 > 4 has resulted in a border of 5 pixels around the pad. Restoring the original behavior by changing the outer border back to the inner margin. (#1967964)

[Arthur Borsboom (arthurborsboom)]

If you have the ability to test Xpad 5.8 by compiling yourself, would you mind to verify if the issue has been resolved in 5.8?

[Tomaz Kapias (tkapias)]

It worked.

Launching the binary from cli, I saw this error at launch:

(xpad:1116892): Gdk-CRITICAL **: 20:34:30.268: gdk_window_thaw_toplevel_updates: assertion 'window->update_and_descendants_freeze_count > 0' failed

It was not here in 5.4, but I don't know what it means.

The border is not here anymore.

Thank you very much, I hope that Xpad can come back nicely from this upgrade, there was no good alternative out there.

[Arthur Borsboom (arthurborsboom)]

Hi Tomaz,

I don't see this error message on my system, so it might be dependent on the environment.
The first 2 hits in DuckDuckGo point to xfce4.

Are you using XFCE ?

[Tomaz Kapias (tkapias)]

Hi Arthur,

Yes I use Xfce but only for session, power-manager, confd, notifyd and terminal. Not the composition or windows.

And there is a lot of other results with the same line on other project, apparently something to do with gdk or the schemas.

Maybe because I launched Xpad after compilation without installing ? It used dependencies of the 5.4?

[Arthur Borsboom (arthurborsboom)]

In one of the hits on DuckDuckGo it stated something with xfce-terminal. It also stated something about the app indicator.

Xpad 5.7 depends on a new app indicator called "libayatana-indicator".

Is this indicator installed ?

[Arthur Borsboom (arthurborsboom)]

I have to rectify this. Xpad does not depend on it, but if there is an app indicator it will use the libayatana library.

Just to find the pattern, the other applications which show the same error message, do they have a systray / app indicator as well?

[Tomaz Kapias (tkapias)]

I have the package libayatana-appindicator3-1, a lot of apps use it without issues.

I found a post saying that Radiotray had the same issue, and I use Radiotray-ng.
I even had an issue with the appindicator 1 year ago here : https://github.com/ebruck/radiotray-ng/issues/165
So I tried to start it from the cli, it output the same error. I tried to start Radiotray-ng from the Alacritty terminal or Xfce4-terminal and I have the same error in the output.

It's not related to xfce4-terminal, it just had the same issue some years ago.
If I start xfce4-terminal (with "xfce4-terminal --drop-down", to use the systray icon) from Alacrtty, there is no error.
Apparently they fixed it here :
https://git.xfce.org/apps/xfce4-terminal/commit/?id=eff5e2db3dff7e586193e95156da24f2acf33eeb

Also there is this issue for SystemTray where they found a correction too : https://github.com/dorkbox/SystemTray/issues/19

Apparently everything is related to GDK, the systray and maybe appindicator.

[Arthur Borsboom (arthurborsboom)]

Hi Tomaz,

I am not sure how to help you from here.
I guess you have to investigate a bit more, to find a pattern and hopefully the cause.

If it is a problem specifically to Xpad, please create a new bug report.
Let's assume this bug report as "Fix commited", since the original report has been resolved, right?

[Tomaz Kapias (tkapias)]

Hi Arthur,

I'll try to put some time on this soon.

Thank you for the fix to the original issue anyway, I sent an info message on the Debian report too.