ltrace - build on ppc64el fails
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ltrace (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The build on ppc64el fails with the following error:
plt.c: In function ‘arch_elf_
plt.c:781:17: error: ‘libsym’ may be used uninitialized in this function [-Werror=
781 | free(libsym);
| ^~~~~~~~~~~~
cc1: all warnings being treated as errors
This seems to be happening because our back-port of this upstream patch is wrong:
commit 7f20cb21a0d021a
Author: Thierry Fauck <email address hidden>
AuthorDate: Tue May 13 07:48:24 2014 -0400
Commit: Petr Machata <email address hidden>
CommitDate: Wed Nov 11 19:08:43 2015 +0100
Support for powerpc64 arch ppc64el
Signed-off-by: Thierry Fauck <email address hidden>
Add support for ppc64le proc and ELF ABIv2.
The original patch leans on a jump to a "fail" label (that is declared near the beginning of the function and does the following):
free(name);
return PLT_FAIL;
In the 0.7.3 code, however, a different definition of the "fail" label exists. It is declared later in the function and relies on the libsym variable being initialized:
free(name);
free(libsym);
return plt_fail;
Hello,
Adding a .debdiff to fix the FTBFS issue on ppc64el.
Built properly on a PPA:
https:/ /launchpad. net/~ogayot/ +archive/ ubuntu/ ltrace/ +build/ 23518042
Thanks,
Olivier