Yaru Metacity theme has incorrectly scaled windows buttons on HiDPI displays

[Simon Morgan]

 HiDPI scaling is broken in Mate 1.26 produced unscaled/corrputed Windows buttons

Steps to reproduce:

Mate Tweak > Windows > HiDPI change from "auto" to "HiDPI"
Result: A lot of flickering then everything looks fine at 200%
Reboot & login: Window title buttons are all of a sudden unscaled again while the rest is as expected (see image)
Default wallpaper is grainy at 200% // No workaround

Workaround 1: Mate Tweak > Windows > HiDPI change from "HiDPI" to "auto" and back to "HiDPI"
Workaround 2: Change theme from Yaru Light to something else and back to Yaru light

[Martin Wimpress  (flexiondotorg)]

Ubuntu MATE 22.04 onwards use the Metacity theme from upstream Yaru, which I maintain.

I have tried reproducing this issue and can only do so in one scenario:

 - In the Live Session while using the nouveau driver for NVIDIA GPUs.

@Simon Morgan: Please provide more details about your iGPU/dGPU and drivers.

## Work around

 - Press Alt+F2
 - Run: marco --replace

Or, use MATE Tweak to set the DPI to HiDPI.

[Martin Wimpress  (flexiondotorg)]

Typical! I've just seen this issue on an installed system using Intel integrated graphics.

This might be a race condition with Marco, the window manager, and the settings daemon because it didn't happen on a session restart.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Martin Wimpress  (flexiondotorg)]

I am seeing this happen about 1 in 5 times the desktop session is initialised. I don't think this is an issue with the Metacity theme since it does work, most of the time.

Looks like it might be related to the Marco issue:

 - https://bugs.launchpad.net/ubuntu/+source/marco/+bug/1943289

[Simon Morgan (simonsaysthis)]

Hi Martin, I have an AMD RX6600 (which since 5.13 is quite well supported). But as far as I remember I get the same issue with Intel UHD.

[Martin Wimpress  (flexiondotorg)]

Simon, is this issue intermittent for you?

I've just run through about 20 reboots and haven't experienced it once. Making it somewhat tricky for me to determine if any potential fixes are really a fix.

[Simon Morgan (simonsaysthis)]

Martin, let me do some more indepth testing next week and revert on this question. Its a pitty my mainboard just blew. But I can confidently say that the behaviour is predictable rather than random

[Martin Wimpress  (flexiondotorg)]

Pull request for yaru submitted here:

- https://github.com/ubuntu/yaru/pull/3601

[Launchpad Janitor (janitor)]

This bug was fixed in the package yaru-theme - 22.04.4

---------------
yaru-theme (22.04.4) jammy; urgency=medium

  [ Marco Trevisan (Treviño) ]
  * icons: Ensure symlinks are installed as such for all variants
  * icons: Avoid adding symlink to parent dark variants if not enabled
  * icons: Cleanup meson file, re-organizing logic
  * CI: Add CI job that builds debian packages and builds them
  * build-ci: Compile both default and full options
  * gtk/index.theme: Follow the standard on index definition.
    There's not a real standard definition but the latest one is still
    defined at https://wiki.xfce.org/gnome-theme-package
  * gtk: Include some X-Yaru parameters on index.theme
  * accent-colors: Also override $accent_color variable.
    It's used by libadwaita for now, but could be used more, so let's define
    it too.
  * gtk: Include accent color code in the index.theme.
    It could be used to do easily figure out the color code so that we avoid
    hard-coding it in places such as g-c-c
  * meson: Only build default variant of accent colors if default is enabled
  * CI: Also include mate-dark variant when rendering icons.
    We don't want to avoid symlinks from being generated
  * generate-symlinks: Ensure that we don't overwrite already generated symlinks
    It means we're doing something wrong in our lists, so let's avoid it
  * generate-symlinks: Fix handling of some arguments
  * icons: Ensure we don't overwrite already created symlinks
  * panel: Avoid using symlinks of symlinks as source.
    This is causing errors as it depends on the symlinks .list files and we
    don't want so.
  * icons: Ensure symlinks are not pointing to other symlinks.
    While this works, it may lead to troubles when a synlink is supposed to
    be created by upcoming definitions, so let's avoid this
  * build-ci: Also run on pull requests
  * build-deb: Add git version to package
  * debian: Ensure gnome-shell themes symlinks are preserved
  * debian: Add pre-install script that removes dangling symlinks (LP: #1968405)
  * icons: Update rendered icons and symlinks

  [ Martin Wimpress ]
  * icons: Add panel icons for MATE Optimus, Diodon, Caffiene & Variety
  * icons: Make dropboxstatus-x.svg panel icons a red that is consistent with
    other "alert" panel icons
  * icons: Add symlinks for missing gaming input battery levels (LP: #1967854)
  * icons: Add gaming-input symlink mapping to panel.list (LP: #1967854)
  * metacity: Define the base button dimensions
    This is used to determine whether the image needs to be re-scaled when
    rendering on different DPI densities. (LP: #1967507)
  * metacity: Add window buttons to dialog window
  This ensures dialog windows will always have a close window button.

  [ Paul Kepinski ]
  * GS: fix fg_color of unfocused selected calendar day
  * GS: fix lock screen switch user button in light theme
  * GS: fix entries border radius (LP: #1967826)
  * Sync Gtk popover/menu bg with GS
  * GS: fix for entries height shift
  * Fix notifications shadow (revert to upstream look)
    * Move up notification shadow
  * Add ubiquity 22x22 size
  * Nautilus drop image preview border-radius
  * Nautilus fix selecte...