The nvidia debian/rules mis-compiles Modaliases

[jeremyszu]

[Impact]
The nvidia drivers packaging scripts have a way to add PCI IDs manually to the Modaliases and Pmaliases field in the debian/control. Because of a bug, doing so, only works for the Pmaliases field.

[Test Case]
1) Add the proposed repository

2) Look for the following IDs, using apt-cache, making sure they show up for both the Modaliases field and the Pmaliases field:

2438 24BA 24BB 25B9 25BA

Something as follows should be enough:

apt-cache show nvidia-driver-510 | grep $ID

3) Attach the result.

[Regression Potential]
This change does not affect anything else in the package other than the modaliases, hence the regression potential is extremely low.

[Discussion]

[Changelog]

______________________

Although adding support GPU list here:
https://github.com/tseliot/nvidia-graphics-drivers/commit/d2533550bc88ef00d6a56f71c4c09e43026a93d7

They are only show in "Pmaliases:" but "Modaliases:".

[jeremyszu (os369510)]

https://github.com/tseliot/nvidia-graphics-drivers/pull/47

[Launchpad Janitor (janitor)]

This bug was fixed in the package nvidia-graphics-drivers-510 - 510.54-0ubuntu2

---------------
nvidia-graphics-drivers-510 (510.54-0ubuntu2) jammy; urgency=medium

  [ Jeremy Szu ]
  * Fix regex in modalias addition, since it does not work
    in dash (LP: #1964756)

  [ Dimitri John Ledkov ]
  * debian/rules, debian/rules.defs:
    - Drop remove-stack-markings.
  * templates: encode amd64-only libraries and binaries
    - Improve unpacking logic.
    - Enable arm64 builds
    - Drop unused autogen target.
    - Drop unused AUTOCLEAN.
    - Drop call to AUTOKEEP.
    - Fix clean target. After ./debian/rules unpack-stamp;
      calling ./debian/rules clean did not clean correct
      symlinks. It looks like unpackging has moved from an
      $arch/ subdir, to the package top-level, whilst
      dh_auto_clean was not adjusted.
  * debian/templates/libnvidia-compute-flavour.install.in,
    debian/templates/libnvidia-gl-flavour.install.in,
    debian/templates/nvidia-driver-flavour.docs.in,
    debian/templates/nvidia-kernel-common-flavour.docs.in,
    debian/templates/nvidia-kernel-common-flavour.install.in,
    debian/templates/nvidia-kernel-common-flavour.install.in:
    - Encode amd64-only libraries and binaries. Some libraries
      and binaries are amd64-only, mark them as such, instead
      of i386_excluded.

 -- Alberto Milone <email address hidden> Tue, 15 Mar 2022 09:05:04 +0000

[jeremyszu (os369510)]

This issue needs to be fixed in focal as well.

[Andy Whitcroft (apw)]

Hello jeremyszu, or anyone else affected,

Accepted nvidia-graphics-drivers-510 into impish-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nvidia-graphics-drivers-510/510.60.02-0ubuntu0.21.10.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-impish to verification-done-impish. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-impish. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Andy Whitcroft (apw)]

Hello jeremyszu, or anyone else affected,

Accepted nvidia-graphics-drivers-510 into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nvidia-graphics-drivers-510/510.60.02-0ubuntu0.20.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted nvidia-graphics-drivers-510 (510.60.02-0ubuntu0.21.10.2) for impish have finished running.
The following regressions have been reported in tests triggered by the package:

pyopencl/2021.1.2-1build2 (amd64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/impish/update_excuses.html#nvidia-graphics-drivers-510

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Andy Whitcroft (apw)]

The verification of the Stable Release Update for nvidia-graphics-drivers-510 has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package nvidia-graphics-drivers-510 - 510.60.02-0ubuntu0.21.10.2

---------------
nvidia-graphics-drivers-510 (510.60.02-0ubuntu0.21.10.2) impish; urgency=medium

  [ Jeremy Szu ]
  * Fix regex in modalias addition, since it does not work
    in dash (LP: #1964756)

nvidia-graphics-drivers-510 (510.60.02-0ubuntu0.21.10.1) impish; urgency=medium

  * New upstream release (LP: #1966093):
    - Added support for the following GPUs:
        NVIDIA RTX A4000H
        NVIDIA RTX A5500
    - Fixed a bug that could cause displays with HDMI or DisplayPort
      audio to be deselected as the default audio output device after
      resuming from suspend.
    - Fixed a regression that could cause OpenGL applications to hang
      or render incorrectly after suspend/resume cycles or VT-
      switches
    - Fixed a bug, introduced in 495.29.05, that caused GPU "Model:"
      in /proc/driver/nvidia/gpus/<Bus:Device.Function>/information
      to be "Unknown" for some GPUs.

 -- Alberto Milone <email address hidden> Thu, 31 Mar 2022 15:30:48 +0200

[Launchpad Janitor (janitor)]

This bug was fixed in the package nvidia-graphics-drivers-510 - 510.60.02-0ubuntu0.20.04.2

---------------
nvidia-graphics-drivers-510 (510.60.02-0ubuntu0.20.04.2) focal; urgency=medium

  [ Jeremy Szu ]
  * Fix regex in modalias addition, since it does not work
    in dash (LP: #1964756).

nvidia-graphics-drivers-510 (510.60.02-0ubuntu0.20.04.1) focal; urgency=medium

  * New upstream release (LP: #1966093):
    - Added support for the following GPUs:
        NVIDIA RTX A4000H
        NVIDIA RTX A5500
    - Fixed a bug that could cause displays with HDMI or DisplayPort
      audio to be deselected as the default audio output device after
      resuming from suspend.
    - Fixed a regression that could cause OpenGL applications to hang
      or render incorrectly after suspend/resume cycles or VT-
      switches
    - Fixed a bug, introduced in 495.29.05, that caused GPU "Model:"
      in /proc/driver/nvidia/gpus/<Bus:Device.Function>/information
      to be "Unknown" for some GPUs.

 -- Alberto Milone <email address hidden> Thu, 31 Mar 2022 15:33:30 +0200