Upgrade step: add "progress" page overwrites the access config in the collection

[Doris Tam]

The creation of progress pages, from Bug 1922634: Portfolio review block, which made these pages official views type='progress' did not borrow the view config of existing pages.

When the new progress page was saved to a collection, the existing pages' config updated according to the progress page which did not have any config set to anything, e.g. 'allowcomments' not set which defaulted the rest of the pages in the collection to have 'allowcomments' set to 'No'.

Fix: Once the progress page is added it means the old index = 0 is now index = 1, so we add a flag to make sure the second page's config (with existing config) are propagated.

Test:

1. Have a fresh 20.10 site.
2. Be a member of an institution with 'Portfolio completion' set to 'Yes'.
3. Create a collection with portfolio completion and one other page.
4. Check that the page setting 'Allow comments' is set to 'Yes' and save.
5. Upgrade the site to main.
6. Go to the access settings of a page in your collection.
7. Expand the 'Advanced options' and check that 'Allow comments' is still set to 'Yes'.

Expected: The setting for 'Allow comments' is the same before and after the upgrade step.
Actual: The setting for 'Allow comments' is set to 'No'.

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/12486

[Robert Lyon (robertl-9)]

I've marked this high instead of critical as the problem can be manually fixed via the system on a individual basis

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/12486
Committed: https://git.mahara.org/mahara/mahara/commit/e77af80df28086f1da4a4230ad87acb7ffa0eb8a
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit e77af80df28086f1da4a4230ad87acb7ffa0eb8a
Author: Doris Tam <email address hidden>
Date: Wed Mar 9 17:23:24 2022 +1300

Bug 1964295: Add index flag on add progresscompletion_view

When we call add_views() in add_progresscompletion_view, we want
to use index=1 (a pre-existing portfolio page) to copy over config
to the new progress page.

Change-Id: I7da59356d0021027c31b78907b507f7c7044fbd9

[Mahara Bot (dev-mahara)]

Patch for "21.10_DEV" branch: https://reviews.mahara.org/12496

[Mahara Bot (dev-mahara)]

Patch for "21.04_DEV" branch: https://reviews.mahara.org/12497

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/12496
Committed: https://git.mahara.org/mahara/mahara/commit/8a650ecfa8f15475639b5fd991399fca1b045bbc
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.10_DEV

commit 8a650ecfa8f15475639b5fd991399fca1b045bbc
Author: Doris Tam <email address hidden>
Date: Wed Mar 9 17:23:24 2022 +1300

Bug 1964295: Add index flag on add progresscompletion_view

When we call add_views() in add_progresscompletion_view, we want
to use index=1 (a pre-existing portfolio page) to copy over config
to the new progress page.

Change-Id: I7da59356d0021027c31b78907b507f7c7044fbd9
(cherry picked from commit e77af80df28086f1da4a4230ad87acb7ffa0eb8a)

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/12497
Committed: https://git.mahara.org/mahara/mahara/commit/8e2c01eca2d5014fd362ecaa230a61170939da11
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.04_DEV

commit 8e2c01eca2d5014fd362ecaa230a61170939da11
Author: Doris Tam <email address hidden>
Date: Wed Mar 9 17:23:24 2022 +1300

Bug 1964295: Add index flag on add progresscompletion_view

When we call add_views() in add_progresscompletion_view, we want
to use index=1 (a pre-existing portfolio page) to copy over config
to the new progress page.

Change-Id: I7da59356d0021027c31b78907b507f7c7044fbd9
(cherry picked from commit e77af80df28086f1da4a4230ad87acb7ffa0eb8a)