Sign-off and verification status not saved to database on copied portfolio

[Kristina Hoeppner]

When you copy a portfolio with the sign-off and verification block, the status is not saved to the database unless it's a direct copy of a template portfolio.

To replicate:

1. Allow portfolio completion for the institution.
2. Create a page and add the 'sign-off' block.
3. Add the page to a collection with the portfolio completion active.
4. On the page or the portfolio completion page, click the 'Sign-off' icon.
5. Refresh the page.

Results:
- Expected: The green tick stays.
- Actual: The green tick is visible.

6. Copy the portfolio.
7. Click the 'Sign-off' icon.
8. Refresh the page.

Results:
- Expected: The green tick stays.
- Actual: The green tick is not visible but the red dot is because the row is not actually saved into the database.

Additional scenarios to test:

1. The verification icon should also be clickable.
2. When a template (on the site) is copied, the icons need to be clickable and their status saved.

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/12483

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/12483
Committed: https://git.mahara.org/mahara/mahara/commit/8c4be782175461356cb5896fec5aa2aa57e3d533
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit 8c4be782175461356cb5896fec5aa2aa57e3d533
Author: Robert Lyon <email address hidden>
Date: Wed Mar 9 12:34:14 2022 +1300

Bug 1964268: Copied signoff blocks to self need db row

When copying a signoff block from another owners page it sets up a row
in view_signoff_verify as expected. But when copying own page it
doesn't

So fixed that and have upgrade step to fix existing data

Change-Id: Id372a5da29aaaf53884ffee60ae8b9d9b4738992
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "20.10_DEV" branch: https://reviews.mahara.org/12487

[Mahara Bot (dev-mahara)]

Patch for "21.04_DEV" branch: https://reviews.mahara.org/12488

[Mahara Bot (dev-mahara)]

Patch for "21.10_DEV" branch: https://reviews.mahara.org/12489

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/12487
Committed: https://git.mahara.org/mahara/mahara/commit/896d29cefafd2cd906ad51b74850d6707eeee19f
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.10_DEV

commit 896d29cefafd2cd906ad51b74850d6707eeee19f
Author: Robert Lyon <email address hidden>
Date: Wed Mar 9 12:34:14 2022 +1300

Bug 1964268: Copied signoff blocks to self need db row

When copying a signoff block from another owners page it sets up a row
in view_signoff_verify as expected. But when copying own page it
doesn't

So fixed that and have upgrade step to fix existing data

Change-Id: Id372a5da29aaaf53884ffee60ae8b9d9b4738992
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/12489
Committed: https://git.mahara.org/mahara/mahara/commit/9ab589b0cbc51e54d55ff08ce2246bb32e15b1ea
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.10_DEV

commit 9ab589b0cbc51e54d55ff08ce2246bb32e15b1ea
Author: Robert Lyon <email address hidden>
Date: Wed Mar 9 12:34:14 2022 +1300

Bug 1964268: Copied signoff blocks to self need db row

When copying a signoff block from another owners page it sets up a row
in view_signoff_verify as expected. But when copying own page it
doesn't

So fixed that and have upgrade step to fix existing data

Change-Id: Id372a5da29aaaf53884ffee60ae8b9d9b4738992
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/12488
Committed: https://git.mahara.org/mahara/mahara/commit/95d4f9f2e1bb95e66f787d9fb343794e396f97d0
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.04_DEV

commit 95d4f9f2e1bb95e66f787d9fb343794e396f97d0
Author: Robert Lyon <email address hidden>
Date: Wed Mar 9 12:34:14 2022 +1300

Bug 1964268: Copied signoff blocks to self need db row

When copying a signoff block from another owners page it sets up a row
in view_signoff_verify as expected. But when copying own page it
doesn't

So fixed that and have upgrade step to fix existing data

Change-Id: Id372a5da29aaaf53884ffee60ae8b9d9b4738992
Signed-off-by: Robert Lyon <email address hidden>