[SRU] torbrowser-launcher crashed with move(self, int, int) in main(): argument 1 has unexpected type 'float'
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
torbrowser-launcher (Ubuntu) |
Fix Released
|
Medium
|
Thomas Ward | ||
Jammy |
Fix Released
|
Medium
|
Unassigned | ||
Kinetic |
Fix Released
|
Medium
|
Thomas Ward |
Bug Description
[Impact]
Since Ubuntu Jammy and Python 3.10, there has been a change to how Python does strict type-checking. As a result, Qt requirements and `gui.move` require data to be passed into functions as the expected datatype.
`gui.move` expects two int values, and not Floats. torbrowser-launcher used standard division and expected implicit type casting to happen which worked in prior Python versions. Instead, we now need to do integer division specifically for the values to pass into gui.move.
The patch for this was implied and suggested by people on upstream Git however Git has not accepted this patch in over a month.
Kinetic and Jammy are impacted. Uploads have been made containing the patch to fix this in both Kinetic and Jammy, however while Kinetic is just Accepted, the Jammy package needs SRU'd.
[Test Plan]
Reproduce crash:
1. Install Kinetic or Jammy with Desktop/GUI
2. Install torbrowser-
3. Attempt to launch the launcher in GUI, it won't load and on command line has an unexpected type failure.
With the fixed packaging:
Attempting to launch the GUI will Just Work
[Where problems could occur]
In this two line change originally proposed upstream by contributors and tested by multiple upstream users, it was confirmed this introduces no additional issues and only fixes the gui.move TypeError problem.
I do not foresee this causing any problems as this has been used for over a month by people manually patching the Launcher and it just working for them.
[Original Description]
...
ProblemType: Crash
DistroRelease: Ubuntu 22.04
Package: torbrowser-launcher 0.3.3-6ubuntu1
ProcVersionSign
Uname: Linux 5.15.0-18-generic x86_64
ApportVersion: 2.20.11-0ubuntu78
Architecture: amd64
CasperMD5CheckR
CurrentDesktop: ubuntu:GNOME
Date: Thu Mar 3 17:43:33 2022
ExecutablePath: /usr/bin/
InstallationDate: Installed on 2022-03-02 (0 days ago)
InstallationMedia: Ubuntu 18.04.6 LTS "Bionic Beaver" - Release amd64 (20210915)
InterpreterPath: /usr/bin/python3.10
ProcCmdline: /usr/bin/python3 /usr/bin/
Python3Details: /usr/bin/
PythonArgs: ['/usr/
PythonDetails: N/A
SourcePackage: torbrowser-launcher
Title: torbrowser-launcher crashed with move(self, int, int) in main(): argument 1 has unexpected type 'float'
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: adm cdrom dip lpadmin plugdev sambashare sudo
tags: | removed: need-duplicate-check |
Changed in torbrowser-launcher (Ubuntu): | |
importance: | Undecided → Medium |
tags: | added: kinetic |
Changed in torbrowser-launcher (Ubuntu Jammy): | |
status: | New → Confirmed |
importance: | Undecided → Medium |
Changed in torbrowser-launcher (Ubuntu Kinetic): | |
assignee: | nobody → Thomas Ward (teward) |
Changed in torbrowser-launcher (Ubuntu Jammy): | |
assignee: | nobody → Thomas Ward (teward) |
Changed in torbrowser-launcher (Ubuntu Kinetic): | |
status: | Confirmed → In Progress |
information type: | Private → Public |
description: | updated |
Changed in torbrowser-launcher (Ubuntu Jammy): | |
assignee: | Thomas Ward (teward) → nobody |
Changed in torbrowser-launcher (Ubuntu Kinetic): | |
status: | In Progress → Fix Committed |
Status changed to 'Confirmed' because the bug affects multiple users.