ogre-next SMID fix for ppc64el, riscv64, s390x

Bug #1961319 reported by Jose Luis Rivero
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ogre-next (Ubuntu)
Fix Released
Undecided
Jose Luis Rivero

Bug Description

Following up the last comment in https://bugs.launchpad.net/ubuntu/+bug/1960149:

ogre-next is failing for ppc64el, riscv64, s390x with the following massage in the three of them:
https://launchpad.net/ubuntu/+source/ogre-next/2.2.5+dfsg3-0ubuntu1
"""
/<<BUILDDIR>>/ogre-next-2.2.5+dfsg3/OgreMain/include/Math/Array/OgreArrayConfig.h:155:10: error: #error "Unknown platform or platform not supported for SIMD. Build Ogre without OGRE_USE_SIMD"
  155 | #error "Unknown platform or platform not supported for SIMD. Build Ogre without OGRE_USE_SIMD"
      | ^~~~~
"""

The reason is that the configuration leave enabled the OGRE_USE_SIMD for anything but arm*. The logic should be reverted and only enable it on x64.

Tags: jammy patch
Changed in ogre-next (Ubuntu):
assignee: nobody → Jose Luis Rivero (j-rivero)
description: updated
Revision history for this message
Jose Luis Rivero (j-rivero) wrote :

I think I solved it. Attached is the debdiff with the pacth to d/rules and the bump to d/changelog.

I tested it in all the arches in https://launchpad.net/~j-rivero/+archive/ubuntu/ogre-next-jammy/+packages (bump there from 0ubuntu2 to 0ubuntu2.1 was nothing but rebuild with all arches enabled in the PPA).

I've also updated the bzr branch, commits 8 and 9
https://code.launchpad.net/~j-rivero/+junk/ogre-next

Thanks.

tags: added: patch
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Since I handled the original NEW, let me try sponsoring this for you today.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Change looks sensible, sponsored!

Changed in ogre-next (Ubuntu):
status: New → In Progress
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ogre-next - 2.2.5+dfsg3-0ubuntu2

---------------
ogre-next (2.2.5+dfsg3-0ubuntu2) jammy; urgency=medium

  * Enable SIMD only in amd64 to fix ppc64el, riscv64, s390x
    (LP: #1961319)

 -- Jose Luis Rivero <email address hidden> Thu, 17 Feb 2022 16:12:56 +0000

Changed in ogre-next (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Jose Luis Rivero (j-rivero) wrote :

Thanks Łukasz!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.