external ceph configuration fails; tripleo_ceph_client not in external deploy steps tasks

[John Fulton]

Using Wallaby to deploy an overcloud to connect to an external ceph cluster by deploying with the following:

openstack overcloud deploy \
...
-e /usr/share/openstack-tripleo-heat-templates/environments/external-ceph.yaml \
-e /home/stack/virt/external.yaml \

The deployment fails with this:

2022-02-15 01:38:01,709 p=92373 u=stack n=ansible | 2022-02-15 01:38:01.708165 | 52540094-d704-a222-71ca-000000008e84 | OK | Create /usr/lib/systemd/system-preset/91-netns-placeholder.preset | controller-1
2022-02-15 01:38:01,738 p=92373 u=stack n=ansible | 2022-02-15 01:38:01.737514 | 52540094-d704-a222-71ca-000000008e85 | TASK | Enable and start netns-placeholder
2022-02-15 01:38:01,751 p=92373 u=stack n=ansible | 2022-02-15 01:38:01.749611 | | WARNING | ERROR: Can't run container nova_libvirt_init_secret

Examination the ansible logs does not show a call to the "Configure Ceph Clients" task:

https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/cephadm/ceph-client.yaml#L97

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/829611

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/829639

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/829639
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/565dbd0ab38f2307d72977b17d1f8e239d937023
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 565dbd0ab38f2307d72977b17d1f8e239d937023
Author: Michele Baldessari <email address hidden>
Date: Fri Aug 13 18:14:15 2021 +0200

    nova_libvirt_init_secret Give a proper error if ceph is not configured properly

    Let's make the error a little more clearer when ceph failed to be
    configured properly.

    Before:
    2021-08-13T12: 42:07.472193117+00:00 stdout F ------------------------------------------------
    2021-08-13T12: 42:07.472193117+00:00 stdout F Initializing virsh secrets for: ceph:openstack
    2021-08-13T12: 42:07.481397478+00:00 stdout F --------
    2021-08-13T12: 42:07.481397478+00:00 stdout F Initializing the virsh secret for 'ceph' cluster () 'openstack' client
    2021-08-13T12: 42:07.484466828+00:00 stdout F Creating /etc/nova/ceph-secret.xml
    2021-08-13T12: 42:07.493435343+00:00 stderr F Usage: grep [OPTION]... PATTERN [FILE]...
    2021-08-13T12: 42:07.493435343+00:00 stderr F Try 'grep --help' for more information.
    2021-08-13T12: 42:07.591038798+00:00 stdout F Secret 5e23cf03-81b0-4e02-b678-7c5363fbf0e2 created
    2021-08-13T12: 42:07.591038798+00:00 stdout F
    2021-08-13T12: 42:07.671036635+00:00 stderr F error: failed to get secret '--base64'
    2021-08-13T12: 42:07.671036635+00:00 stderr F error: uuidstr in virSecretLookupByUUIDString must be a valid UUID
    2021-08-13T12: 42:07.674021136+00:00 stdout F

    After:
    2021-08-14T13:10:20.866443451+00:00 stdout F Initializing virsh secrets for: ceph:openstack
    2021-08-14T13:10:20.880988730+00:00 stdout F Error: /etc/ceph/ceph.conf contained an empty fsid definition
    2021-08-14T13:10:20.880988730+00:00 stdout F Check your ceph configuration

    Related-Bug: 1961096

    Change-Id: I781db8142015d713d9e99114aed42667418bf23b
    (cherry picked from commit 61f67eff1046fba283c7993c10d1f37870679c18)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/829611
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/a2674a176d7d6573c1f84e4f242ad37dab73aa7c
Submitter: "Zuul (22348)"
Branch: master

commit a2674a176d7d6573c1f84e4f242ad37dab73aa7c
Author: John Fulton <email address hidden>
Date: Wed Feb 16 21:34:35 2022 +0000

    Update Ceph client service to handle external Ceph

    Update the Ceph client service to handle the external
    Ceph usecase by ensuring that CephClientConfigVars has
    the CephExternalMonHost and CephClusterFSID which were
    missing and caused bug 1961096.

    Closes-Bug: 1961096
    Change-Id: I20335bc2850951926c1a9e9ea0ab761c2c18bb3f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/831860

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/831860
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/669737f2640ec40159be3b1d0f53f07d9128df89
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 669737f2640ec40159be3b1d0f53f07d9128df89
Author: John Fulton <email address hidden>
Date: Wed Feb 16 21:34:35 2022 +0000

    Update Ceph client service to handle external Ceph

    Update the Ceph client service to handle the external
    Ceph usecase by ensuring that CephClientConfigVars has
    the CephExternalMonHost and CephClusterFSID which were
    missing and caused bug 1961096.

    Closes-Bug: 1961096
    Change-Id: I20335bc2850951926c1a9e9ea0ab761c2c18bb3f
    (cherry picked from commit a2674a176d7d6573c1f84e4f242ad37dab73aa7c)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 16.0.0 release.