Mahara

Language pack help files not showing - default to English version

Bug #1960979 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned
Mahara 22.04.0
20.10
Fix Released
High
Unassigned
Mahara 20.10.5
21.04
Fix Released
High
Unassigned
Mahara 21.04.4
21.10
Fix Released
High
Unassigned
Mahara 21.10.2
22.04
Fix Released
High
Unassigned
Mahara 22.04.0

Bug Description

Since language packs are usually installed in the dataroot directory, the is_valid_help_page() function always results in loading the English help texts as a fallback.

To see this in action go to the artefact/file/index.php page, select another language, eg German, and click on the help icon by the title.

The help text popup has the English version in it

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/12425

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12425
Committed: https://git.mahara.org/mahara/mahara/commit/be09347dd3ee272abc3e26bdb61d7dea2397390c
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit be09347dd3ee272abc3e26bdb61d7dea2397390c
Author: Robert Lyon <email address hidden>
Date: Wed Feb 16 14:28:03 2022 +1300

Bug 1960979: Allowlist the dataroot language section for help files

Change-Id: I44711db9e4aaa5b5e57eefc0840a49d2c3ba57a6
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "21.10_DEV" branch: https://reviews.mahara.org/12437

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "21.04_DEV" branch: https://reviews.mahara.org/12438

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "20.10_DEV" branch: https://reviews.mahara.org/12439

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12439
Committed: https://git.mahara.org/mahara/mahara/commit/d627eed7c513b47f8311145e14ddc951baea56c2
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.10_DEV

commit d627eed7c513b47f8311145e14ddc951baea56c2
Author: Robert Lyon <email address hidden>
Date: Wed Feb 16 14:28:03 2022 +1300

Bug 1960979: Allowlist the dataroot language section for help files

Change-Id: I44711db9e4aaa5b5e57eefc0840a49d2c3ba57a6
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit be09347dd3ee272abc3e26bdb61d7dea2397390c)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12437
Committed: https://git.mahara.org/mahara/mahara/commit/f7c958fb27e0845a76faee8228b58da8dfb06eb9
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.10_DEV

commit f7c958fb27e0845a76faee8228b58da8dfb06eb9
Author: Robert Lyon <email address hidden>
Date: Wed Feb 16 14:28:03 2022 +1300

Bug 1960979: Allowlist the dataroot language section for help files

Change-Id: I44711db9e4aaa5b5e57eefc0840a49d2c3ba57a6
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit be09347dd3ee272abc3e26bdb61d7dea2397390c)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12438
Committed: https://git.mahara.org/mahara/mahara/commit/604d29ab8095db16fee2063885e719446416351d
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.04_DEV

commit 604d29ab8095db16fee2063885e719446416351d
Author: Robert Lyon <email address hidden>
Date: Wed Feb 16 14:28:03 2022 +1300

Bug 1960979: Allowlist the dataroot language section for help files

Change-Id: I44711db9e4aaa5b5e57eefc0840a49d2c3ba57a6
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit be09347dd3ee272abc3e26bdb61d7dea2397390c)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.