[SRU] Add iSCSI support to HPE 3PAR driver for Primera 4.2 and higher

[Corey Bryant]

[Description]
OpenStack cinder in Focal (OpenStack Ussuri) is lacking iSCSI support for HPE Primera 4.2 and higher. This is now supported in Cinder and we would like to enable it in Ubuntu Focal as well as OpenStack Ussuri.

The rationale for this SRU falls under harware enablement for Long Term Support releases.

[Test Case]
1. Deploy OpenStack with:
 - HPE 3PAR *iSCSI* driver enabled for Cinder
 - with Primera >= 4.2
  as per: https://docs.openstack.org/cinder/latest/configuration/block-storage/drivers/hpe-3par-driver.html
2. Create a volume
  openstack volume create (--type hpe-primera) --size 10 sru-test-before

3. Confirm the volume is successfully created while it gave an error as "For Primera, only FC is supported. iSCSI cannot be used" previously.

[Regression Potential]
This is a pretty simple patch. Where the code used to always raise a not implemented error for Primera, it now raises the not implemented error only for < Primera 4.2. Where things could go wrong? It's possible the version checking could have an issue but that code seems standard and the upstream patch has been merged back to stable/victoria [1]. Regression testing will cover that code path as well.
[1] https://review.opendev.org/c/openstack/cinder/+/820611

[Corey Bryant (corey.bryant)]

This is in upstream stable/victoria but has not been included in a stable point release yet. Therefore I will proposed new package versions with this patch for the victoria cloud archive as well as focal (ussuri).

[Corey Bryant (corey.bryant)]

New versions of cinder have been uploaded to victoria-staging and the focal unapproved queue.

[Corey Bryant (corey.bryant)]

Hello Corey, or anyone else affected,

Accepted cinder into victoria-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:victoria-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-victoria-needed to verification-victoria-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-victoria-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Robie Basak (racb)]

Hello Corey, or anyone else affected,

Accepted cinder into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cinder/2:16.4.2-0ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Corey Bryant (corey.bryant)]

Hello Corey, or anyone else affected,

Accepted cinder into ussuri-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:ussuri-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-ussuri-needed to verification-ussuri-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-ussuri-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Raghavendra Tilay (raghavendrat)]

Hi,

We tried to install Ussuri devstack on Ubuntu 20.
Observed below error when "./stack.sh" was executed:

++./stack.sh:main:1410 err_trap
++./stack.sh:err_trap:544 local r=2
stack.sh failed: full log in /opt/stack/logs/stack.sh.log.2022-02-07-103212
Error on exit
neutron-dhcp-agent: no process found
neutron-l3-agent: no process found
neutron-metadata-agent: no process found
neutron-openvswitch-agent: no process found

Searched on Google and tried below things:
1] ./unstack.sh ; ./clean.sh and ./stack.sh
2] Install Ubuntu 20 & then ./stack.sh

Both didn't work.

Enclosed logs as attachment.

Any help would be appreciated.

Thanks,
Raghavendra Tilay.

[Corey Bryant (corey.bryant)]

Hi @raghavendrat, were you specifically trying to test this cinder bug?

[Raghavendra Tilay (raghavendrat)]

Hi,
We haven't reached point where we can test this.
We are unable to install OpenStack Ussuri on Ubuntu 20.
Attaching the stack.sh script that we are using during devstack install.

Couple of queries:
1] Corey, were you able to install Ussuri devstack on Ubuntu 20 ?
2] If yes, can you share your stack.sh script ?
3] Will there be any testing from Canonical ?

Regards,
Raghavendra Tilay.

[Nobuto Murata (nobuto)]

Hi Raghavendra,

First of all, thank you for your effort tying to make things forward. I'm afraid devstack works in this specific case because devstack pulls Cinder from git repository directly instead of using Ubuntu's binary packages (.deb basically) if I'm not mistaken. This validation requires using deb packages proposed in specific repository pockets.

I'm aware that a team working with us is trying to validate the proposed packages this week (or by early next week) so I think we can wait for them to provide the feedback.

[Raghavendra Tilay (raghavendrat)]

Thanks Nobuto for response.

[Nobuto Murata (nobuto)]

Tested and verified with cloud-archive:victoria-proposed.

apt-cache policy cinder-common
cinder-common:
  Installed: 2:17.2.0-0ubuntu1~cloud1
  Candidate: 2:17.2.0-0ubuntu1~cloud1
  Version table:
 *** 2:17.2.0-0ubuntu1~cloud1 500
        500 http://ubuntu-cloud.archive.canonical.com/ubuntu focal-proposed/victoria/main amd64 Packages
        100 /var/lib/dpkg/status
     2:17.2.0-0ubuntu1~cloud0 500
        500 http://ubuntu-cloud.archive.canonical.com/ubuntu focal-updates/victoria/main amd64 Packages
     2:16.4.1-0ubuntu1 500
        500 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 Packages
     2:16.1.0-0ubuntu1 500
        500 http://security.ubuntu.com/ubuntu focal-security/main amd64 Packages
     2:16.0.0~b3~git2020041012.eb915e2db-0ubuntu1 500
        500 http://archive.ubuntu.com/ubuntu focal/main amd64 Packages

[before applying -proposed]

2022-02-24 13:56:09.072 52866 ERROR cinder.volume.drivers.hpe.hpe_3par_iscsi [req-d69ea8d0-9059-46de-b931-d5acf2d6f9c1 - - - - -] For Primera, only FC is supported. iSCSI cannot be used
2022-02-24 13:56:09.073 52866 ERROR cinder.volume.manager [req-d69ea8d0-9059-46de-b931-d5acf2d6f9c1 - - - - -] Failed to initialize driver.: NotImplementedError
2022-02-24 13:56:09.073 52866 ERROR cinder.volume.manager Traceback (most recent call last):
2022-02-24 13:56:09.073 52866 ERROR cinder.volume.manager File "/usr/lib/python3/dist-packages/cinder/volume/manager.py", line 466, in _init_host
2022-02-24 13:56:09.073 52866 ERROR cinder.volume.manager self.driver.do_setup(ctxt)
2022-02-24 13:56:09.073 52866 ERROR cinder.volume.manager File "/usr/lib/python3/dist-packages/cinder/volume/drivers/hpe/hpe_3par_base.py", line 438, in do_setup
2022-02-24 13:56:09.073 52866 ERROR cinder.volume.manager self._do_setup(common)
2022-02-24 13:56:09.073 52866 ERROR cinder.volume.manager File "/usr/lib/python3/dist-packages/cinder/volume/drivers/hpe/hpe_3par_iscsi.py", line 149, in _do_setup
2022-02-24 13:56:09.073 52866 ERROR cinder.volume.manager raise NotImplementedError()
2022-02-24 13:56:09.073 52866 ERROR cinder.volume.manager NotImplementedError

[after applying -proposed]
2022-02-24 14:18:26.737 58796 INFO cinder.volume.flows.manager.create_volume [req-a12f1979-f76f-4187-9e23-cc667d0ef403 2271c96c9b804f4e86e12ab55a6d9344 268e52aa19b040fca0430b9616a0017e - - -] Volume volume-028e4021-506c-43eb-9f49-d705a420d216 (028e4021-506c-43eb-9f49-d705a420d216): created successfully

$ openstack volume list
+--------------------------------------+-------+-----------+------+-------------+
| ID | Name | Status | Size | Attached to |
+--------------------------------------+-------+-----------+------+-------------+
| 028e4021-506c-43eb-9f49-d705a420d216 | test2 | available | 10 | |
| 57c761cf-5a7e-401d-8b91-10872b5f7804 | test1 | error | 10 | |
+--------------------------------------+-------+-----------+------+-------------+

test1 (w/error) is before, and test2 (w/ available) is after applying -proposed.

[Nobuto Murata (nobuto)]

Tested and verified with focal-proposed.

apt-cache policy cinder-common
cinder-common:
  Installed: 2:16.4.2-0ubuntu2
  Candidate: 2:16.4.2-0ubuntu2
  Version table:
 *** 2:16.4.2-0ubuntu2 500
        500 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     2:16.4.1-0ubuntu1 500
        500 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 Packages
     2:16.1.0-0ubuntu1 500
        500 http://security.ubuntu.com/ubuntu focal-security/main amd64 Packages
     2:16.0.0~b3~git2020041012.eb915e2db-0ubuntu1 500
        500 http://archive.ubuntu.com/ubuntu focal/main amd64 Packages

[before applying -proposed]

2022-02-24 06:59:34.018 52526 ERROR cinder.volume.drivers.hpe.hpe_3par_iscsi [req-65769a6c-7b72-49b4-84e8-dac7bbacc5d1 - - - - -] For Primera, only FC is supported. iSCSI cannot be used
2022-02-24 06:59:34.018 52526 ERROR cinder.volume.manager [req-65769a6c-7b72-49b4-84e8-dac7bbacc5d1 - - - - -] Failed to initialize driver.: NotImplementedError
2022-02-24 06:59:34.018 52526 ERROR cinder.volume.manager Traceback (most recent call last):
2022-02-24 06:59:34.018 52526 ERROR cinder.volume.manager File "/usr/lib/python3/dist-packages/cinder/volume/manager.py", line 466, in _init_host
2022-02-24 06:59:34.018 52526 ERROR cinder.volume.manager self.driver.do_setup(ctxt)
2022-02-24 06:59:34.018 52526 ERROR cinder.volume.manager File "/usr/lib/python3/dist-packages/cinder/volume/drivers/hpe/hpe_3par_base.py", line 438, in do_setup
2022-02-24 06:59:34.018 52526 ERROR cinder.volume.manager self._do_setup(common)
2022-02-24 06:59:34.018 52526 ERROR cinder.volume.manager File "/usr/lib/python3/dist-packages/cinder/volume/drivers/hpe/hpe_3par_iscsi.py", line 149, in _do_setup
2022-02-24 06:59:34.018 52526 ERROR cinder.volume.manager raise NotImplementedError()
2022-02-24 06:59:34.018 52526 ERROR cinder.volume.manager NotImplementedError

[after applying -proposed]

2022-02-24 08:59:05.246 78217 INFO cinder.volume.flows.manager.create_volume [req-3599f424-29db-45b4-bf2d-4a665f3a30b0 91f76503c81d4398ad8f7ec426d2f149 9c05cd46a17c460d87ca375f20a20803 - 5c2cd4d3196643e2b6a4d8f7dc64eef0 5c2cd4d3196643e2b6a4d8f7dc64eef0] Volume volume-2bfb4855-b8c9-4862-9d83-293ff43c6a32 (2bfb4855-b8c9-4862-9d83-293ff43c6a32): created successfully

[Nobuto Murata (nobuto)]

Tested and verified with cloud-archive:ussuri-proposed.

apt-cache policy cinder-common
cinder-common:
  Installed: 2:16.4.2-0ubuntu2~cloud0
  Candidate: 2:16.4.2-0ubuntu2~cloud0
  Version table:
 *** 2:16.4.2-0ubuntu2~cloud0 500
        500 http://ubuntu-cloud.archive.canonical.com/ubuntu bionic-proposed/ussuri/main amd64 Packages
        100 /var/lib/dpkg/status
     2:16.4.1-0ubuntu1~cloud0 500
        500 http://ubuntu-cloud.archive.canonical.com/ubuntu bionic-updates/ussuri/main amd64 Packages
     2:12.0.10-0ubuntu2 500
        500 http://archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages
     2:12.0.9-0ubuntu1.2 500
        500 http://security.ubuntu.com/ubuntu bionic-security/main amd64 Packages
     2:12.0.0-0ubuntu1 500
        500 http://archive.ubuntu.com/ubuntu bionic/main amd64 Packages

[after applying -proposed]

2022-02-24 16:05:15.445 13263 INFO cinder.volume.flows.manager.create_volume [req-ce6cfe06-8291-4933-981d-d5ea90c8f575 c637fcb15b914d54b9a7c202b2abd27a 8e9bce8207ee4f49a8bd2fc68d1ac6cd - 05a27486835a4d31a65cb4f1911c4f16 05a27486835a4d31a65cb4f1911c4f16] Volume volume-f0fa16f0-d8c1-44b0-b939-75a3f54e820e (f0fa16f0-d8c1-44b0-b939-75a3f54e820e): created successfully

[Corey Bryant (corey.bryant)]

The verification of the Stable Release Update for cinder has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Corey Bryant (corey.bryant)]

This bug was fixed in the package cinder - 2:17.2.0-0ubuntu1~cloud1
---------------

 cinder (2:17.2.0-0ubuntu1~cloud1) focal-victoria; urgency=medium
 .
   * d/p/3par-iscsi-driver-primera.patch: Add iSCSI support to
     HPE 3PAR driver for Primera 4.2 and higher (LP: #1959712).

[Launchpad Janitor (janitor)]

This bug was fixed in the package cinder - 2:16.4.2-0ubuntu2

---------------
cinder (2:16.4.2-0ubuntu2) focal; urgency=medium

  * d/p/3par-iscsi-driver-primera.patch: Add iSCSI support to
    HPE 3PAR driver for Primera 4.2 and higher (LP: #1959712).

cinder (2:16.4.2-0ubuntu1) focal; urgency=medium

  * New stable point release for OpenStack Ussuri (LP: #1956994).

 -- Corey Bryant <email address hidden> Wed, 02 Feb 2022 08:30:46 -0500

[Corey Bryant (corey.bryant)]

The verification of the Stable Release Update for cinder has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Corey Bryant (corey.bryant)]

This bug was fixed in the package cinder - 2:16.4.2-0ubuntu2~cloud0
---------------

 cinder (2:16.4.2-0ubuntu2~cloud0) bionic-ussuri; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 cinder (2:16.4.2-0ubuntu2) focal; urgency=medium
 .
   * d/p/3par-iscsi-driver-primera.patch: Add iSCSI support to
     HPE 3PAR driver for Primera 4.2 and higher (LP: #1959712).