Cannot disable external apps & saving settings for External Apps does not give confirm message
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Medium
|
Dianne Tennent |
Bug Description
Related to this bug: https:/
When updating the an external apps configuration settings, there are two issues:
1. There is no confirm message to say that the settings were updated
2. The enable switch remains on 'Yes' even when you switch it to 'No'
Steps to reproduce:
1. Go to Web services>External Apps
2. Type a new name in the 'Application' field.
3. Select LTI 1.1 from the dropdown
4. Click 'Add' (you will be taken to the edit screen)
5. Click 'Save'
Expected outcome:
- Redirected to main external apps page, with a confirmation banner saying 'The configuration settings for x app have been saved.'
Actual outcome:
- Edit page reloads with no confirmation message
Continued:
6. On the app's edit page, click the 'Enabled' switch to change it to 'No'
7. Click 'Save'
Expected outcome
- Redirected to main external apps page, with a confirmation banner saying 'The configuration settings for x app have been saved.'
- When revisiting the edit page for this app, the 'Enabled' switch should be set to 'No'
Actual outcome
- Edit page reloads with no confirmation message
- 'Enabled' switch has changed back to 'Yes'
Will only need to check for apps registered with LTI, Moodle and LTI Advantage (Not mobile or other non-oauth apps: This has already been prevented in this patch here: https:/
It may also be worth checking with an external app that has been registered with a custom webservice group that uses an LTI function.
summary: |
- External apps configuration settings + Cannot disable external apps & saving settings for External Apps does + not give confirm message |
Changed in mahara: | |
assignee: | nobody → Dianne Tennent (dianne-t) |
status: | New → Confirmed |
importance: | Undecided → Medium |
Changed in mahara: | |
status: | Confirmed → In Progress |
milestone: | none → 22.04.0 |
Changed in mahara: | |
milestone: | 22.04.0 → 22.10.0 |
Changed in mahara: | |
milestone: | 22.10.0 → 22.04.0 |
Changed in mahara: | |
status: | In Progress → Fix Committed |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
Patch for "main" branch: https:/ /reviews. mahara. org/12379