Rectangle vs. Rectangle Select handlers zoom inconsistencies

[grofaty]

Pinta master from github on Ubuntu 20.04.

1. Draw Rectangle, Line, Ellipse.
2. Zoom to 200%. Handlers are also zoomed. Problem.

Compare:
3. Rectangle Select.
4. Zoom to 200%. Handlers stay the same size. Correct.

This is probably work in progress for https://github.com/PintaProject/Pinta/pull/211
But I am documenting it as a bug, so this can be tracked and not forget to fix.

[Cameron White (cameronwhite91)]

Yeah, the shape tools haven't been updated to use the new handles that the selection tool now uses.

[Cameron White (cameronwhite91)]

I've been working on this in a separate branch which is ready for some initial testing: https://github.com/PintaProject/Pinta/actions?query=branch%3Afeature%2Fshape-tool-handles

There are some issues I need to fix with redrawing the handles (you can sometimes see the handles left behind at their old positions) but otherwise I think it's working fairly well..

[grofaty (grofaty)]

Thanks for working on handlers.

I have done few tests and have found two problems:
1. After drawing second, third etc rectangle, handlers from previous rectangles are lost.
2. After several undoes handlers still left over.

See attachment.

[grofaty (grofaty)]

Additional:
3. Rectangle Select. Selection made and when after mouse release and move mouse to pointer mouse icon changes to indicate resizing. But in Rectangle this new mouse pointer does not appear.

For above problem I have opened bug report like 7 years ago. See https://bugs.launchpad.net/pinta/+bug/1419641

Maybe this can also now be fixed when handlers are studied and trying to improve them.

[Cameron White (cameronwhite91)]

Thanks for testing! Good catch on issue #1, that behaviour got lost in these changes

[Cameron White (cameronwhite91)]

OK, I think the latest commits on that branch should address all of those. For the mouse cursor a "grab" shape is just always shown - some future work would be to show special icons when the shape is a rectangle, but more work is needed to handle that

[grofaty (grofaty)]

I tested Pinta latest commit from feature/shape-tool-handles branch on Ubuntu 22.10.

It looks the problems in this bug report are now fixed. Playing around with undoes and found problems with undo, that I have reported in separate bug 1996522, because I can reproduce those problem also in master branch.

I don't want to write too many problems in single bug report. Actually for simplicity there should be followed one bug report per problem.

[Cameron White (cameronwhite91)]

Merged into the master branch: https://github.com/PintaProject/Pinta/commit/4b39c97a1a5bb4daa817340a6b860afd327e12ac